Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

2015-01-30 Thread Rickard Strandqvist
is to remove the *entire* if statement, as we can't end up doing the 'return -ENODEV' Hi Ok, but think or know. Who knows? Do the remove if patch? Kind regards Rickard Strandqvist -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

[PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

2015-01-29 Thread Rickard Strandqvist
Fix a possible null pointer dereference, there is otherwise a risk of a possible null pointer dereference. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/staging/media/lirc/lirc_zilog.c

[PATCH] staging: media: vino: vino: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/staging/media/vino/vino.c

Re: [PATCH] media: pci: solo6x10: solo6x10-enc.c: Remove unused function

2015-01-17 Thread Rickard Strandqvist
? The feature was never implemented, so yes, and we should keep it around. Hi But maybe add a comment then? Kind regards Rickard Strandqvist -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PATCH] [media] usb: pvrusb2: pvrusb2-hdw: Remove unused function

2015-01-11 Thread Rickard Strandqvist
Remove the function pvr2_hdw_cmd_powerdown() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/media/usb/pvrusb2/pvrusb2-hdw.c |5 - drivers

[PATCH] [media] usb: as102: as10x_cmd_cfg: Remove unused function

2015-01-11 Thread Rickard Strandqvist
Remove the function as10x_cmd_eLNA_change_mode() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/media/usb/as102/as10x_cmd.h |1 - drivers

[PATCH] media: s5p-jpeg: Remove some unused functions

2015-01-04 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: s5p_jpeg_input_raw_y16() s5p_jpeg_timer_disable() s5p_jpeg_timer_enable() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers

[PATCH] media: platform: s5p-jpeg: jpeg-hw-exynos4: Remove some unused functions

2015-01-02 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: exynos4_jpeg_set_timer_count() exynos4_jpeg_get_frame_size() exynos4_jpeg_set_sys_int_enable() exynos4_jpeg_get_fifo_status() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist

[PATCH] media: i2c: adv7604: Remove some unused functions

2015-01-02 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: test_read() edid_read_block() dpp_write() dpp_read() esdp_write() esdp_read() cec_write_clr_set() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv

[PATCH] media: i2c: adv7604.c: Remove some unused functions

2015-01-01 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: vblanking() hblanking() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/media/i2c/adv7604.c | 10 -- drivers

[PATCH] media: pci: mantis: mantis_core.c: Remove unused function

2015-01-01 Thread Rickard Strandqvist
Remove the function write_eeprom_byte() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/media/pci/mantis/mantis_core.c | 23

[PATCH] media: platform: vsp1: vsp1_hsit: Remove unused function

2015-01-01 Thread Rickard Strandqvist
Remove the function vsp1_hsit_read() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/media/platform/vsp1/vsp1_hsit.c |5 - 1 file changed

[PATCH] media: pci: saa7134: saa7134-video.c: Remove unused function

2015-01-01 Thread Rickard Strandqvist
Remove the function saa7134_queue() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/media/pci/saa7134/saa7134-video.c |5 - 1 file changed

[PATCH] media: radio: wl128x: fmdrv_rx.c: Remove unused function

2014-12-21 Thread Rickard Strandqvist
Remove the function fm_rx_get_rds_system() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/media/radio/wl128x/fmdrv_rx.c | 16

[PATCH] media: pci: solo6x10: solo6x10-enc.c: Remove unused function

2014-12-21 Thread Rickard Strandqvist
Remove the function solo_s_jpeg_qp() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/media/pci/solo6x10/solo6x10-enc.c | 35

[PATCH] media: pci: cx18: cx18-alsa-mixer.c: Remove some unused functions

2014-12-20 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: snd_cx18_mixer_tv_vol_get() snd_cx18_mixer_tv_vol_info() snd_cx18_mixer_tv_vol_put() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se

Re: [PATCH] media: pci: cx18: cx18-alsa-mixer.c: Remove some unused functions

2014-12-20 Thread Rickard Strandqvist
2014-12-21 1:06 GMT+01:00 Andy Walls awa...@md.metrocast.net: On December 20, 2014 5:35:17 PM EST, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Removes some functions that are not used anywhere: snd_cx18_mixer_tv_vol_get() snd_cx18_mixer_tv_vol_info

[PATCH v2] media: v4l2-core: v4l2-dv-timings.c: Cleaning up code wrong value used in aspect ratio.

2014-06-14 Thread Rickard Strandqvist
Wrong value used in same cases for the aspect ratio. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/media/v4l2-core/v4l2-dv-timings.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-dv-timings.c b

[PATCH v2] media: v4l2-core: v4l2-dv-timings.c: Cleaning up code wrong value used in aspect ratio.

2014-06-14 Thread Rickard Strandqvist
Wrong value used in same cases for the aspect ratio. This is likely a cut and paste mistake. This was partly found using a static code analysis program called cppcheck. Rickard Strandqvist (1): media: v4l2-core: v4l2-dv-timings.c: Cleaning up code wrong value used in aspect ratio. drivers

[PATCH] media: v4l2-core: v4l2-dv-timings.c: Cleaning up code that putting values to the same variable twice

2014-06-06 Thread Rickard Strandqvist
Instead of putting the same variable twice, was rather intended to set this value to two different variable. This was partly found using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/media/v4l2-core/v4l2-dv

[PATCH] media: usb: dvb-usb-v2: mxl111sf.c: Cleaning up uninitialized variables

2014-06-01 Thread Rickard Strandqvist
There is a risk that the variable will be used without being initialized. This was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/media/usb/dvb-usb-v2/mxl111sf.c |2 +- 1 file