Re: [PATCH] media: venus: Add support for H265 controls required by gstreamer V4L2 H265 module

Hi Kelvin, Thanks for the patch! On 11/30/18 7:31 PM, Kelvin Lawson wrote: > Add support for V4L2_CID_MPEG_VIDEO_HEVC_PROFILE and > V4L2_CID_MPEG_VIDEO_HEVC_LEVEL controls required by gstreamer V4L2 H265 > encoder module. > > Signed-off-by: Kelvin Lawson > --- >

Re: [PATCH v2] media: venus: Support V4L2 QP parameters in Venus encoder

> > Signed-off-by: Kelvin Lawson > --- > drivers/media/platform/qcom/venus/venc.c | 19 +++ > 1 file changed, 19 insertions(+) Acked-by: Stanimir Varbanov -- regards, Stan

Re: [PATCH] media: venus: Support V4L2 QP parameters in Venus encoder

Hi Kelvin, Thanks for the patch! On 11/12/18 12:59 PM, Kelvin Lawson wrote: > Support V4L2 QP parameters in Venus encoder: > * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_QP > * V4L2_CID_MPEG_VIDEO_H264_B_FRAME_QP > * V4L2_CID_MPEG_VIDEO_H264_MIN_QP > * V4L2_CID_MPEG_VIDEO_H264_MAX_QP > >

Re: [PATCH 0/2] Clarify H.264 loop filter offset controls and fix them for coda

Hi Philipp, On 11/28/18 3:01 PM, Philipp Zabel wrote: > Hi, > > the coda driver handles the H.264 loop filter alpha/beta offset controls > incorrectly. When trying to fix them, I noticed that the documentation > is not clear about what these values actually are. > > From the value range of -6

Re: [PATCH] media: venus: support VB2_USERPTR IO mode

Hi Alex, On 10/11/2018 09:50 AM, Alexandre Courbot wrote: > Please ignore this patch - I did not notice that a similar one has > been sent before. The difference is that you made it for decoder as well. Do you need userptr for decoder? -- regards, Stan

Re: [PATCH v3] vb2: check for sane values from queue_setup

Hi, On 09/11/2018 03:46 PM, Johan Fjeldtvedt wrote: > Warn and return error from the reqbufs ioctl when driver sets 0 number > of planes or 0 as plane sizes, as these values don't make any sense. typo: planes -> buffers > Checking this here stops obviously wrong values from propagating >

Re: [PATCH 4/4] venus: firmware: register separate platform_device for firmware loader

Hi Vikash, Could you give a try below patch on your environment? You should keep your 1/4 to 3/4 patches and replace your 4/4 with the below one. You have to drop the compatible string in firmware DT subnode (keep only iommus). On 08/22/2018 03:34 PM, Stanimir Varbanov wrote: > This regist

[PATCH 4/4] venus: firmware: register separate platform_device for firmware loader

This registers a firmware platform_device and associate it with video-firmware DT subnode. Then calls dma configure to initialize dma and iommu. Signed-off-by: Stanimir Varbanov --- .../devicetree/bindings/media/qcom,venus.txt | 13 +- drivers/media/platform/qcom/venus/core.c

Re: [PATCH v3 1/4] venus: firmware: add routine to reset ARM9

Hi, On 07/04/2018 10:06 PM, Vikash Garodia wrote: > Add routine to reset the ARM9 and brings it out of reset. Also > abstract the Venus CPU state handling with a new function. This > is in preparation to add PIL functionality in venus driver. > > Signed-off-by: Vikash Garodia > --- >

Re: [PATCH v3 3/4] venus: firmware: add no TZ boot and shutdown routine

Hi Vikash, On 07/04/2018 10:06 PM, Vikash Garodia wrote: > Video hardware is mainly comprised of vcodec subsystem and video > control subsystem. Video control has ARM9 which executes the video > firmware instructions whereas vcodec does the video frame processing. > This change adds support to

Re: [PATCH v3 2/4] venus: firmware: move load firmware in a separate function

Hi Vikash, On 07/04/2018 10:06 PM, Vikash Garodia wrote: > Separate firmware loading part into a new function. I cannot apply this patch in order to test the series. > > Signed-off-by: Vikash Garodia > --- > drivers/media/platform/qcom/venus/core.c | 4 +- >

Re: [PATCH v3 1/4] venus: firmware: add routine to reset ARM9

Hi Vikash, On 07/04/2018 10:06 PM, Vikash Garodia wrote: > Add routine to reset the ARM9 and brings it out of reset. Also > abstract the Venus CPU state handling with a new function. This > is in preparation to add PIL functionality in venus driver. > > Signed-off-by: Vikash Garodia > --- >

[PATCH v5 10/27] venus: hfi_venus: add suspend functionality for Venus 4xx

This adds suspend (power collapse) functionality by reusing the suspend function for Venus 3xx and also enables idle indicator property for Venus 4xx (where it is disabled by default). Signed-off-by: Stanimir Varbanov Reviewed-by: Tomasz Figa --- drivers/media/platform/qcom/venus/hfi_venus.c

Re: [PATCH v2 11/29] venus: venc,vdec: adds clocks needed for venus 4xx

Hi Tomasz, On 05/24/2018 09:11 AM, Tomasz Figa wrote: > Hi Stanimir, > > On Tue, May 15, 2018 at 5:10 PM Stanimir Varbanov < > stanimir.varba...@linaro.org> wrote: > >> This extends the clocks number to support suspend and resume >> on Venus version 4xx. >

Re: [PATCH 3/4] venus: add check to make scm calls

Hi Jordan, On 22.05.2018 22:50, Jordan Crouse wrote: On Tue, May 22, 2018 at 04:04:51PM +0300, Stanimir Varbanov wrote: Hi Vikash, On 05/17/2018 02:32 PM, Vikash Garodia wrote: In order to invoke scm calls, ensure that the platform has the required support to invoke the scm calls in secure

Re: [PATCH 4/4] media: venus: add PIL support

Hi, On 05/22/2018 04:02 PM, Stanimir Varbanov wrote: > Hi Vikash, > > On 05/17/2018 02:32 PM, Vikash Garodia wrote: >> This adds support to load the video firmware >> and bring ARM9 out of reset. This is useful >> for platforms which does not have trustzone >> to

Re: [PATCH 3/4] venus: add check to make scm calls

Hi Vikash, On 05/17/2018 02:32 PM, Vikash Garodia wrote: > In order to invoke scm calls, ensure that the platform > has the required support to invoke the scm calls in > secure world. This code is in preparation to add PIL > functionality in venus driver. > > Signed-off-by: Vikash Garodia

Re: [PATCH 4/4] media: venus: add PIL support

Hi Vikash, On 05/17/2018 02:32 PM, Vikash Garodia wrote: > This adds support to load the video firmware > and bring ARM9 out of reset. This is useful > for platforms which does not have trustzone > to reset the ARM9. > > Signed-off-by: Vikash Garodia > --- >

Re: [PATCH v2 04/29] venus: hfi_cmds: add set_properties for 4xx version

Hi Tomasz, On 05/18/2018 05:16 PM, Tomasz Figa wrote: > On Tue, May 15, 2018 at 5:13 PM Stanimir Varbanov < > stanimir.varba...@linaro.org> wrote: > >> Adds set_properties method to handle newer 4xx properties and >> fall-back to 3xx for the rest. > >&

Re: [PATCH v2 03/29] venus: hfi: update sequence event to handle more properties

Hi Tomasz, On 05/18/2018 04:53 PM, Tomasz Figa wrote: > On Tue, May 15, 2018 at 5:14 PM Stanimir Varbanov < > stanimir.varba...@linaro.org> wrote: > >> HFI version 4xx can pass more properties in the sequence change >> event, extend the event structure with them. &g

Re: [PATCH v2 02/29] venus: hfi: preparation to support venus 4xx

Hi Tomasz, Thanks for the comments! On 05/18/2018 12:44 PM, Tomasz Figa wrote: > Hi Stanimir, > > On Tue, May 15, 2018 at 5:14 PM Stanimir Varbanov < > stanimir.varba...@linaro.org> wrote: > >> This covers the differences between 1xx,3xx and 4xx. > >&

Re: [PATCH v2 08/29] venus: hfi_venus: fix suspend function for venus 3xx versions

Hi Tomasz, On 05/18/2018 06:14 PM, Tomasz Figa wrote: > On Tue, May 15, 2018 at 5:11 PM Stanimir Varbanov < > stanimir.varba...@linaro.org> wrote: > >> This fixes the suspend function for Venus 3xx versions by >> add a check for WFI (wait for interrupt) bit. This

Re: [PATCH v2 07/29] venus: hfi_venus: add halt AXI support for Venus 4xx

Hi Tomasz, On 05/18/2018 05:23 PM, Tomasz Figa wrote: > On Tue, May 15, 2018 at 5:12 PM Stanimir Varbanov < > stanimir.varba...@linaro.org> wrote: > >> Add AXI halt support for version 4xx by using venus wrapper >> registers. > >> Signed-off-by: Stanimir Va

[PATCH v3 27/29] venus: implementing multi-stream support

) and give them to the firmware. The other decoder output (we called it OPB) format will be NV12 linear format and with the same resolution (or smaller in case the user wants to downscale). Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- Hi Hans, I have updated patch description

Re: [PATCH 01/28] venus: hfi_msgs: correct pointer increment

Hi Tomasz, Thanks for the review! On 05/18/2018 11:33 AM, Tomasz Figa wrote: > Hi Stanimir, > > Thanks for the series. I'll be gradually reviewing subsequent patches. Stay > tuned. :) > Please consider that there is a v2 of this patchset. :) > > Reviewed-by: Tomasz Figa

Re: [PATCH v2 27/29] venus: implementing multi-stream support

Hi Hans, On 05/15/2018 11:17 AM, Hans Verkuil wrote: > Hi Stanimir, > > On 05/15/18 09:58, Stanimir Varbanov wrote: >> This is implementing a multi-stream decoder support. The multi >> stream gives an option to use the secondary decoder output >> with different raw

[PATCH v2 00/29] Venus updates

. * spelling typo in 15/28. * added Reviewed-by for DT changes. * extended 28/28 HEVC support for encoder, now the profile and level are selected properly. Comments are welcome! regards, Stan Stanimir Varbanov (29): venus: hfi_msgs: correct pointer increment venus: hfi: preparation

[PATCH v2 03/29] venus: hfi: update sequence event to handle more properties

HFI version 4xx can pass more properties in the sequence change event, extend the event structure with them. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/hfi.h | 9 ++ drivers/media/platform/qcom/venus/hfi_msgs.

[PATCH v2 02/29] venus: hfi: preparation to support venus 4xx

This covers the differences between 1xx,3xx and 4xx. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/core.h | 4 ++ drivers/media/platform/qcom/venus/helpers.c | 37 +++ drivers/media/platform/qcom/venus/hfi_he

[PATCH v2 01/29] venus: hfi_msgs: correct pointer increment

Data pointer should be incremented by size of the structure not the size of a pointer, correct the mistake. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/hfi_msgs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 04/29] venus: hfi_cmds: add set_properties for 4xx version

Adds set_properties method to handle newer 4xx properties and fall-back to 3xx for the rest. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/hfi_cmds.c | 64 +++- 1 file changed, 63 insertions(+), 1 deletion(-)

[PATCH v2 06/29] venus: hfi: handle buffer output2 type as well

This adds handling of buffers of type OUTPUT2 which is needed to support Venus 4xx version. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/hfi.c | 3 ++- drivers/media/platform/qcom/venus/hfi_msgs.c | 3 ++- 2 files chan

[PATCH v2 07/29] venus: hfi_venus: add halt AXI support for Venus 4xx

Add AXI halt support for version 4xx by using venus wrapper registers. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/hfi_venus.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/media/platform/qcom

[PATCH v2 05/29] venus: hfi: support session continue for 4xx version

This makes possible to handle session_continue for 4xx as well. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/hfi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi.c b/drivers

[PATCH v2 09/29] venus: hfi_venus: move set of default properties to core init

property early before we enter into venus_suspend function where we need to check for ARM9 WFI. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/hfi_venus.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/d

[PATCH v2 08/29] venus: hfi_venus: fix suspend function for venus 3xx versions

This fixes the suspend function for Venus 3xx versions by add a check for WFI (wait for interrupt) bit. This bit is on when the ARM9 is idle and entered in low power mode. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/hfi_venus.c

[PATCH v2 11/29] venus: venc,vdec: adds clocks needed for venus 4xx

This extends the clocks number to support suspend and resume on Venus version 4xx. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/core.h | 4 +-- drivers/media/platform/qcom/venus/vdec.c | 42 ++-- drivers

[PATCH v2 19/29] venus: helpers: add buffer type argument to a helper

This adds one more function argument to pass buffer type to set_output_resolution() helper function. That is a preparation to support secondary decoder output. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/helpers.c | 5 +++-- drivers

[PATCH v2 18/29] venus: delete no longer used bufmode flag from instance

Delete no longer used flag cap_bufs_mode_dynamic from instance structure. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/core.h | 2 -- drivers/media/platform/qcom/venus/hfi_parser.c | 6 +- 2 files changed, 1 insertion

[PATCH v2 12/29] venus: add common capability parser

This adds common capability parser for all supported Venus versions. Having it will help to enumerate better the supported raw formars and codecs and also the capabilities for every codec like max/min width/height, framerate, bitrate and so on. Signed-off-by: Stanimir Varbanov <stanimir.va

[PATCH v2 13/29] venus: helpers: make a commmon function for power_enable

Make common function which will enable power when enabling/disabling clocks and also covers Venus 3xx/4xx versions. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/helpers.c | 51 + drivers/media/platfor

[PATCH v2 15/29] venus: helpers: rename a helper function and use buffer mode from caps

Rename is_reg_unreg_needed() to better name is_dynamic_bufmode() and use buffer mode from enumerated per codec capabilities. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/helpers.c | 21 +++-- 1 file changed, 11 inse

[PATCH v2 20/29] venus: helpers: add a new helper to set raw format

The new helper will has one more argument for buffer type, that way the decoder can configure the format on it's secondary output. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/helpers.c | 52 ++--- drivers

[PATCH v2 16/29] venus: add a helper function to set dynamic buffer mode

Adds a new helper function to set dynamic buffer mode if it is supported by current HFI version. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/helpers.c | 22 ++ drivers/media/platform/qcom/venus/helpers.

[PATCH v2 22/29] venus: helpers: extend set_num_bufs helper with one more argument

Extend venus_helper_set_num_bufs() helper function with one more argument to set number of output buffers for the secondary decoder output. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/helpers.c | 16 ++-- drivers

[PATCH v2 21/29] venus: helpers,vdec,venc: add helpers to set work mode and core usage

These are new properties applicable to Venus version 4xx. Add the helpers and call them from decoder and encoder drivers. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/helpers.c | 28 drivers/media/platfor

[PATCH v2 14/29] venus: core: delete not used flag for buffer mode

Delete not used flag for capture buffer allocation mode. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/core.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/core.h b/drivers/media/platform/qcom

[PATCH v2 23/29] venus: helpers: add a helper to return opb buffer sizes

Add a helper function to return current output picture buffer size. OPB sizes can vary depending on the selected decoder output(s). Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/core.h| 10 ++ drivers/media/platform/qcom

[PATCH v2 24/29] venus: vdec: get required input buffers as well

Rework and rename vdec_cap_num_buffers() to get the number of input buffers too. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/vdec.c | 41 +++- 1 file changed, 24 insertions(+), 17 deletions(-) diff

[PATCH v2 17/29] venus: add helper function to set actual buffer size

Add and use a helper function to set actual buffer size for particular buffer type. This is also preparation to use the second decoder output. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/helpers.c | 12 drivers/media/pl

[PATCH v2 26/29] venus: move frame size calculations in common place

move calculations of raw and compressed in a common helper and make it identical for encoder and decoder. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/helpers.c | 98 + drivers/media/platform/qcom

[PATCH v2 25/29] venus: vdec: new function for output configuration

Make a new function vdec_output_conf() for decoder output configuration. vdec_output_conf() will set properties via HFI interface related to the output configuration, and keep vdec_set_properties() which will set properties related to decoding parameters. Signed-off-by: Stanimir Varbanov

[PATCH v2 28/29] venus: add sdm845 compatible and resource data

This adds sdm845 DT compatible string with it's resource data table. Reviewed-by: Rob Herring <r...@kernel.org> Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- .../devicetree/bindings/media/qcom,venus.txt | 1 + drivers/media/platform/qcom/venus/core.c

[PATCH v2 29/29] venus: add HEVC codec support

This add HEVC codec support for venus versions 3xx and 4xx. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/core.h| 2 ++ drivers/media/platform/qcom/venus/helpers.c | 3 ++ drivers/media/platform/qcom/venus/hfi.c | 2 ++ d

[PATCH v2 27/29] venus: implementing multi-stream support

This is implementing a multi-stream decoder support. The multi stream gives an option to use the secondary decoder output with different raw format (or the same in case of crop). Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/core.h

[PATCH v2 10/29] venus: hfi_venus: add suspend functionality for Venus 4xx

This adds suspend (power collapse) functionality by reusing the suspend function for Venus 3xx and also enables idle indicator property for Venus 4xx (where it is disabled by default). Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom

Re: [PATCH 08/28] venus: hfi_venus: add suspend function for 4xx version

Hi, On 05/09/2018 05:14 PM, Vikash Garodia wrote: > Hi Stanimir, > > On 2018-05-09 16:45, Stanimir Varbanov wrote: >> Hi Vikash, >> >> On 05/02/2018 09:07 AM, vgaro...@codeaurora.org wrote: >>> Hello Stanimir, >>> >>> On 2018-04-24 18:14,

Re: [PATCH 08/28] venus: hfi_venus: add suspend function for 4xx version

Hi Vikash, On 05/02/2018 09:07 AM, vgaro...@codeaurora.org wrote: > Hello Stanimir, > > On 2018-04-24 18:14, Stanimir Varbanov wrote: >> This adds suspend (power collapse) function with slightly >> different order of calls comparing with Venus 3xx. >> >>

Re: [PATCH 10/28] venus: vdec: call session_continue in insufficient event

Hi Vikash, On 05/04/2018 02:09 PM, Vikash Garodia wrote: > Hi Stanimir, > > On 2018-05-03 17:06, Stanimir Varbanov wrote: >> Hi Vikash, >> >> Thanks for the comments! >> >> On  2.05.2018 09:26, Vikash Garodia wrote: >>> Hello Stanimir, >

Re: [PATCH 00/28] Venus updates

Hi Hans, On 7.05.2018 13:41, Hans Verkuil wrote: On 24/04/18 14:44, Stanimir Varbanov wrote: Hello, This patch set aims to: * add initial support for Venus version 4xx (found on sdm845). * introduce a common capability parser to enumerate better supported uncompressed formats

Re: [PATCH 28/28] venus: add HEVC codec support

Hi Hans, On 7.05.2018 13:39, Hans Verkuil wrote: On 24/04/18 14:44, Stanimir Varbanov wrote: This add HEVC codec support for venus versions 3xx and 4xx. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/helpers.c | 3 +++ drivers

Re: [PATCH 10/28] venus: vdec: call session_continue in insufficient event

Hi Vikash, Thanks for the comments! On 2.05.2018 09:26, Vikash Garodia wrote: Hello Stanimir, On 2018-04-24 18:14, Stanimir Varbanov wrote: Call session_continue for Venus 4xx version even when the event says that the buffer resources are not sufficient. Leaving a comment with more

Re: [PATCH 26/28] venus: implementing multi-stream support

Hi Vikash, Please write the comments for the chunk of code for which they are refer to. On 2.05.2018 10:40, Vikash Garodia wrote: Hello Stanimir, On 2018-04-24 18:14, Stanimir Varbanov wrote: This is implementing a multi-stream decoder support. The multi stream gives an option to use

[PATCH 01/28] venus: hfi_msgs: correct pointer increment

Data pointer should be incremented by size of the structure not the size of a pointer, correct the mistake. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/hfi_msgs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 03/28] venus: hfi: update sequence event to handle more properties

HFI version 4xx can pass more properties in the sequence change event, extend the event structure with them. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/hfi.h | 9 ++ drivers/media/platform/qcom/venus/hfi_msgs.

[PATCH 02/28] venus: hfi: preparation to support venus 4xx

This covers the differences between 1xx,3xx and 4xx. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/core.h | 4 ++ drivers/media/platform/qcom/venus/helpers.c | 37 +++ drivers/media/platform/qcom/venus/hfi_he

[PATCH 05/28] venus: hfi: support session continue for 4xx version

This makes possible to handle session_continue for 4xx as well. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/hfi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi.c b/drivers

[PATCH 06/28] venus: hfi: handle buffer output2 type as well

This adds handling of buffers of type OUTPUT2 which is needed to support Venus 4xx version. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/hfi.c | 3 ++- drivers/media/platform/qcom/venus/hfi_msgs.c | 3 ++- 2 files chan

[PATCH 08/28] venus: hfi_venus: add suspend function for 4xx version

This adds suspend (power collapse) function with slightly different order of calls comparing with Venus 3xx. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/hfi_venus.c | 52 +++ 1 file changed, 52 insertions(+)

[PATCH 07/28] venus: hfi_venus: add halt AXI support for Venus 4xx

Add AXI halt support for version 4xx by using venus wrapper registers. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/hfi_venus.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/media/platform/qcom

[PATCH 09/28] venus: venc,vdec: adds clocks needed for venus 4xx

This extends the clocks number to support suspend and resume on Venus version 4xx. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/core.h | 4 +-- drivers/media/platform/qcom/venus/vdec.c | 42 ++-- drivers

[PATCH 11/28] venus: add common capability parser

This adds common capability parser for all supported Venus versions. Having it will help to enumerate better the supported raw formars and codecs and also the capabilities for every codec like max/min width/height, framerate, bitrate and so on. Signed-off-by: Stanimir Varbanov <stanimir.va

[PATCH 10/28] venus: vdec: call session_continue in insufficient event

Call session_continue for Venus 4xx version even when the event says that the buffer resources are not sufficient. Leaving a comment with more information about the workaround. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/vdec

[PATCH 04/28] venus: hfi_cmds: add set_properties for 4xx version

Adds set_properties method to handle newer 4xx properties and fall-back to 3xx for the rest. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/hfi_cmds.c | 64 +++- 1 file changed, 63 insertions(+), 1 deletion(-)

[PATCH 21/28] venus: helpers: extend set_num_bufs helper with one more argument

Extend venus_helper_set_num_bufs() helper function with one more argument to set number of output buffers for the secondary decoder output. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/helpers.c | 16 ++-- drivers

[PATCH 12/28] venus: helpers: make a commmon function for power_enable

Make common function which will enable power when enabling/disabling clocks and also covers Venus 3xx/4xx versions. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/helpers.c | 51 + drivers/media/platfor

[PATCH 19/28] venus: helpers: add a new helper to set raw format

The new helper will has one more argument for buffer type, that way the decoder can configure the format on it's secondary output. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/helpers.c | 52 ++--- drivers

[PATCH 18/28] venus: helpers: add buffer type argument to a helper

This adds one more function argument to pass buffer type to set_output_resolution() helper function. That is a preparation to support secondary decoder output. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/helpers.c | 5 +++-- drivers

[PATCH 17/28] venus: delete no longer used bufmode flag from instance

Delete no longer used flag cap_bufs_mode_dynamic from instance structure. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/core.h | 2 -- drivers/media/platform/qcom/venus/hfi_parser.c | 6 +- 2 files changed, 1 insertion

[PATCH 15/28] venus: add a helper function to set dynamic buffer mode

Adds a new helper function to set dymaic buffer mode if it is supported by current HFI version. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/helpers.c | 22 ++ drivers/media/platform/qcom/venus/helpers.h | 1 + d

[PATCH 14/28] venus: helpers: rename a helper function and use buffer mode from caps

Rename is_reg_unreg_needed() to better name is_dynamic_bufmode() and use buffer mode from enumerated per codec capabilities. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/helpers.c | 21 +++-- 1 file changed, 11 inse

[PATCH 13/28] venus: core: delete not used flag for buffer mode

Delete not used flag for capture buffer allocation mode. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/core.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/core.h b/drivers/media/platform/qcom

[PATCH 27/28] venus: add sdm845 compatible and resource data

This adds sdm845 DT compatible string with it's resource data table. Cc: devicet...@vger.kernel.org Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- .../devicetree/bindings/media/qcom,venus.txt | 1 + drivers/media/platform/qcom/venus/core.c

[PATCH 20/28] venus: helpers,vdec,venc: add helpers to set work mode and core usage

These are new properties applicable to Venus version 4xx. Add the helpers and call them from decoder and encoder drivers. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/helpers.c | 28 drivers/media/platfor

[PATCH 26/28] venus: implementing multi-stream support

This is implementing a multi-stream decoder support. The multi stream gives an option to use the secondary decoder output with different raw format (or the same in case of crop). Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/core.h

[PATCH 23/28] venus: vdec: get required input buffers as well

Rework and rename vdec_cap_num_buffers() to get the number of input buffers too. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/vdec.c | 41 +++- 1 file changed, 24 insertions(+), 17 deletions(-) diff

[PATCH 22/28] venus: helpers: add a helper to return opb buffer sizes

Add a helper function to return current output picture buffer size. OPB sizes can vary depending on the selected decoder output(s). Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/core.h| 10 ++ drivers/media/platform/qcom

[PATCH 24/28] venus: vdec: new function for output configuration

Make a new function vdec_output_conf() for decoder output configuration. vdec_output_conf() will set properties via HFI interface related to the output configuration, and keep vdec_set_properties() which will set properties related to decoding parameters. Signed-off-by: Stanimir Varbanov

[PATCH 25/28] venus: move frame size calculations in common place

move calculations of raw and compressed in a common helper and make it identical for encoder and decoder. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/helpers.c | 98 + drivers/media/platform/qcom

[PATCH 28/28] venus: add HEVC codec support

This add HEVC codec support for venus versions 3xx and 4xx. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/helpers.c | 3 +++ drivers/media/platform/qcom/venus/hfi.c | 2 ++ drivers/media/platform/qcom/venus/vdec.c| 4 d

[PATCH 16/28] venus: add helper function to set actual buffer size

Add and use a helper function to set actual buffer size for particular buffer type. This is also preparation to use the second decoder output. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/helpers.c | 12 drivers/media/pl

[PATCH 00/28] Venus updates

are welcome! regards, Stan Stanimir Varbanov (28): venus: hfi_msgs: correct pointer increment venus: hfi: preparation to support venus 4xx venus: hfi: update sequence event to handle more properties venus: hfi_cmds: add set_properties for 4xx version venus: hfi: support session continue

Re: [PATCH v2] venus: vdec: fix format enumeration

Hi Hans, Could you take this patch it not too late. On 20.03.2018 15:42, Stanimir Varbanov wrote: Hi Alex, Thanks! On 03/19/2018 11:32 AM, Alexandre Courbot wrote: find_format_by_index() stops enumerating formats as soon as the index matches, and returns NULL if venus_helper_check_codec

Re: [PATCH v2] venus: vdec: fix format enumeration

pported codecs > > Signed-off-by: Alexandre Courbot <acour...@chromium.org> > --- > drivers/media/platform/qcom/venus/vdec.c | 13 +++-- > drivers/media/platform/qcom/venus/venc.c | 13 +++-- > 2 files changed, 14 insertions(+), 12 deletions(-) Acked-by: Stanimir Varbanov <stanimir.varba...@linaro.org> -- regards, Stan

Re: [PATCH] venus: vdec: fix format enumeration

Hi Alex, Thanks for the patch! On 13.03.2018 11:11, Alexandre Courbot wrote: > find_format_by_index() stops enumerating formats as soon as the index > matches, and returns NULL if venus_helper_check_codec() finds out that > the format is not supported. This prevents formats to be properly >

Re: [Patch v6 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder

Hi Smitha, Thanks for the patches! On 12/08/2017 11:08 AM, Smitha T Murthy wrote: Add v4l2 controls for HEVC encoder Signed-off-by: Smitha T Murthy Reviewed-by: Andrzej Hajda --- drivers/media/v4l2-core/v4l2-ctrls.c | 118

[PATCH v2] venus: venc: set correctly GOP size and number of B-frames

This change fixes the calculation of B-frames and GOP size by adopt v4l2 controls with the firmware interface expectations. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- Drop usage of do_div to avoid compiler warnings on 32bit systems. drivers/media/platform/qcom

[PATCH 2/2] venus: venc: set correctly GOP size and number of B-frames

This change fixes the calculation of B-frames and GOP size by adopt v4l2 controls with the firmware interface expectations. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/venc.c | 15 --- drivers/media/platform/qcom

[PATCH 1/2] venus: cleanup set_property controls

Move ptype (property type) initialization out of switch case and save few lines of code. Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org> --- drivers/media/platform/qcom/venus/hfi_cmds.c | 73 +--- 1 file changed, 2 insertions(+), 71 deletions(-)

Re: [PATCH 2/2] media: venus: venc: Apply inloop deblocking filter

| 22 ++ > 3 files changed, 26 insertions(+), 4 deletions(-) Reviewed-by: Stanimir Varbanov <stanimir.varba...@linaro.org> -- regards, Stan

  1   2   3   4   >