Re: camera control interface

2018-05-30 Thread Vinod
Hi Laurent, On 30-05-18, 10:31, Laurent Pinchart wrote: > On Wednesday, 30 May 2018 10:28:58 EEST Vinod wrote: > > On 30-05-18, 10:04, Laurent Pinchart wrote: > > >> I am writing a driver for camera control inteface which is an i2c > > >> controller. So looking up

Re: camera control interface

2018-05-30 Thread Vinod
that int he I2C and GPIO subsystems. Well if a user wants to capture multiple cameras and synchronise, wouldn't that need sync of i2c and gpio. I understand it may not be supported but the question is would it be a nice feature for v4l, if so how to go about it? Thanks -- ~Vinod

camera control interface

2018-05-29 Thread Vinod
it's possible to drive I2C clients and GPIOs with hardware controlled timing to allow for sync control of sensors hooked and also for fancy strobe. How would we represent these gpios in v4l2 and allow the control, any ideas on that. Thanks -- ~Vinod

Re: [PATCH v2 11/13] dmaengine: pxa: make the filter function internal

2018-05-25 Thread Vinod
On 24-05-18, 09:07, Robert Jarzmik wrote: > As the pxa architecture and all its related drivers do not rely anymore > on the filter function, thanks to the slave map conversion, make > pxad_filter_fn() static, and remove it from the global namespace. Acked-by: Vinod Koul <vk..

Re: [PATCH v2 10/13] dmaengine: pxa: document pxad_param

2018-05-25 Thread Vinod
On 24-05-18, 09:07, Robert Jarzmik wrote: > Add some documentation for the pxad_param structure, and describe the > contract behind the minimal required priority of a DMA channel. Acked-by: Vinod Koul <vk...@kernel.org> -- ~Vinod

Re: [PATCH 2/8] dmaengine: shdmac: Change platform check to CONFIG_ARCH_RENESAS

2018-04-25 Thread Vinod Koul
remaining #ifdefs. > > This will allow to drop ARCH_SHMOBILE on ARM in the near future. Applied, thanks -- ~Vinod

Re: [PATCH 5/7] mtd: provide helper to prepare buffers for DMA operations

2016-03-08 Thread Vinod Koul
On Tue, Mar 08, 2016 at 12:15:13PM +0100, Boris Brezillon wrote: > > +#ifdef CONFIG_HAS_DMA Shouldn't this be CONFIG_DMA_ENGINE as you are preparing these descriptors for DMA transfer? -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the b

Re: [TRIVIAL PATCH] treewide: Remove unnecessary 0x prefixes before %pa extension uses

2016-03-07 Thread Vinod Koul
For this: > drivers/dma/at_hdmac_regs.h | 2 +- Acked-by: Vinod Koul <vinod.k...@intel.com> -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] dmaengine: sun4i: support module autoloading

2016-03-03 Thread Vinod Koul
tically when building it as a module and running on a system > with the early sunxi DMA engine. Applied, thanks -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-11-18 Thread Vinod Koul
eters, knowing the hw and reason for this (firmware download to DSP memory), this doesn't qualify for slave case. In fact filter function doesn't need a channel, any channel in this controller will be good -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-media"

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-06-24 Thread Vinod Koul
On Mon, Jun 22, 2015 at 02:31:00PM +0300, Peter Ujfalusi wrote: On 06/12/2015 03:58 PM, Vinod Koul wrote: Sorry this slipped thru I was away for a week anyways ;) Thinking about it again, I think we should coverge to two APIs and mark the legacy depracuated and look to convert folks

Re: [PATCH 2/2] genalloc: rename of_get_named_gen_pool() to of_gen_pool_get()

2015-06-12 Thread Vinod Koul
--- drivers/dma/mmp_tdma.c| 2 +- For this: Acked-by: Vinod Koul vinod.k...@intel.com -- ~Vinod -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-06-12 Thread Vinod Koul
On Thu, Jun 04, 2015 at 06:58:06PM +0300, Peter Ujfalusi wrote: Vinod, On 06/02/2015 03:55 PM, Vinod Koul wrote: On Fri, May 29, 2015 at 05:32:50PM +0300, Peter Ujfalusi wrote: On 05/29/2015 01:18 PM, Vinod Koul wrote: On Fri, May 29, 2015 at 11:42:27AM +0200, Geert Uytterhoeven wrote

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-06-02 Thread Vinod Koul
On Fri, May 29, 2015 at 05:32:50PM +0300, Peter Ujfalusi wrote: On 05/29/2015 01:18 PM, Vinod Koul wrote: On Fri, May 29, 2015 at 11:42:27AM +0200, Geert Uytterhoeven wrote: On Fri, May 29, 2015 at 11:33 AM, Vinod Koul vinod.k...@intel.com wrote: On Tue, May 26, 2015 at 04:25:57PM +0300

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-05-29 Thread Vinod Koul
code in case of failure and will pass the -EPROBE_DEFER to the caller in case dma_request_slave_channel_reason() returned with it. This is okay but am worried about one more warpper, how about fixing dma_request_slave_channel_compat() -- ~Vinod Signed-off-by: Peter Ujfalusi peter.ujfal

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-05-29 Thread Vinod Koul
On Fri, May 29, 2015 at 11:42:27AM +0200, Geert Uytterhoeven wrote: On Fri, May 29, 2015 at 11:33 AM, Vinod Koul vinod.k...@intel.com wrote: On Tue, May 26, 2015 at 04:25:57PM +0300, Peter Ujfalusi wrote: dma_request_slave_channel_compat() 'eats' up the returned error codes which prevents

Re: [PATCH 00/12] dmaengine: remove users of device_control

2014-10-15 Thread Vinod Koul
On Sat, Oct 11, 2014 at 09:09:33PM +0530, Vinod Koul wrote: The recent discussion [1] on the API have resulted in moving away from device_control ioctl method to proper channel APIs. There are still few users on the device_control which should use the wrappers existing rather than access

[PATCH 00/12] dmaengine: remove users of device_control

2014-10-11 Thread Vinod Koul
-dma.git/shortlog/refs/heads/topic/dma_control_cleanup Vinod Koul (12): pata_arasan_cf: use dmaengine_terminate_all() API dmaengine: coh901318: use dmaengine_terminate_all() API [media] V4L2: mx3_camer: use dmaengine_pause() API mtd: fsmc_nand: use dmaengine_terminate_all() API mtd

[PATCH 03/12] [media] V4L2: mx3_camer: use dmaengine_pause() API

2014-10-11 Thread Vinod Koul
The drivers should use dmaengine_pause() API instead of accessing the device_control which will be deprecated soon Signed-off-by: Vinod Koul vinod.k...@intel.com --- drivers/media/platform/soc_camera/mx3_camera.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] [media] platform: Fix timberdale dependencies

2014-04-16 Thread Vinod Koul
and it is consistent with what other options are doing. Adding a || HAS_IOMEM to the TIMB_DMA dependencies silenced the kconfig warning about unmet direct dependencies but it was wrong: without MFD_TIMBERDALE, TIMB_DMA is useless as the driver has no device to bind to. Applied, thanks -- ~Vinod

Re: [PATCH][RESEND 3/8] dma: mmp_tdma: use gen_pool_dma_alloc() to allocate descriptor

2013-11-11 Thread Vinod Koul
On Fri, Nov 01, 2013 at 07:48:16PM +0800, Nicolin Chen wrote: Since gen_pool_dma_alloc() is introduced, we implement it to simplify code. Acked-by: Vinod Koul vinod.k...@intel.com -- ~Vinod -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

Re: [alsa-devel] [PATCH 23/51] DMA-API: dma: pl08x: add dma_set_mask_and_coherent() call

2013-09-23 Thread Vinod Koul
On Thu, Sep 19, 2013 at 10:48:01PM +0100, Russell King wrote: The DMA API requires drivers to call the appropriate dma_set_mask() functions before doing any DMA mapping. Add this required call to the AMBA PL08x driver. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk Acked-by: Vinod

Re: [alsa-devel] [PATCH 43/51] DMA-API: dma: edma.c: no need to explicitly initialize DMA masks

2013-09-23 Thread Vinod Koul
-off-by: Russell King rmk+ker...@arm.linux.org.uk Acked-by: Vinod Koul vinod.k...@intel.com This also brings me question that should we force the driver to use the dma_set_mask_and_coherent() API or they have below flexiblity too? ~Vinod --- drivers/dma/edma.c |6 ++ 1 files changed

Re: [alsa-devel] [PATCH 24/51] DMA-API: dma: pl330: add dma_set_mask_and_coherent() call

2013-09-23 Thread Vinod Koul
doing any DMA mapping. Add this required call to the AMBA PL08x driver. ^--- copy and paste error - should of course be PL330 Fixed, thanks. with fixed changelog... Acked-by: Vinod Koul vinod.k...@intel.com ~Vinod -- -- To unsubscribe from this list: send the line

Re: [PATCH 1/2] dmaengine: ipu-idmac: add support for the DMA_PAUSE control

2011-08-29 Thread Vinod Koul
-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Acked-by Vinod Koul vinod.k...@linux.intel.com Do you want this to go thru slave-dma or media tree? -- ~Vinod --- drivers/dma/ipu/ipu_idmac.c | 65 +++--- 1 files changed, 42 insertions(+), 23 deletions