[PATCH 0/2] media: i2c: mt9t112: Add OF tree support

to receive the PPL parameter configuration from platform data (I know...), new OF users are only supported with an external clock frequency of 24MHz. Thanks j Jacopo Mondi (2): dt-bindings: media: i2c: Add mt9t111 image sensor media: i2c: mt9t112: Add device tree support Documentation

[PATCH 2/2] media: i2c: mt9t112: Add device tree support

Add support for OF systems to mt9t112 image sensor driver. As the devicetree bindings use standard name for 'powerdown' gpio, and while at there, update the existing mt9t112 users to use the new name. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- arch/sh/boards/mach-ec

Re: [PATCH v10 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

Hi Simon, On Tue, Apr 24, 2018 at 10:23:56AM +0200, Simon Horman wrote: > On Mon, Apr 23, 2018 at 05:21:43PM +0200, jacopo mondi wrote: > > Hi Simon, > > > > On Wed, Feb 21, 2018 at 07:29:18PM +0100, Simon Horman wrote: > > > On Wed, Feb 21, 2018 at 06:47:

Re: [PATCH 8/8] drm: connector: Remove DRM_BUS_FLAG_DATA_* flags

Hi Laurent, On Tue, Apr 24, 2018 at 12:03:04AM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Thursday, 19 April 2018 12:31:09 EEST Jacopo Mondi wrote: > > DRM_BUS_FLAG_DATA_* flags, defined in drm_connector.h header file are > > used t

Re: [PATCH 5/8] media: Add LE version of RGB LVDS formats

HI Laurent, On Mon, Apr 23, 2018 at 04:06:01PM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Thursday, 19 April 2018 12:31:06 EEST Jacopo Mondi wrote: > > Some LVDS controller can output swapped versions of LVDS RGB formats. > &g

Re: [PATCH v10 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

Hi Simon, On Wed, Feb 21, 2018 at 07:29:18PM +0100, Simon Horman wrote: > On Wed, Feb 21, 2018 at 06:47:58PM +0100, Jacopo Mondi wrote: > > Add Capture Engine Unit (CEU) node to device tree. > > > > Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> > > Revie

Re: [PATCH 6/8] drm: rcar-du: rcar-lvds: Add bridge format support

Hi Peter, On Mon, Apr 23, 2018 at 09:59:22AM +0200, Peter Rosin wrote: > On 2018-04-23 09:28, jacopo mondi wrote: > > Hi Peter, > >thanks for looking into this > > > > On Sun, Apr 22, 2018 at 10:08:21PM +0200, Peter Rosin wrote: > >> On

Re: [PATCH v3 07/11] media: ov772x: handle nested s_power() calls

the last power off. > > This adds an s_power() nesting counter and updates the power state if the > counter is modified from 0 to != 0 or from != 0 to 0. > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc:

Re: [PATCH 3/8] drm: bridge: thc63lvd1024: Add support for LVDS mode map

Hi Peter, On Sun, Apr 22, 2018 at 10:02:51PM +0200, Peter Rosin wrote: > On 2018-04-19 11:31, Jacopo Mondi wrote: > > The THC63LVD1024 LVDS to RGB bridge supports two different LVDS mapping > > modes, selectable by means of an external pin. > > > > Add support for conf

Re: [PATCH 2/8] dt-bindings: display: bridge: thc63lvd1024: Add lvds map property

Hi Peter, thanks for commenting, On Sun, Apr 22, 2018 at 10:02:41PM +0200, Peter Rosin wrote: > On 2018-04-19 11:31, Jacopo Mondi wrote: > > The THC63LVD1024 LVDS to RGB bridge supports two different input mapping > > modes, selectable by means of an external pin. > >

Re: [PATCH 6/8] drm: rcar-du: rcar-lvds: Add bridge format support

Hi Peter, thanks for looking into this On Sun, Apr 22, 2018 at 10:08:21PM +0200, Peter Rosin wrote: > On 2018-04-19 11:31, Jacopo Mondi wrote: > > With the introduction of static input image format enumeration in DRM > > bridges, add support to retrieve the format in rcar-lv

[PATCH 0/8] drm: bridge: Add support for static image formats

, implemented by the following in-review series: [PATCH v9 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge [PATCH v3 0/5] V3M-Eagle HDMI output enablement available for the interested at: git://jmondi.org/linux lvds-bridge/linus-master/v9-eagle-v3 Thanks for comments j Jacopo Mondi (8

[PATCH 2/8] dt-bindings: display: bridge: thc63lvd1024: Add lvds map property

The THC63LVD1024 LVDS to RGB bridge supports two different input mapping modes, selectable by means of an external pin. Describe the LVDS mode map through a newly defined mandatory property in device tree bindings. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- .../devi

[PATCH 3/8] drm: bridge: thc63lvd1024: Add support for LVDS mode map

The THC63LVD1024 LVDS to RGB bridge supports two different LVDS mapping modes, selectable by means of an external pin. Add support for configurable LVDS input mapping modes, using the newly introduced support for bridge input image formats. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.

[PATCH 1/8] drm: bridge: Add support for static image formats

Add support for storing image format information in DRM bridges with associated helper function. This patch replicates for bridges what 'drm_display_info_set_bus_formats()' is for connectors. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/gpu/drm/drm_bridge.

[PATCH 4/8] arm64: dts: renesas: eagle: Add thc63 LVDS map

Add LVDS map mode description property to THC63LVD1024 LVDS decoder in R-Car V3M-Eagle board device tree. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/r

[PATCH 6/8] drm: rcar-du: rcar-lvds: Add bridge format support

for drm connectors, but use the newly introduced _LE version of LVDS mbus image formats. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/gpu/drm/rcar-du/rcar_lvds.c | 64 + 1 file changed, 44 insertions(+), 20 deletions(-) diff

[PATCH 5/8] media: Add LE version of RGB LVDS formats

Some LVDS controller can output swapped versions of LVDS RGB formats. Define and document them in the list of supported media bus formats Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- Documentation/media/uapi/v4l/subdev-formats.rst | 174 include/uapi

[PATCH 7/8] drm: panel: Use _LE LVDS formats for data mirroring

As now both bridges and panels report supported image formats, use the newly introduced _LE version of LVDS media bus formats in place of the DRM_BUS_FLAG_DATA_ flags defined in drm_connector.h Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/gpu/drm/panel/panel-lvds.

[PATCH 8/8] drm: connector: Remove DRM_BUS_FLAG_DATA_* flags

MEDIA_BUS_FMT_RGB888_1X7X*_LE media bus formats, remove them. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- include/drm/drm_connector.h | 4 1 file changed, 4 deletions(-) diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index 675cc3f..9e0d6d5 100644 --- a/inclu

Re: [PATCH v2 10/10] media: ov772x: avoid accessing registers under power saving mode

Hi Sakari, On Wed, Apr 18, 2018 at 04:17:02PM +0300, Sakari Ailus wrote: > On Wed, Apr 18, 2018 at 02:55:36PM +0200, jacopo mondi wrote: > > Hi Akinobu, > > > > On Mon, Apr 16, 2018 at 11:51:51AM +0900, Akinobu Mita wrote: > > > The set_fmt() in subdev pad ops, t

Re: [PATCH v2 10/10] media: ov772x: avoid accessing registers under power saving mode

have you found any case where it is necessary to handle this in the sensor driver? Have I mis-interpreted the use case of this patch? > This avoids it by not apply any changes to H/W if the device is not powered > up. Instead the changes will be restored right after power-up. > > Cc

Re: [PATCH v2 08/10] media: ov772x: handle nested s_power() calls

ly called from platform drivers, and they -should- be safe. Although, I'm not against this protection completely. Others might be, though. > > This adds an s_power() nesting counter and updates the power state if the > counter is modified from 0 to != 0 or from != 0 to 0. > > Cc: J

Re: [PATCH v2 04/10] media: ov772x: add media controller support

Hi Sakari, On Wed, Apr 18, 2018 at 02:58:16PM +0300, Sakari Ailus wrote: > On Wed, Apr 18, 2018 at 01:28:14PM +0200, jacopo mondi wrote: > > Hi Akinobu, > > > > On Mon, Apr 16, 2018 at 11:51:45AM +0900, Akinobu Mita wrote: > > > Create a source pad and set the media

Re: [PATCH v2 01/10] media: ov772x: allow i2c controllers without I2C_FUNC_PROTOCOL_MANGLING

Hi Sakari, On Wed, Apr 18, 2018 at 01:41:54PM +0300, Sakari Ailus wrote: > On Wed, Apr 18, 2018 at 12:05:49PM +0200, jacopo mondi wrote: > > Hi Akinobu, > > > > On Mon, Apr 16, 2018 at 11:51:42AM +0900, Akinobu Mita wrote: > > > The ov772x driver only work

Re: [PATCH v2 07/10] media: ov772x: support device tree probing

the device tree probling can only select auto edge control mode > for now. > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Hans Verkuil <hans.verk...@cisco.com> > Cc: Sakari Ailus <sakari.ai...@l

Re: [PATCH v2 05/10] media: ov772x: use generic names for reset and powerdown gpios

uot; and "powerdown-gpios" respectively) > > There is only one mainline user for these gpios, so rename to generic > names. > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Hans Verkuil <

Re: [PATCH v2 06/10] media: dt-bindings: ov772x: add device tree binding

On Mon, Apr 16, 2018 at 11:51:47AM +0900, Akinobu Mita wrote: > This adds a device tree binding documentation for OV7720/OV7725 sensor. > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Hans Verkuil &l

Re: [PATCH v2 04/10] media: ov772x: add media controller support

Hi Akinobu, On Mon, Apr 16, 2018 at 11:51:45AM +0900, Akinobu Mita wrote: > Create a source pad and set the media controller type to the sensor. > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Hans Verk

Re: [PATCH v2 02/10] media: ov772x: add checks for register read errors

Hi Akinobu, On Mon, Apr 16, 2018 at 11:51:43AM +0900, Akinobu Mita wrote: > This change adds checks for register read errors and returns correct > error code. > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> &g

Re: [PATCH v2 01/10] media: ov772x: allow i2c controllers without I2C_FUNC_PROTOCOL_MANGLING

OTOCOL_MANGLING is that > it doesn't support repeated starts. > > This changes the reading ov772x register method so that it doesn't > require I2C_FUNC_PROTOCOL_MANGLING by calling two separated i2c messages. > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pinchar

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Niklas, On Mon, Apr 16, 2018 at 01:16:35AM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your feedback. > > Comments I have snipped out from this reply are addressed, thanks for > bringing them to my attention! > > On 2018-04-05 11:10:01 +0200, Jacop

Re: [RESEND PATCH v7 2/2] media: dw9807: Add dw9807 vcm driver

HI Andy, thanks for addressing my comments on v6. Some more questions below. On Tue, Apr 10, 2018 at 11:48:44PM +0800, Andy Yeh wrote: > From: Alan Chiang > > DW9807 is a 10 bit DAC from Dongwoon, designed for linear > control of voice coil motor. > > This driver

Re: [PATCH 1/6] media: ov772x: allow i2c controllers without I2C_FUNC_PROTOCOL_MANGLING

Hi Akinobu, On Wed, Apr 11, 2018 at 01:37:03AM +0900, Akinobu Mita wrote: > 2018-04-09 15:58 GMT+09:00 jacopo mondi <jac...@jmondi.org>: > > Hello Akinobu, > > thank you for the patch. > > > > On which platform have you tested the series (just curious) ? >

Re: [PATCH 6/6] media: ov772x: support device tree probing

the device tree probling can only select auto edge control mode > for now. > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Hans Verkuil <hans.verk...@cisco.com> > Cc: Sakari Ailus <sakari.ai...@l

Re: [PATCH 5/6] media: ov772x: add device tree binding

Hi Akinobu, On Sun, Apr 08, 2018 at 12:48:09AM +0900, Akinobu Mita wrote: > This adds a device tree binding documentation for OV7720/OV7725 sensor. Please use as patch subject media: dt-bindings: > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pinch

Re: [PATCH 4/6] media: ov772x: add media controller support

Hi Akinobu, On Sun, Apr 08, 2018 at 12:48:08AM +0900, Akinobu Mita wrote: > Create a source pad and set the media controller type to the sensor. > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Hans Verk

Re: [PATCH 2/6] media: ov772x: add checks for register read errors

returning the actual error code. > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Hans Verkuil <hans.verk...@cisco.com> > Cc: Sakari Ailus <sakari.ai...@linux.intel.com> > Cc: Mauro Carvalho Chehab <

Re: [PATCH 1/6] media: ov772x: allow i2c controllers without I2C_FUNC_PROTOCOL_MANGLING

Although I would like to have a confirmation this is fine by people how has seen more i2c adapters in action than me :) Thanks j > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Hans Verkuil <hans.verk...@ci

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

A few corrections, On Thu, Apr 05, 2018 at 11:10:01AM +0200, jacopo mondi wrote: > Hi Niklas, > thanks for the VIN and CSI-2 effort! > > On Tue, Feb 13, 2018 at 12:01:32AM +0100, Niklas Söderlund wrote: > > A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Niklas, thanks for the VIN and CSI-2 effort! On Tue, Feb 13, 2018 at 12:01:32AM +0100, Niklas Söderlund wrote: > A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver > supports the R-Car Gen3 SoCs where separate CSI-2 hardware blocks are > connected between the video sources

Re: [v2,2/2] media: Add a driver for the ov7251 camera sensor

Hi Todor, On Thu, Mar 29, 2018 at 10:50:10AM +0300, Todor Tomov wrote: > Hi Jacopo, > > > > > > With the above nits clarified, and as you addressed my v1 comments: > > > > Reviewed-by: Jacopo Mondi <jac...@jmondi.org> > > Would you like to see the co

Re: [v2,2/2] media: Add a driver for the ov7251 camera sensor

EST_PATTERN, > + ARRAY_SIZE(ov7251_test_pattern_menu) - 1, > + 0, 0, ov7251_test_pattern_menu); > + ov7251->pixel_clock = v4l2_ctrl_new_std(>ctrls, > + _ctrl_ops,

Re: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver

Hi Andy, a few comments on you patch below... On Sat, Mar 17, 2018 at 01:05:26AM +0800, Andy Yeh wrote: > From: Alan Chiang > > DW9807 is a 10 bit DAC from Dongwoon, designed for linear > control of voice coil motor. > > This driver creates a V4L2 subdevice and >

Re: [PATCH v2 1/4] media: i2c: Copy mt9t112 soc_camera sensor driver

Hi Hans, On Thu, Mar 15, 2018 at 08:30:21AM -0700, Hans Verkuil wrote: > On 03/15/2018 07:38 AM, jacopo mondi wrote: > > Hi Sakari, > >thanks for looking into this! > > > > On Thu, Mar 15, 2018 at 01:35:34PM +0200, Sakari Ailus wrote: > >> Hi Jacopo, &

Re: [PATCH v2 1/4] media: i2c: Copy mt9t112 soc_camera sensor driver

s, should I go with incremental changes on top of this? > On Mon, Mar 12, 2018 at 02:43:02PM +0100, Jacopo Mondi wrote: > > Copy the soc_camera based driver in v4l2 sensor driver directory. > > This commit just copies the original file without modifying it. > > No modifica

Re: [PATCH 1/3] rcar-vin: remove duplicated check of state in irq handler

Hi Niklas, Kieran, On Tue, Mar 13, 2018 at 06:56:54PM +0100, Niklas Söderlund wrote: > Hi Kieran, > > Thanks for your feedback. > > On 2018-03-13 17:42:25 +0100, Kieran Bingham wrote: > > Hi Niklas, > > > > Thanks for the patch series :) - I've been looking forward to seeing this > > one ! > > >

Re: [PATCH 2/3] rcar-vin: allocate a scratch buffer at stream start

Hi Niklas, On Sat, Mar 10, 2018 at 01:09:52AM +0100, Niklas Söderlund wrote: > Before starting capturing allocate a scratch buffer which can be used by > the driver to give to the hardware if no buffers are available from > userspace. The buffer is not used in this patch but prepares for future >

Re: [PATCH v8 13/13] [media] v4l: Document explicit synchronization behavior

Hi Gustavo, a very small comment below On Fri, Mar 09, 2018 at 02:49:20PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Add section to VIDIOC_QBUF and VIDIOC_QUERY_BUF about it > > v6: - Close some gaps in the docs (Hans) > > v5: > - Remove

Re: [PATCH 09/11] media: vsp1: Provide support for extended command pools

Hi Kieran, just one small thing I noticed below... On Fri, Mar 09, 2018 at 10:04:07PM +, Kieran Bingham wrote: > VSPD and VSP-DL devices can provide extended display lists supporting > extended command display list objects. > > These extended commands require their own dma memory areas

Re: [PATCH 5/5] media: MAINTAINERS: Add entry for Aptina MT9T112

Hi Sakari, On Sun, Mar 11, 2018 at 10:15:14PM +0200, Sakari Ailus wrote: > Hi Jacopo, > > On Fri, Mar 02, 2018 at 05:35:41PM +0100, Jacopo Mondi wrote: > > Add entry for Aptina/Micron MT9T112 camera sensor. The driver is > > currently orphaned. > > > > Signed-

Re: [PATCH 3/3] rcar-vin: use scratch buffer and always run in continuous mode

form/rcar-vin/rcar-vin.h > @@ -38,13 +38,11 @@ enum chip_id { > /** > * STOPPED - No operation in progress > * RUNNING - Operation in progress have buffers > - * STALLED - No operation in progress have no buffers > * STOPPING - Stopping operation > */ > enum rvin_dma_state { > STOPPED = 0, > RUNNING, > - STALLED, > STOPPING, > }; > > @@ -105,11 +103,10 @@ struct rvin_graph_entity { > * @scratch: cpu address for scratch buffer > * @scratch_phys:pysical address of the scratch buffer > * > - * @qlock: protects @queue_buf, @buf_list, @continuous, @sequence > + * @qlock: protects @queue_buf, @buf_list, @sequence > * @state > * @queue_buf: Keeps track of buffers given to HW slot > * @buf_list:list of queued buffers > - * @continuous: tracks if active operation is continuous or > single mode > * @sequence:V4L2 buffers sequence number > * @state: keeps track of operation state > * > @@ -138,7 +135,6 @@ struct rvin_dev { > spinlock_t qlock; > struct vb2_v4l2_buffer *queue_buf[HW_BUFFER_NUM]; > struct list_head buf_list; > - bool continuous; > unsigned int sequence; > enum rvin_dma_state state; With the above clarified, for the whole series: Reviewed-by: Jacopo Mondi <jacopo+rene...@jmondi.org> Thanks j > > -- > 2.16.2 > signature.asc Description: PGP signature

[PATCH v2 0/4] Renesas CEU: SH7724 ECOVEC + Aptina mt9t112

that is expected v4l2 compliance tool to report errors. v1 -> v2: - Fix soc_camera driver build error - Add TODO note for missing frame rate control - Reduce patch count Jacopo Mondi (4): media: i2c: Copy mt9t112 soc_camera sensor driver media: i2c: mt9t112: Remove soc_camera dependencies a

[PATCH v2 4/4] media: MAINTAINERS: Add entry for Aptina MT9T112

Add entry for Aptina/Micron MT9T112 camera sensor. The driver is maintained by me for "Odd Fixes" only due to lack of suitable hardware for testing. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v2 3/4] arch: sh: ecovec: Use new renesas-ceu camera driver

and declare memory reserved with memblock APIs as dma capable to be used for CEU buffers. While at there re-order include directives to respect alphabetical ordering. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- arch/sh/boards/mach-ecovec24/setup.c

[PATCH v2 1/4] media: i2c: Copy mt9t112 soc_camera sensor driver

Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi <jacopo+r

[PATCH v2 2/4] media: i2c: mt9t112: Remove soc_camera dependencies

reported by checkpatch in strict mode This commit does not remove the original soc_camera based driver as long as other platforms depends on soc_camera framework. As I don't have access to a working camera module, this change has only been compile tested. Signed-off-by: Jacopo Mondi <jacopo+r

Re: [PATCH 0/5] Renesas CEU: SH7724 ECOVEC + Aptina mt9t112

Hi Hans, On Sat, Mar 10, 2018 at 06:57:17PM +0100, Hans Verkuil wrote: > Hi Jacopo, > > On 02/03/18 17:35, Jacopo Mondi wrote: > > Hello, > >now that CEU has been picked up for inclusion in v4.17, we can start > > moving > > users of old sh_mobile_c

[PATCH] media: soc_camera: mt9t112: Update to new interface

Use in the soc_camera version of mt9t112 driver the new name for the driver's platform data as defined by the new v4l2 driver for the same chip. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- Hans: to not break bisect, would you like me to resend the whole series with this

[PATCH] media: i2c: mt9t112: Add TODO note for frame rate control

The driver lacks support for frame rate control, and v4l2-compliance complains about that. Add a TODO note to warn driver users that this is expected. While at there, update copyright note to the year we're actually in. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers

Re: [PATCH v2 01/11] media: tw9910: Re-order variables declaration

Hi Mauro, On Tue, Mar 06, 2018 at 01:51:52PM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 2 Mar 2018 15:46:33 +0100 > Jacopo Mondi <jacopo+rene...@jmondi.org> escreveu: > > > Re-order variables declaration to respect 'reverse christmas tree' > > ordering whenever p

Re: [PATCH] media: ov772x: constify ov772x_frame_intervals

Hi Mauro, On Tue, Mar 06, 2018 at 10:35:22AM -0500, Mauro Carvalho Chehab wrote: > The values on this array never changes. Make it const. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Jacopo Mondi <jacopo+rene...@jmondi.org> Since I'm su

Re: [bug report] media: i2c: Copy tw9910 soc_camera sensor driver

Hi Dan, On Mon, Mar 05, 2018 at 10:21:09AM +0300, Dan Carpenter wrote: > On Fri, Mar 02, 2018 at 03:20:16PM +0100, jacopo mondi wrote: > > Hi Dan, > > > > On Thu, Mar 01, 2018 at 12:59:54PM +0300, Dan Carpenter wrote: > > > [ I know you're just copying f

[PATCH 0/5] Renesas CEU: SH7724 ECOVEC + Aptina mt9t112

with the new board file. I'm in favour of moving the driver to staging if you think that's the case. Series based on media-tree master, and as per Migo-R I would ask SH arch/ changes to go through media tree as SH maintainers are un-responsive. Thanks j Jacopo Mondi (5): media: i2c: Copy

[PATCH 4/5] arch: sh: ecovec: Use new renesas-ceu camera driver

and declare memory reserved with memblock APIs as dma capable to be used for CEU buffers. While at there re-order include directives to respect alphabetical ordering. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- arch/sh/boards/mach-ecovec24/setup.c

[PATCH 3/5] media: i2c: mt9t112: Fix code style issues

Fix code style issues reported by checkpatch run with --strict options. Also fix other non reported style issues manually. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/mt9t112.c | 256 1 file changed, 118 inse

[PATCH 2/5] media: i2c: mt9t112: Remove soc_camera dependencies

the original soc_camera based driver as long as other platforms depends on soc_camera framework. As I don't have access to a working camera module, this change has only been compile tested. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/Kconfig | 11 d

[PATCH 5/5] media: MAINTAINERS: Add entry for Aptina MT9T112

Add entry for Aptina/Micron MT9T112 camera sensor. The driver is currently orphaned. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 91ed6ad..1d8be25 100644 --- a/MAINTAINERS

[PATCH 1/5] media: i2c: Copy mt9t112 soc_camera sensor driver

Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi <jacopo+r

[PATCH v2 10/11] media: ov772x: Replace msleep(1) with usleep_range

msleep() can sleep up to 20ms. As suggested by Documentation/timers/timers_howto.txt replace it with usleep_range() with up to 5ms delay. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/ov772x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v2 08/11] media: ov772x: Empty line before end-of-function return

Add an empty line before return at the end of functions. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/ov772x.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c index 8849da1..4f464ac

[PATCH v2 07/11] media: ov772x: Re-organize in-code comments

A lot of comments that would fit a single line were spread on two or more lines. Also fix capitalization and punctuation where appropriate. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/ov772x.c | 32 ++-- 1 file changed, 10 inse

[PATCH v2 06/11] media: ov772x: Align function parameters

Align all function parameters to first open brace when declaring functions. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/ov772x.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov

[PATCH v2 04/11] media: tw9910: Sort includes alphabetically

Sort include directives alphabetically to ease maintenance. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/tw9910.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/tw9910.c b/drivers/media/i2c/tw9910.c index 0

[PATCH v2 05/11] media: tw9910: Replace msleep(1) with usleep_range

msleep() can sleep up to 20ms. As suggested by Documentation/timers/timers_howto.txt replace it with usleep_range() with up to 5ms delay. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/tw9910.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v2 11/11] media: ov772x: Unregister async subdevice

As the media subdevice is registered with 'v4l2_async_register_subdev()' unregister it at module removal time with 'v4l2_async_unregister_subdev()' Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/ov772x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2 09/11] media: ov772x: Re-order variables declaration

Re-order variables declaration to respect 'reverse christmas tree' ordering whenever possible. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/ov772x.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/ov77

[PATCH v2 03/11] media: tw9910: Mixed style fixes

Two minor style fixes, align function parameter and remove un-necessary spaces. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/tw9910.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/tw9910.c b/drivers/media/i2c/

[PATCH v2 01/11] media: tw9910: Re-order variables declaration

Re-order variables declaration to respect 'reverse christmas tree' ordering whenever possible. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/tw9910.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/drivers/med

[PATCH v2 02/11] media: tw9910: Re-organize in-code comments

A lot of comments that would fit a single line were spread on two or more lines. Also fix capitalization and punctuation where appropriate. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/tw9910.c | 44 +--- 1 file chang

[PATCH v2 00/11] media: ov772x/tw9910 cleanup

40 ("media: tw9910: Whitespace alignment") commit ae24b8a1d5f9 ("media: tw9910: solve coding style issues") commit 2d595d14fe8b ("media: ov772x: fix whitespace issues") Thanks j v1 -> v2: - Rebased on top of Joe's cleanup patches: 2 patches squashed - Add patch

Re: [bug report] media: i2c: Copy tw9910 soc_camera sensor driver

would instead keep them for sake of readability and accordance with register description in the video decoder manual. Thanks j > > Hello Jacopo Mondi, > > The patch e0d76c3842ee: "media: i2c: Copy tw9910 soc_camera sensor > driver" from Feb 21, 2018, leads to the fol

Re: [PATCH] media: tw9910: Whitespace alignment

Hi Joe, On Thu, Mar 01, 2018 at 03:50:22AM -0800, Joe Perches wrote: > Update multiline statements to open parenthesis. > Update a ?: to a single line. Thanks for the cleanup. You may want to rebase this on my series from a few days ago https://patchwork.linuxtv.org/patch/47475/ which includes

[PATCH] media: platform: renesas-ceu: Fix CSTRST_CPON mask

The CSTRST_CPON mask was wrongly assigned to BIT(1) instead of BIT(0). Fix that by changing the mask opportunely. Reported-by: Dylan Laduranty <dylan.ladura...@mesotic.com> Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- Mauro: could you please pick up this patch since

[PATCH 12/13] media: ov772x: Re-order variables declaration

Re-order variables declaration to respect 'reverse christmas tree' ordering whenever possible. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/ov772x.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/ov77

[PATCH 11/13] media: ov772x: Empty line before end-of-function return

Add an empty line before return at the end of functions. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/ov772x.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c index 8849da1..4f464ac

[PATCH 05/13] media: tw9910: Re-organize in-code comments

A lot of comments that would fit a single line were spread on two or more lines. Also fix capitalization and punctuation where appropriate. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/tw9910.c | 44 +--- 1 file chang

[PATCH 13/13] media: ov772x: Replace msleep(1) with usleep_range

msleep() can sleep up to 20ms. As suggested by Documentation/timers/timers_howto.txt replace it with usleep_range() with up to 5ms delay. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/ov772x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 06/13] media: tw9910: Mixed style fixes

Two minor style fixes, align function parameter and remove un-necessary spaces. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/tw9910.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/tw9910.c b/drivers/media/i2c/tw

[PATCH 02/13] media: tw9910: Empty line before end-of-function return

Add an empty line before return at the end of functions. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/tw9910.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/i2c/tw9910.c b/drivers/media/i2c/tw9910.c index 70e0ae2..3e4b530

[PATCH 04/13] media: tw9910: Re-order variables declaration

Re-order variables declaration to respect 'reverse christmas tree' ordering whenever possible. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/tw9910.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/drivers/med

[PATCH 01/13] media: tw9910: Fix parameter alignment issue

Align parameters to first open brace. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/tw9910.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/tw9910.c b/drivers/media/i2c/tw9910.c index cc5d383..70e0ae2

[PATCH 03/13] media: tw9910: Align function parameters

Align all function parameters to first open brace when declaring functions. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/tw9910.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/tw9910.c b/drivers/media/i2c/tw

[PATCH 08/13] media: tw9910: Replace msleep(1) with usleep_range

msleep() can sleep up to 20ms. As suggested by Documentation/timers/timers_howto.txt replace it with usleep_range() with up to 5ms delay. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/tw9910.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 09/13] media: ov772x: Align function parameters

Align all function parameters to first open brace when declaring functions. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/ov772x.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov

[PATCH 07/13] media: tw9910: Sort includes alphabetically

Sort include directives alphabetically to ease maintenance. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/tw9910.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/tw9910.c b/drivers/media/i2c/tw9910.c index f

[PATCH 10/13] media: ov772x: Re-organize in-code comments

A lot of comments that would fit a single line were spread on two or more lines. Also fix capitalization and punctuation where appropriate. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/ov772x.c | 32 ++-- 1 file changed, 10 inse

[PATCH 00/13] media: ov772x/tw9910 cleanup

ia: ov772x: fix whitespace issues") checkpatch now returns no error apart from a > 80 columns in ov772x I did not break for sake of readability. Thanks j Jacopo Mondi (13): media: tw9910: Fix parameter alignment issue media: tw9910: Empty line before end-of-function return media:

Re: [PATCH 2/2] media: tw9910: solve coding style issues

Hi Mauro, thanks for doing this. I didn't dare to touch this driver style issues as it was mainline already, but since you addressed this I now would have more changes to apply... On Mon, Feb 26, 2018 at 09:28:08AM -0500, Mauro Carvalho Chehab wrote: > As we're adding this as a new driver,

Re: [PATCH v9 11/11] media: i2c: ov7670: Fully set mbus frame fmt

Hi Laurent, On Thu, Feb 22, 2018 at 02:47:06PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > On Thursday, 22 February 2018 14:36:00 EET jacopo mondi wrote: > > On Thu, Feb 22, 2018 at 02:14:53PM +0200, Laurent Pinchart wrote: > > > On Thursday, 22 February 2018 14:04:1

<    1   2   3   4   5   6   >