Re: [RFC 1/1] v4l: async: Use endpoint node, not device node, for fwnode match

Hi Sakari, On Thu, Dec 14, 2017 at 12:53:42PM +0200, Sakari Ailus wrote: > Hi Jacopo, > > On Thu, Dec 07, 2017 at 03:29:40PM +0100, jacopo mondi wrote: > > Hi Sakari! > > thanks for proposing this > > > > While we all agree that full endpoint matching is th

[PATCH 5/5] v4l2: async: Add debug output to v4l2-async module

not that useful). Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- For fwnodes backed by OF, I may have used the "%pOF" format modifier to get the full node name instead of parsing the fwnode graph by myself with "v4l2_async_fwnode_full_name()". Unfortunate

[PATCH 3/5] include: v4l2_async: Add 'owner' field to notifier

purposes. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/v4l2-core/v4l2-async.c | 2 ++ include/media/v4l2-async.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c index a

[PATCH 4/5] v4l2: async: Postpone subdev_notifier registration

cannot be upscaled as long as the subdevice the notifiers belongs to is not registered. Also, it is now safe to access a notifier 'struct device *' as we're now sure it is properly initialized when the notifier is actually registered. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- d

[PATCH 0/5] Add debug output to v4l2-async

linux-media anyhow for feedbacks. Thanks j Jacopo Mondi (4): device property: Add fwnode_get_name() operation include: v4l2_async: Add 'owner' field to notifier v4l2: async: Postpone subdev_notifier registration v4l2: async: Add debug output to v4l2-async module Sakari Ailus (1

[PATCH 2/5] device property: Add fwnode_get_name() operation

Add operation to retrieve the device name from a fwnode handle. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/acpi/property.c | 6 ++ drivers/base/property.c | 12 drivers/of/property.c| 6 ++ include/linux/fwnode.h | 2 ++ include

[PATCH 1/5] v4l: async: Use endpoint node, not device node, for fwnode match

From: Sakari Ailus V4L2 async framework can use both device's fwnode and endpoints's fwnode for matching the async sub-device with the sub-device. In order to proceed moving towards endpoint matching assign the endpoint to the async sub-device. As most async

Re: [RFC 1/1] v4l: async: Use endpoint node, not device node, for fwnode match

Hi Sakari! thanks for proposing this While we all agree that full endpoint matching is the right thing to do (see also Kieran's last reply to his "v4l2-async: Match parent devices" patch) I have some perplexity on this proposal, please see below On Mon, Dec 04, 2017 at 11:03:02PM +0200,

Re: [PATCH v5] v4l2-async: Match parent devices

evices which store their default parent device > node. > > Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> please append: Reported-by: Jacopo Mondi <jacopo.mondi+rene...@jmondi.

[PATCH] v4l: rcar-csi2: Don't bail out from probe on no ep

When rcar-csi interface is not connected to any endpoint, it fails and bails out from probe before registering its own video subdevice. This prevents rcar-vin registered notifier from completing and no subdevice is ever registered, also for other properly connected csi interfaces. Fix this not

Re: [RFC] v4l: i2c: ov7670: Implement mbus configuration

Hi Sakari, thanks for the reply On Wed, Nov 29, 2017 at 01:06:49PM +0200, Sakari Ailus wrote: > On Wed, Nov 29, 2017 at 01:04:30PM +0200, Sakari Ailus wrote: > > Hi Jacopo, > > > > On Mon, Nov 27, 2017 at 11:26:53AM +0100, Jacopo Mondi wrote: > > > ov7670 cu

Re: [PATCH 0/4] fix some checkpatch style issues in atomisp driver

Hello Riccardo, On Wed, Nov 29, 2017 at 10:31:17AM +0100, Riccardo S. wrote: > Hi Jacopo, > > for some reason your comment about "[PATCH 3/4] staging: improves > comparisons readability in atomisp-ov5693" did not reach my inbox. > > Unfortunately I already sent PATCHv2 and it has been accepted. >

Re: [PATCH 1/4] staging: add missing blank line after declarations in atomisp-ov5693

Hi Riccardo, On Mon, Nov 27, 2017 at 10:44:10PM +0100, Riccardo Schirone wrote: > Signed-off-by: Riccardo Schirone No patch can be accepted without a commit message. I know subject is self-explanatory here, but please add some lines eg. reporting checkpatch warnings. Thanks

Re: [PATCH 3/4] staging: improves comparisons readability in atomisp-ov5693

Hi Riccardo, thanks for the patch On Mon, Nov 27, 2017 at 10:44:12PM +0100, Riccardo Schirone wrote: > Fix "Comparisons should place the constant on the right side of the > test" issue. > > Signed-off-by: Riccardo Schirone > --- >

[RFC] v4l: i2c: ov7670: Implement mbus configuration

ov7670 currently supports configuration of a few parameters only through platform data. Implement media bus configuration by parsing DT properties at probe() time and opportunely configure REG_COM10 during s_format(). Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- Hi linux

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

Hi Sakari! On Sat, Nov 25, 2017 at 05:56:14PM +0200, Sakari Ailus wrote: > On Fri, Nov 17, 2017 at 10:33:55AM +0100, jacopo mondi wrote: > > Hi Sakari! > > [snip] > > I would like to make sure we're all on the same page with this. My > > preference would be: > >

Re: [PATCH] media: cx231xx: add support for TheImagingSource DFG/USB2pro

Hi Romain, On Fri, Nov 17, 2017 at 04:38:55PM +0100, Romain Reignier wrote: > Hello, > > This is my first patch to the kernel so please be indulgent if I have done > anything wrong and help me produce a better submission. With this formatting (email text + patch below) applying with 'git am'

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

Hi Sakari! On Fri, Nov 17, 2017 at 02:36:51AM +0200, Sakari Ailus wrote: > Hi Jacopo, > > On Wed, Nov 15, 2017 at 03:25:11PM +0100, jacopo mondi wrote: > > Hi Sakari, > >thanks for review! > > You're welcome! > > > On Wed, Nov 15, 2017 at 02:45:51PM +0200,

Re: [PATCH v1 06/10] sh: sh7722: Rename CEU clock

Hi Geert, On Wed, Nov 15, 2017 at 02:13:43PM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Wed, Nov 15, 2017 at 11:55 AM, Jacopo Mondi > <jacopo+rene...@jmondi.org> wrote: > > Rename CEU clock to match the new platform driver name used in Migo-R. > > >

Re: [PATCH v1 08/10] media: i2c: ov772x: Remove soc_camera dependencies

Hi Sakari! On Fri, Nov 17, 2017 at 02:43:15AM +0200, Sakari Ailus wrote: > Hi Jacopo, > > On Wed, Nov 15, 2017 at 11:56:01AM +0100, Jacopo Mondi wrote: > > [snip] > > +#include > > #include > > #include > > #include > > @@ -25,8 +26,8 @@ &g

Re: [PATCH v1 01/10] dt-bindings: media: Add Renesas CEU bindings

Hi Geert, On Wed, Nov 15, 2017 at 02:07:31PM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > CC devicetree folks Yeah, sorry I forgot them. Sorry about this and thanks for adding the address back! > > On Wed, Nov 15, 2017 at 11:55 AM, Jacopo Mondi > <jacopo+rene...@jmond

[PATCH] v4l: sh_mobile_ceu: Return buffers on streamoff()

videobuf2 core reports an error when not all buffers have been returned to the framework: drivers/media/v4l2-core/videobuf2-core.c:1651 WARN_ON(atomic_read(>owned_by_drv_count)) Fix this returning all buffers currently in capture queue. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmon

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

utines apart, there's not that much code shared between the two... > > The same goes for the two V4L2 SoC camera sensor / video decoder drivers at > the end of the set. > Also in this case I prefer not to remove existing code, as long as there are platforms using it.. > On Wed, Nov 15, 2017 at

[PATCH v1 10/10] media: i2c: tw9910: Remove soc_camera dependencies

Remove soc_camera framework dependencies from tw9910 sensor driver. - Handle clock directly - Register async subdevice - Add platform specific enable/disable functions - Adjust build system This commit does not remove the original soc_camera based driver. Signed-off-by: Jacopo Mondi <jacopo+r

[PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

. Tested with ov7725 camera sensor on SH4 platform Migo-R. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/Kconfig |9 + drivers/media/platform/Makefile |2 + drivers/media/platform/renesas-ceu.c | 1768 ++ 3

[PATCH v1 01/10] dt-bindings: media: Add Renesas CEU bindings

Add bindings documentation for Renesas Capture Engine Unit (CEU). Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- .../devicetree/bindings/media/renesas,ceu.txt | 87 ++ 1 file changed, 87 insertions(+) create mode 100644 Documentation/devicetree/bi

[PATCH v1 02/10] include: media: Add Renesas CEU driver interface

Add renesas-ceu header file. Do not remove the existing sh_mobile_ceu.h one as long as the original driver does not go away. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- include/media/drv-intf/renesas-ceu.h | 23 +++ 1 file changed, 23 insertions(+)

[PATCH v1 05/10] arch: sh: migor: Use new renesas-ceu camera driver

for CEU video buffers is now reserved with membocks APIs, and need to be declared as dma_coherent during machine initialization to remove that architecture specific part from CEU driver. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- arch/sh/boards/mach-migor/setup.c

[PATCH v1 08/10] media: i2c: ov772x: Remove soc_camera dependencies

Remove soc_camera framework dependencies from ov772x sensor driver. - Handle clock directly - Register async subdevice - Add platform specific enable/disable functions - Adjust build system This commit does not remove the original soc_camera based driver. Signed-off-by: Jacopo Mondi <jacopo+r

[PATCH v1 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

Add Capture Engine Unit (CEU) node to device tree. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- arch/arm/boot/dts/r7s72100.dtsi | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi

[PATCH v1 07/10] v4l: i2c: Copy ov772x soc_camera sensor driver

Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/ov772x.c | 1124 1 file changed

[PATCH v1 00/10] Renesas Capture Engine Unit (CEU) V4L2 driver

. Thanks j Jacopo Mondi (10): dt-bindings: media: Add Renesas CEU bindings include: media: Add Renesas CEU driver interface v4l: platform: Add Renesas CEU driver ARM: dts: r7s72100: Add Capture Engine Unit (CEU) arch: sh: migor: Use new renesas-ceu camera driver sh: sh7722: Rename CEU

[PATCH v1 09/10] v4l: i2c: Copy tw9910 soc_camera sensor driver

Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/tw9910.c | 999 + 1 file change

[PATCH v1 06/10] sh: sh7722: Rename CEU clock

Rename CEU clock to match the new platform driver name used in Migo-R. There are no other sh7722 based devices Migo-R apart, so we can safely rename this. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- arch/sh/kernel/cpu/sh4a/clock-sh7722.c | 2 +- 1 file changed, 1 insertion

[PATCH v3] media: i2c: ov772x: Force use of SCCB protocol

25 Product ID 77:21 Manufacturer ID 7f:a2 Signed-off-by: Jacopo Mondi <jac...@jmondi.org> Suggested-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Acked-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com&

[PATCH v2] media: i2c: ov772x: Force use of SCCB protocol

l messages. Tested on SH4 Migo-R board, with OV772x now successfully probing soc-camera-pdrv soc-camera-pdrv.0: Probing soc-camera-pdrv.0 ov772x 0-0021: ov7725 Product ID 77:21 Manufacturer ID 7f:a2 Signed-off-by: Jacopo Mondi <jac...@jmondi.org> Suggested-by: Laurent Pinchar

[PATCH] media: i2c: ov772x: Force use of SCCB protocol

lied: soc-camera-pdrv soc-camera-pdrv.0: Probing soc-camera-pdrv.0 ov772x 0-0021: ov7725 Product ID 77:21 Manufacturer ID 7f:a2 Signed-off-by: Jacopo Mondi <jac...@jmondi.org> --- drivers/media/i2c/soc_camera/ov772x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/soc_ca

<    1   2   3   4   5   6