Re: [PATCH/RFC v4 15/21] media: Add registration helpers for V4L2 flash

Hi Sakari, On 08/20/2014 04:41 PM, Sakari Ailus wrote: Hi Jacek, [...] LED Class Flash driver gains V4L2 Flash API when CONFIG_V4L2_FLASH_LED_CLASS is defined. This is accomplished in the probe function by either calling v4l2_flash_init function or the macro of this name, when the

Re: [PATCH/RFC v4 15/21] media: Add registration helpers for V4L2 flash

Hi Jacek, On Thu, Aug 14, 2014 at 10:25:28AM +0200, Jacek Anaszewski wrote: On 08/14/2014 06:34 AM, Sakari Ailus wrote: Hi Jacek, On Mon, Aug 11, 2014 at 03:27:22PM +0200, Jacek Anaszewski wrote: ... diff --git a/include/media/v4l2-flash.h b/include/media/v4l2-flash.h new file mode

Re: [PATCH/RFC v4 15/21] media: Add registration helpers for V4L2 flash

On 08/14/2014 06:34 AM, Sakari Ailus wrote: Hi Jacek, On Mon, Aug 11, 2014 at 03:27:22PM +0200, Jacek Anaszewski wrote: ... diff --git a/include/media/v4l2-flash.h b/include/media/v4l2-flash.h new file mode 100644 index 000..effa46b --- /dev/null +++ b/include/media/v4l2-flash.h @@ -0,0

Re: [PATCH/RFC v4 15/21] media: Add registration helpers for V4L2 flash

Hi Jacek, On Mon, Aug 11, 2014 at 03:27:22PM +0200, Jacek Anaszewski wrote: ... diff --git a/include/media/v4l2-flash.h b/include/media/v4l2-flash.h new file mode 100644 index 000..effa46b --- /dev/null +++ b/include/media/v4l2-flash.h @@ -0,0 +1,137 @@ +/* + * V4L2 Flash LED

Re: [PATCH/RFC v4 15/21] media: Add registration helpers for V4L2 flash

Hi Jacek, On Mon, Aug 04, 2014 at 04:43:54PM +0200, Jacek Anaszewski wrote: Hi Sakari, Thanks for the review. You're welcome! :) On 07/21/2014 01:12 PM, Sakari Ailus wrote: Hi Jacek, Jacek Anaszewski wrote: This patch adds helper functions for registering/unregistering LED class

Re: [PATCH/RFC v4 15/21] media: Add registration helpers for V4L2 flash

Hi Sakari On 08/11/2014 02:26 PM, Sakari Ailus wrote: Hi Jacek, On Mon, Aug 04, 2014 at 04:43:54PM +0200, Jacek Anaszewski wrote: Hi Sakari, Thanks for the review. You're welcome! :) On 07/21/2014 01:12 PM, Sakari Ailus wrote: Hi Jacek, Jacek Anaszewski wrote: This patch adds helper

Re: [PATCH/RFC v4 15/21] media: Add registration helpers for V4L2 flash

On 08/11/2014 02:26 PM, Sakari Ailus wrote: Hi Jacek, ... +static int v4l2_flash_s_ctrl(struct v4l2_ctrl *c) +{ +struct v4l2_flash *v4l2_flash = v4l2_ctrl_to_v4l2_flash(c); +struct led_classdev_flash *flash = v4l2_flash-flash; +struct v4l2_flash_ctrl *ctrl = v4l2_flash-ctrl; +

Re: [PATCH/RFC v4 15/21] media: Add registration helpers for V4L2 flash

Hi Sakari, Thanks for the review. On 07/21/2014 01:12 PM, Sakari Ailus wrote: Hi Jacek, Jacek Anaszewski wrote: This patch adds helper functions for registering/unregistering LED class flash devices as V4L2 subdevs. The functions should be called from the LED subsystem device driver. In case

Re: [PATCH/RFC v4 15/21] media: Add registration helpers for V4L2 flash

Hi Jacek, Jacek Anaszewski wrote: This patch adds helper functions for registering/unregistering LED class flash devices as V4L2 subdevs. The functions should be called from the LED subsystem device driver. In case the support for V4L2 Flash sub-devices is disabled in the kernel config the

[PATCH/RFC v4 15/21] media: Add registration helpers for V4L2 flash

This patch adds helper functions for registering/unregistering LED class flash devices as V4L2 subdevs. The functions should be called from the LED subsystem device driver. In case the support for V4L2 Flash sub-devices is disabled in the kernel config the functions' empty versions will be used.