Re: [PATCH] [media] videobuf2-core: call __setup_offsets only for mmap memory type

2013-09-30 Thread Hans Verkuil
On 09/19/2013 09:37 AM, Philipp Zabel wrote: __setup_offsets fills the v4l2_planes' mem_offset fields, which is only valid for V4L2_MEMORY_MMAP type buffers. For V4L2_MEMORY_DMABUF and _USERPTR buffers, this incorrectly overwrites the fd and userptr fields. Reported-by: Michael Olbrich

Re: [PATCH] [media] videobuf2-core: call __setup_offsets only for mmap memory type

2013-09-29 Thread Pawel Osciak
Thanks Philipp. Acked-by: Pawel Osciak pa...@osciak.com On Thu, Sep 19, 2013 at 5:30 PM, Philipp Zabel p.za...@pengutronix.de wrote: Hi Pawel, Am Donnerstag, den 19.09.2013, 16:54 +0900 schrieb Pawel Osciak: On Thu, Sep 19, 2013 at 4:37 PM, Philipp Zabel p.za...@pengutronix.de wrote:

[PATCH] [media] videobuf2-core: call __setup_offsets only for mmap memory type

2013-09-19 Thread Philipp Zabel
__setup_offsets fills the v4l2_planes' mem_offset fields, which is only valid for V4L2_MEMORY_MMAP type buffers. For V4L2_MEMORY_DMABUF and _USERPTR buffers, this incorrectly overwrites the fd and userptr fields. Reported-by: Michael Olbrich m.olbr...@pengutronix.de Signed-off-by: Philipp Zabel

Re: [PATCH] [media] videobuf2-core: call __setup_offsets only for mmap memory type

2013-09-19 Thread Pawel Osciak
On Thu, Sep 19, 2013 at 4:37 PM, Philipp Zabel p.za...@pengutronix.de wrote: __setup_offsets fills the v4l2_planes' mem_offset fields, which is only valid for V4L2_MEMORY_MMAP type buffers. For V4L2_MEMORY_DMABUF and _USERPTR buffers, this incorrectly overwrites the fd and userptr fields.

Re: [PATCH] [media] videobuf2-core: call __setup_offsets only for mmap memory type

2013-09-19 Thread Marek Szyprowski
Hello, On 9/19/2013 9:37 AM, Philipp Zabel wrote: __setup_offsets fills the v4l2_planes' mem_offset fields, which is only valid for V4L2_MEMORY_MMAP type buffers. For V4L2_MEMORY_DMABUF and _USERPTR buffers, this incorrectly overwrites the fd and userptr fields. Reported-by: Michael Olbrich

Re: [PATCH] [media] videobuf2-core: call __setup_offsets only for mmap memory type

2013-09-19 Thread Philipp Zabel
Hi Pawel, Am Donnerstag, den 19.09.2013, 16:54 +0900 schrieb Pawel Osciak: On Thu, Sep 19, 2013 at 4:37 PM, Philipp Zabel p.za...@pengutronix.de wrote: __setup_offsets fills the v4l2_planes' mem_offset fields, which is only valid for V4L2_MEMORY_MMAP type buffers. For V4L2_MEMORY_DMABUF