Re: [PATCH] add raw video support for Samsung SUR40 touchscreen

2015-02-04 Thread Hans Verkuil
Hi Florian, On 02/03/2015 09:45 PM, Florian Echtler wrote: Sorry to bring this up again, but would it be acceptable to simply use dma-contig after all? Since the GFP_DMA flag is gone, this shouldn't be too big of an issue IMHO, and I was kind of hoping the patch could still be part of 3.20.

Re: [PATCH] add raw video support for Samsung SUR40 touchscreen

2015-02-04 Thread Florian Echtler
On 04.02.2015 11:22, Hans Verkuil wrote: On 02/04/15 11:08, Florian Echtler wrote: On 04.02.2015 09:08, Hans Verkuil wrote: You can also make a version with vmalloc and I'll merge that, and then you can look more into the DMA issues. That way the driver is merged, even if it is perhaps not

Re: [PATCH] add raw video support for Samsung SUR40 touchscreen

2015-02-04 Thread Laurent Pinchart
Hi Florian, On Wednesday 04 February 2015 11:56:58 Florian Echtler wrote: On 04.02.2015 11:22, Hans Verkuil wrote: On 02/04/15 11:08, Florian Echtler wrote: On 04.02.2015 09:08, Hans Verkuil wrote: You can also make a version with vmalloc and I'll merge that, and then you can look more

Re: [PATCH] add raw video support for Samsung SUR40 touchscreen

2015-02-04 Thread Florian Echtler
Hello everyone, On 04.02.2015 12:39, Hans Verkuil wrote: On 02/04/15 12:34, Laurent Pinchart wrote: On Wednesday 04 February 2015 11:56:58 Florian Echtler wrote: That's what I assumed, however, I'm running into the same problem as with dma-sg when I switch to vmalloc...? I don't expect

Re: [PATCH] add raw video support for Samsung SUR40 touchscreen

2015-02-04 Thread Laurent Pinchart
Hi Hans, On Wednesday 04 February 2015 12:39:30 Hans Verkuil wrote: On 02/04/15 12:34, Laurent Pinchart wrote: On Wednesday 04 February 2015 11:56:58 Florian Echtler wrote: On 04.02.2015 11:22, Hans Verkuil wrote: On 02/04/15 11:08, Florian Echtler wrote: On 04.02.2015 09:08, Hans

Re: [PATCH] add raw video support for Samsung SUR40 touchscreen

2015-02-04 Thread Laurent Pinchart
Hi Florian, On Wednesday 04 February 2015 14:21:47 Florian Echtler wrote: On 04.02.2015 12:39, Hans Verkuil wrote: On 02/04/15 12:34, Laurent Pinchart wrote: On Wednesday 04 February 2015 11:56:58 Florian Echtler wrote: That's what I assumed, however, I'm running into the same problem as

Re: [PATCH] add raw video support for Samsung SUR40 touchscreen

2015-02-04 Thread Hans Verkuil
On 02/04/15 12:34, Laurent Pinchart wrote: Hi Florian, On Wednesday 04 February 2015 11:56:58 Florian Echtler wrote: On 04.02.2015 11:22, Hans Verkuil wrote: On 02/04/15 11:08, Florian Echtler wrote: On 04.02.2015 09:08, Hans Verkuil wrote: You can also make a version with vmalloc and I'll

Re: [PATCH] add raw video support for Samsung SUR40 touchscreen

2015-02-04 Thread Florian Echtler
Hello Hans, On 04.02.2015 09:08, Hans Verkuil wrote: I remain very skeptical about the use of dma-contig (or dma-sg for that matter). Have you tried using vmalloc and check if the USB core isn't automatically using DMA transfers for that? Basically I would like to see proof that vmalloc is

Re: [PATCH] add raw video support for Samsung SUR40 touchscreen

2015-02-04 Thread Hans Verkuil
On 02/04/15 11:08, Florian Echtler wrote: Hello Hans, On 04.02.2015 09:08, Hans Verkuil wrote: I remain very skeptical about the use of dma-contig (or dma-sg for that matter). Have you tried using vmalloc and check if the USB core isn't automatically using DMA transfers for that?

Re: [PATCH] add raw video support for Samsung SUR40 touchscreen

2015-02-03 Thread Florian Echtler
Sorry to bring this up again, but would it be acceptable to simply use dma-contig after all? Since the GFP_DMA flag is gone, this shouldn't be too big of an issue IMHO, and I was kind of hoping the patch could still be part of 3.20. Best, Florian On 29.01.2015 22:35, Florian Echtler wrote: I'm

Re: [PATCH] add raw video support for Samsung SUR40 touchscreen

2015-01-29 Thread Florian Echtler
Hello again, On 21.01.2015 14:29, Hans Verkuil wrote: On 01/21/15 14:28, Florian Echtler wrote: On 20.01.2015 14:06, Laurent Pinchart wrote: That depends on the platform and whether it can DMA to vmalloc'ed memory :-) To be totally safe I think vb2-dma-sg would be better, but I'm not sure

Re: [PATCH] add raw video support for Samsung SUR40 touchscreen

2015-01-21 Thread Florian Echtler
Hello everyone, On 20.01.2015 14:06, Laurent Pinchart wrote: On Tuesday 20 January 2015 14:03:00 Hans Verkuil wrote: On 01/20/15 13:59, Laurent Pinchart wrote: On Tuesday 20 January 2015 10:30:07 Hans Verkuil wrote: I've CC-ed Laurent, I think he knows a lot more about this than I do.

Re: [PATCH] add raw video support for Samsung SUR40 touchscreen

2015-01-21 Thread Hans Verkuil
On 01/21/15 14:28, Florian Echtler wrote: Hello everyone, On 20.01.2015 14:06, Laurent Pinchart wrote: On Tuesday 20 January 2015 14:03:00 Hans Verkuil wrote: On 01/20/15 13:59, Laurent Pinchart wrote: On Tuesday 20 January 2015 10:30:07 Hans Verkuil wrote: I've CC-ed Laurent, I think he

Re: [PATCH] add raw video support for Samsung SUR40 touchscreen

2015-01-20 Thread Florian Echtler
Hello Hans, On 19.01.2015 11:38, Hans Verkuil wrote: Sorry for the delay. No problem, thanks for your feedback. Note: I'm intentionally using dma-contig instead of vmalloc, as the USB core apparently _will_ try to use DMA for larger bulk transfers. As far as I can tell from looking through

Re: [PATCH] add raw video support for Samsung SUR40 touchscreen

2015-01-20 Thread Hans Verkuil
On 01/20/15 10:24, Florian Echtler wrote: Hello Hans, On 19.01.2015 11:38, Hans Verkuil wrote: Sorry for the delay. No problem, thanks for your feedback. Note: I'm intentionally using dma-contig instead of vmalloc, as the USB core apparently _will_ try to use DMA for larger bulk

Re: [PATCH] add raw video support for Samsung SUR40 touchscreen

2015-01-20 Thread Laurent Pinchart
Hello, On Tuesday 20 January 2015 10:30:07 Hans Verkuil wrote: On 01/20/15 10:24, Florian Echtler wrote: On 19.01.2015 11:38, Hans Verkuil wrote: Sorry for the delay. No problem, thanks for your feedback. Note: I'm intentionally using dma-contig instead of vmalloc, as the USB

Re: [PATCH] add raw video support for Samsung SUR40 touchscreen

2015-01-20 Thread Hans Verkuil
On 01/20/15 13:59, Laurent Pinchart wrote: Hello, On Tuesday 20 January 2015 10:30:07 Hans Verkuil wrote: On 01/20/15 10:24, Florian Echtler wrote: On 19.01.2015 11:38, Hans Verkuil wrote: Sorry for the delay. No problem, thanks for your feedback. Note: I'm intentionally using

Re: [PATCH] add raw video support for Samsung SUR40 touchscreen

2015-01-20 Thread Laurent Pinchart
Hi Hans, On Tuesday 20 January 2015 14:03:00 Hans Verkuil wrote: On 01/20/15 13:59, Laurent Pinchart wrote: On Tuesday 20 January 2015 10:30:07 Hans Verkuil wrote: On 01/20/15 10:24, Florian Echtler wrote: On 19.01.2015 11:38, Hans Verkuil wrote: Sorry for the delay. No problem,

Re: [PATCH] add raw video support for Samsung SUR40 touchscreen

2015-01-19 Thread Hans Verkuil
Hi Florian, Sorry for the delay. Several comments below... On 01/07/2015 11:35 AM, Florian Echtler wrote: This patch add support for the raw video stream from the Samsung SUR40 touchscreen device. Existing input device support is not affected by this patch and can be used concurrently.

[PATCH] add raw video support for Samsung SUR40 touchscreen

2015-01-07 Thread Florian Echtler
This patch add support for the raw video stream from the Samsung SUR40 touchscreen device. Existing input device support is not affected by this patch and can be used concurrently. videobuf2-dma-contig is used for buffer management. All tests from current v4l2-compliance -s run pass (see