Re: [PATCH] media: staging: atomisp: fix a potential missing-check bug

2018-05-08 Thread Sakari Ailus
On Tue, May 08, 2018 at 08:04:54AM -0500, Wenwen Wang wrote: > On Tue, May 8, 2018 at 7:16 AM, Dan Carpenter > wrote: > > On Wed, May 02, 2018 at 05:38:49PM -0500, Wenwen Wang wrote: > >> At the end of atomisp_subdev_set_selection(), the function > >>

Re: [PATCH] media: staging: atomisp: fix a potential missing-check bug

2018-05-08 Thread Wenwen Wang
On Tue, May 8, 2018 at 7:16 AM, Dan Carpenter wrote: > On Wed, May 02, 2018 at 05:38:49PM -0500, Wenwen Wang wrote: >> At the end of atomisp_subdev_set_selection(), the function >> atomisp_subdev_get_rect() is invoked to get the pointer to v4l2_rect. Since >> this

Re: [PATCH] media: staging: atomisp: fix a potential missing-check bug

2018-05-08 Thread Dan Carpenter
On Wed, May 02, 2018 at 05:38:49PM -0500, Wenwen Wang wrote: > At the end of atomisp_subdev_set_selection(), the function > atomisp_subdev_get_rect() is invoked to get the pointer to v4l2_rect. Since > this function may return a NULL pointer, it is firstly invoked to check > the returned pointer.

Re: [PATCH] media: staging: atomisp: fix a potential missing-check bug

2018-05-04 Thread Andy Shevchenko
On Fri, 2018-05-04 at 02:29 -0500, Wenwen Wang wrote: > At the end of atomisp_subdev_set_selection(), the function > atomisp_subdev_get_rect() is invoked to get the pointer to v4l2_rect. > Since > this function may return a NULL pointer, it is firstly invoked to > check > the returned pointer. If

[PATCH] media: staging: atomisp: fix a potential missing-check bug

2018-05-04 Thread Wenwen Wang
At the end of atomisp_subdev_set_selection(), the function atomisp_subdev_get_rect() is invoked to get the pointer to v4l2_rect. Since this function may return a NULL pointer, it is firstly invoked to check the returned pointer. If the returned pointer is not NULL, then the function is invoked

[PATCH] media: staging: atomisp: fix a potential missing-check bug

2018-05-02 Thread Wenwen Wang
At the end of atomisp_subdev_set_selection(), the function atomisp_subdev_get_rect() is invoked to get the pointer to v4l2_rect. Since this function may return a NULL pointer, it is firstly invoked to check the returned pointer. If the returned pointer is not NULL, then the function is invoked

[PATCH] media: staging: atomisp: fix a potential missing-check bug

2018-04-28 Thread Wenwen Wang
At the end of atomisp_subdev_set_selection(), the function atomisp_subdev_get_rect() is invoked to get the pointer to v4l2_rect. Since this function may return a NULL pointer, it is firstly invoked to check the returned pointer. If the returned pointer is not NULL, then the function is invoked