Re: [PATCH] media: vimc: cleanup a few warnings

2017-07-14 Thread Javier Martinez Canillas
On Thu, Jul 13, 2017 at 5:47 PM, Javier Martinez Canillas wrote: > On Thu, Jul 13, 2017 at 5:38 PM, Sakari Ailus wrote: [snip] >> >> Shouldn't these be set to the corresponding driver structs' id_table >> fields? Or do I miss something...? >> > >

Re: [PATCH] media: vimc: cleanup a few warnings

2017-07-13 Thread Javier Martinez Canillas
On Thu, Jul 13, 2017 at 5:38 PM, Sakari Ailus wrote: [snip] >> >> -static const struct platform_device_id vimc_sen_driver_ids[] = { >> +static const __maybe_unused >> +struct platform_device_id vimc_sen_driver_ids[] = { >> { >> .name =

Re: [PATCH] media: vimc: cleanup a few warnings

2017-07-13 Thread Sakari Ailus
Hi Mauro, On Wed, Jul 12, 2017 at 08:46:30AM -0300, Mauro Carvalho Chehab wrote: > The const structs uded by MODULE_DEVICE_TABLE() > may never be used with COMPILE_TEST: > > drivers/media/platform/vimc/vimc-capture.c:528:40: warning: > 'vimc_cap_driver_ids' defined but not used

[PATCH] media: vimc: cleanup a few warnings

2017-07-12 Thread Mauro Carvalho Chehab
The const structs uded by MODULE_DEVICE_TABLE() may never be used with COMPILE_TEST: drivers/media/platform/vimc/vimc-capture.c:528:40: warning: 'vimc_cap_driver_ids' defined but not used [-Wunused-const-variable=] static const struct platform_device_id vimc_cap_driver_ids[] = {