Re: [PATCH] stagin: atomisp: Fix oops by unbalanced clk enable/disable call

2017-10-17 Thread Sakari Ailus
On Tue, Oct 17, 2017 at 08:10:15AM +1100, Tobin C. Harding wrote: > On Mon, Oct 16, 2017 at 02:34:48PM +0200, Hans de Goede wrote: > > diff --git > > a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c > >

Re: [PATCH] stagin: atomisp: Fix oops by unbalanced clk enable/disable call

2017-10-16 Thread Tobin C. Harding
On Mon, Oct 16, 2017 at 02:34:48PM +0200, Hans de Goede wrote: > The common-clk core expects clk consumers to always call enable/disable > in a balanced manner. The atomisp driver does not call gmin_flisclk_ctrl() > in a balanced manner, so add a clock_on bool and skip redundant calls. > > This

[PATCH] stagin: atomisp: Fix oops by unbalanced clk enable/disable call

2017-10-16 Thread Hans de Goede
The common-clk core expects clk consumers to always call enable/disable in a balanced manner. The atomisp driver does not call gmin_flisclk_ctrl() in a balanced manner, so add a clock_on bool and skip redundant calls. This fixes kernel oops like this one: [ 19.811613] gc0310_s_config S [