[PATCH] videobuf2-core: modify the num of users

2014-08-14 Thread panpan liu
If num_users returns 1 or more than 1, that means we are not the only user of the plane's memory. Signed-off-by: panpan liu panpan1@samsung.com --- drivers/media/v4l2-core/videobuf2-core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] videobuf2-core: modify the num of users

2014-08-14 Thread Pawel Osciak
On Thu, Aug 14, 2014 at 4:11 PM, panpan liu panpan1@samsung.com wrote: If num_users returns 1 or more than 1, that means we are not the only user of the plane's memory. Signed-off-by: panpan liu panpan1@samsung.com NACK. Please read the function documentation and how it is used. If

Re: [PATCH] videobuf2-core: modify the num of users

2014-08-14 Thread Hans Verkuil
Hi, I've got a few questions: On 08/14/2014 09:11 AM, panpan liu wrote: If num_users returns 1 or more than 1, that means we are not the only user of the plane's memory. Why do think this is wrong? When the buffer is allocated the refcount is set to 1, so anyone mapping that buffer will