Hi Albert
A general question first: is the MIPI CSI-2 implementation common to all
ccic variants or specific to your SoC?
On Fri, 23 Nov 2012, Albert Wang wrote:
From: Libin Yang lby...@marvell.com
This patch adds the MIPI support for marvell-ccic.
Board driver should determine whether
02/15] [media] marvell-ccic: add MIPI support for
marvell-ccic driver
Hi Albert
A general question first: is the MIPI CSI-2 implementation common to all ccic
variants or
specific to your SoC?
I think it's for all marvell ccic.
On Fri, 23 Nov 2012, Albert Wang wrote:
From: Libin Yang lby
Hello Guennadi,
Please see my comments below.
Best Regards,
Libin
-Original Message-
From: Albert Wang
Sent: Tuesday, November 27, 2012 7:21 PM
To: Guennadi Liakhovetski
Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
Subject: RE: [PATCH 02/15] [media] marvell-ccic: add
Subject: RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for
marvell-ccic driver
Hi, Guennadi
We will update the patch by following your good suggestion! :)
[snip]
+ pll1 = clk_get(dev, pll1);
+ if (IS_ERR(pll1)) {
+ dev_err(dev, Could not get pll1 clock\n
Yang
Subject: RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for
marvell-ccic
driver
Hi, Guennadi
We will update the patch by following your good suggestion! :)
[snip]
+pll1 = clk_get(dev, pll1);
+if (IS_ERR(pll1)) {
+dev_err(dev, Could
Liakhovetski
Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
Subject: RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for
marvell-ccic
driver
Hi, Guennadi
We will update the patch by following your good suggestion! :)
[snip]
+ pll1 = clk_get(dev, pll1
Hi Guennadi,
[snip]
[Libin] Yes, you are right. We should consider the driver may be reused.
I didn't realize it. Another question is: If we use devm_clk_get(), what
I understand, the clk will be put when the device is being released. It
means the driver will hold the clk all the time the
From: Libin Yang lby...@marvell.com
This patch adds the MIPI support for marvell-ccic.
Board driver should determine whether using MIPI or not.
Signed-off-by: Albert Wang twan...@marvell.com
Signed-off-by: Libin Yang lby...@marvell.com
---
drivers/media/platform/marvell-ccic/mcam-core.c | 60
