Re: [PATCH 1/1] gspca: Add sn9c20x subdriver

2009-07-15 Thread Hans de Goede
Hi, First of all many many thanks for doings this! There are 4 issues with this driver, 2 of which are blockers: 1) The big one is the use of a custom debugging mechanism, please use the v4l standard debugging mechanism which is activated by the kernel config option VIDEO_ADV_DEBUG,

Re: [PATCH 1/1] gspca: Add sn9c20x subdriver

2009-07-15 Thread Brian Johnson
Hans, Thanks for the feedback, I'll work on the changes and hopefully post the revised patch this weekend. Hi, First of all many many thanks for doings this! There are 4 issues with this driver, 2 of which are blockers: 1) The big one is the use of a custom debugging mechanism,

Re: [PATCH 1/1] gspca: Add sn9c20x subdriver

2009-07-06 Thread Alexey Klimov
Hello Brian, please see below On Mon, Jul 6, 2009 at 3:30 PM, Brian Johnsonbrij...@gmail.com wrote: This adds support for webcams using the sn9c201 and sn9c202 bridges. Signed-off-by: Brian Johnson brij...@gmail.com ---  MAINTAINERS                                        |    8 +