From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Tue, 26 Sep 2017 15:12:47 +0200

Add a jump target so that a bit of exception handling can be better reused
at the end of this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
---
 drivers/media/dvb-core/dmxdev.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/media/dvb-core/dmxdev.c b/drivers/media/dvb-core/dmxdev.c
index 45e91add73ba..f8bf7459d5ca 100644
--- a/drivers/media/dvb-core/dmxdev.c
+++ b/drivers/media/dvb-core/dmxdev.c
@@ -594,18 +594,18 @@ static int dvb_dmxdev_start_feed(struct dmxdev *dmxdev,
        tsfeed->priv = filter;
 
        ret = tsfeed->set(tsfeed, feed->pid, ts_type, ts_pes, timeout);
-       if (ret < 0) {
-               dmxdev->demux->release_ts_feed(dmxdev->demux, tsfeed);
-               return ret;
-       }
+       if (ret < 0)
+               goto release_feed;
 
        ret = tsfeed->start_filtering(tsfeed);
-       if (ret < 0) {
-               dmxdev->demux->release_ts_feed(dmxdev->demux, tsfeed);
-               return ret;
-       }
+       if (ret < 0)
+               goto release_feed;
 
        return 0;
+
+release_feed:
+       dmxdev->demux->release_ts_feed(dmxdev->demux, tsfeed);
+       return ret;
 }
 
 static int dvb_dmxdev_filter_start(struct dmxdev_filter *filter)
-- 
2.14.1

Reply via email to