Re: [PATCH 1/2] media: pxa_camera: don't deferenciate a NULL pointer

2018-12-07 Thread Sakari Ailus
Hi Mauro, On Fri, Dec 07, 2018 at 08:07:54AM -0500, Mauro Carvalho Chehab wrote: > As warned by smatch: > drivers/media/platform/pxa_camera.c:2400 pxa_camera_probe() error: we > previously assumed 'pcdev->pdata' could be null (see line 2397) > > It would be possible that neither DT nor

[PATCH 1/2] media: pxa_camera: don't deferenciate a NULL pointer

2018-12-07 Thread Mauro Carvalho Chehab
As warned by smatch: drivers/media/platform/pxa_camera.c:2400 pxa_camera_probe() error: we previously assumed 'pcdev->pdata' could be null (see line 2397) It would be possible that neither DT nor platform data would be provided. This is a Kernel bug, so warn about that and bail.