Re: [PATCH 1/3] media: atomisp: convert default struct values to use compound-literals with designated initializers.

2017-12-01 Thread Jeremy Sowden
On 2017-12-01, at 18:07:25 +0300, Dan Carpenter wrote: > I can't apply this (to today's linux-next) but does this really work: > > > +(struct ia_css_3a_grid_info) { \ > > + .ae_enable = 0, \ > > + .ae_grd_info= (struct ae_public_config_grid_config) { \ > > +

Re: [PATCH 1/3] media: atomisp: convert default struct values to use compound-literals with designated initializers.

2017-12-01 Thread Dan Carpenter
I can't apply this (to today's linux-next) but does this really work: > +(struct ia_css_3a_grid_info) { \ > + .ae_enable = 0, \ > + .ae_grd_info= (struct ae_public_config_grid_config) { \ > + width = 0, \ > +

[PATCH 1/3] media: atomisp: convert default struct values to use compound-literals with designated initializers.

2017-11-30 Thread Jeremy Sowden
The CSS API uses a lot of nested anonymous structs defined in object macros to assign default values to its data-structures. These have been changed to use compound-literals and designated initializers to make them more comprehensible and less fragile. The compound-literals can also be used in