Re: [PATCH 2/2] as3645a: Add driver for LED flash controller

2011-09-28 Thread Hans Verkuil
On Tuesday, September 27, 2011 19:59:47 Laurent Pinchart wrote: Hi Hans, Thanks for the review. On Monday 26 September 2011 12:21:11 Hans Verkuil wrote: On Friday, September 09, 2011 17:52:49 Laurent Pinchart wrote: [snip] +/* Register definitions */ + +/* Read-only Design

Re: [PATCH 2/2] as3645a: Add driver for LED flash controller

2011-09-27 Thread Laurent Pinchart
Hi Hans, Thanks for the review. On Monday 26 September 2011 12:21:11 Hans Verkuil wrote: On Friday, September 09, 2011 17:52:49 Laurent Pinchart wrote: [snip] +/* Register definitions */ + +/* Read-only Design info register: Reset state: 0001 - for Senna */ What's 'Senna'? I see

Re: [PATCH 2/2] as3645a: Add driver for LED flash controller

2011-09-26 Thread Hans Verkuil
Hi Laurent, Here's a quick review (just two small things): On Friday, September 09, 2011 17:52:49 Laurent Pinchart wrote: This patch adds the driver for the as3645a LED flash controller. This controller supports a high power led in flash and torch modes and an indicator light, sometimes also

[PATCH 2/2] as3645a: Add driver for LED flash controller

2011-09-09 Thread Laurent Pinchart
This patch adds the driver for the as3645a LED flash controller. This controller supports a high power led in flash and torch modes and an indicator light, sometimes also called privacy light. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Nayden Kanchev