Re: [PATCH 2/2 v6] of: add generic videomode description

2012-10-22 Thread Steffen Trumtrar
On Sat, Oct 20, 2012 at 01:04:12PM +0200, Thierry Reding wrote: On Thu, Oct 04, 2012 at 07:59:20PM +0200, Steffen Trumtrar wrote: [...] diff --git a/drivers/of/of_videomode.c b/drivers/of/of_videomode.c [...] +#if defined(CONFIG_DRM) This should be: #if IS_ENABLED(CONFIG_DRM)

Re: [PATCH 2/2 v6] of: add generic videomode description

2012-10-20 Thread Thierry Reding
On Sun, Oct 07, 2012 at 03:38:33PM +0200, Laurent Pinchart wrote: Hi Steffen, On Friday 05 October 2012 17:51:21 Steffen Trumtrar wrote: On Thu, Oct 04, 2012 at 12:51:00PM -0600, Stephen Warren wrote: On 10/04/2012 11:59 AM, Steffen Trumtrar wrote: Get videomode from devicetree in a

Re: [PATCH 2/2 v6] of: add generic videomode description

2012-10-20 Thread Thierry Reding
On Tue, Oct 09, 2012 at 09:26:08AM +0200, Steffen Trumtrar wrote: Hi Laurent, On Mon, Oct 08, 2012 at 10:52:04PM +0200, Laurent Pinchart wrote: Hi Steffen, On Monday 08 October 2012 14:48:01 Steffen Trumtrar wrote: On Mon, Oct 08, 2012 at 02:13:50PM +0200, Laurent Pinchart wrote:

Re: [PATCH 2/2 v6] of: add generic videomode description

2012-10-20 Thread Thierry Reding
On Thu, Oct 04, 2012 at 07:59:20PM +0200, Steffen Trumtrar wrote: [...] diff --git a/drivers/of/of_videomode.c b/drivers/of/of_videomode.c [...] +#if defined(CONFIG_DRM) This should be: #if IS_ENABLED(CONFIG_DRM) or the code below won't be included if DRM is built as a module. But see

Re: [PATCH 2/2 v6] of: add generic videomode description

2012-10-09 Thread Steffen Trumtrar
Hi Laurent, On Mon, Oct 08, 2012 at 10:52:04PM +0200, Laurent Pinchart wrote: Hi Steffen, On Monday 08 October 2012 14:48:01 Steffen Trumtrar wrote: On Mon, Oct 08, 2012 at 02:13:50PM +0200, Laurent Pinchart wrote: On Thursday 04 October 2012 19:59:20 Steffen Trumtrar wrote: Get

Re: [PATCH 2/2 v6] of: add generic videomode description

2012-10-08 Thread Tomi Valkeinen
On Thu, 2012-10-04 at 19:59 +0200, Steffen Trumtrar wrote: Get videomode from devicetree in a format appropriate for the backend. drm_display_mode and fb_videomode are supported atm. Uses the display signal timings from of_display_timings Signed-off-by: Steffen Trumtrar

Re: [PATCH 2/2 v6] of: add generic videomode description

2012-10-08 Thread Steffen Trumtrar
On Mon, Oct 08, 2012 at 10:21:53AM +0300, Tomi Valkeinen wrote: On Thu, 2012-10-04 at 19:59 +0200, Steffen Trumtrar wrote: Get videomode from devicetree in a format appropriate for the backend. drm_display_mode and fb_videomode are supported atm. Uses the display signal timings from

Re: [PATCH 2/2 v6] of: add generic videomode description

2012-10-08 Thread Laurent Pinchart
Hi Steffen, Thanks for the patch. On Thursday 04 October 2012 19:59:20 Steffen Trumtrar wrote: Get videomode from devicetree in a format appropriate for the backend. drm_display_mode and fb_videomode are supported atm. Uses the display signal timings from of_display_timings Signed-off-by:

Re: [PATCH 2/2 v6] of: add generic videomode description

2012-10-08 Thread Laurent Pinchart
Hi Steffen, On Monday 08 October 2012 09:57:41 Steffen Trumtrar wrote: On Mon, Oct 08, 2012 at 10:21:53AM +0300, Tomi Valkeinen wrote: On Thu, 2012-10-04 at 19:59 +0200, Steffen Trumtrar wrote: [snip] diff --git a/include/linux/of_videomode.h b/include/linux/of_videomode.h new file

Re: [PATCH 2/2 v6] of: add generic videomode description

2012-10-08 Thread Steffen Trumtrar
On Mon, Oct 08, 2012 at 02:13:50PM +0200, Laurent Pinchart wrote: Hi Steffen, Thanks for the patch. On Thursday 04 October 2012 19:59:20 Steffen Trumtrar wrote: Get videomode from devicetree in a format appropriate for the backend. drm_display_mode and fb_videomode are supported atm.

Re: [PATCH 2/2 v6] of: add generic videomode description

2012-10-05 Thread Steffen Trumtrar
On Thu, Oct 04, 2012 at 12:51:00PM -0600, Stephen Warren wrote: On 10/04/2012 11:59 AM, Steffen Trumtrar wrote: Get videomode from devicetree in a format appropriate for the backend. drm_display_mode and fb_videomode are supported atm. Uses the display signal timings from of_display_timings

[PATCH 2/2 v6] of: add generic videomode description

2012-10-04 Thread Steffen Trumtrar
Get videomode from devicetree in a format appropriate for the backend. drm_display_mode and fb_videomode are supported atm. Uses the display signal timings from of_display_timings Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- drivers/of/Kconfig |5 +

Re: [PATCH 2/2 v6] of: add generic videomode description

2012-10-04 Thread Stephen Warren
On 10/04/2012 11:59 AM, Steffen Trumtrar wrote: Get videomode from devicetree in a format appropriate for the backend. drm_display_mode and fb_videomode are supported atm. Uses the display signal timings from of_display_timings +++ b/drivers/of/of_videomode.c +int