Re: [PATCH 21/66] rtl2830: implement own I2C locking

2015-02-04 Thread Mark Brown
On Tue, Feb 03, 2015 at 08:34:01PM +0200, Antti Palosaari wrote: On 02/03/2015 07:53 PM, Mauro Carvalho Chehab wrote: If latter a better way to lock the I2C mux appears, we can reverse this change. More I am worried about next patch in a serie, which converts all that to regmap API... Same

Re: [PATCH 21/66] rtl2830: implement own I2C locking

2015-02-03 Thread Antti Palosaari
On 02/03/2015 07:53 PM, Mauro Carvalho Chehab wrote: Em Mon, 02 Feb 2015 21:33:24 +0100 Wolfram Sang w...@the-dreams.de escreveu: Ok, this may eventually work ok for now, but a further change at the I2C core could easily break it. So, we need to double check about such patch with the I2C

Re: [PATCH 21/66] rtl2830: implement own I2C locking

2015-02-03 Thread Mauro Carvalho Chehab
Em Mon, 02 Feb 2015 21:33:24 +0100 Wolfram Sang w...@the-dreams.de escreveu: Ok, this may eventually work ok for now, but a further change at the I2C core could easily break it. So, we need to double check about such patch with the I2C maintainer. Jean, Are you ok with such

Re: [PATCH 21/66] rtl2830: implement own I2C locking

2015-02-02 Thread Lars-Peter Clausen
On 02/02/2015 09:33 PM, Wolfram Sang wrote: Ok, this may eventually work ok for now, but a further change at the I2C core could easily break it. So, we need to double check about such patch with the I2C maintainer. Jean, Are you ok with such patch? If so, please ack. Jean handed over I2C

Re: [PATCH 21/66] rtl2830: implement own I2C locking

2015-02-02 Thread Mauro Carvalho Chehab
Em Tue, 23 Dec 2014 22:49:14 +0200 Antti Palosaari cr...@iki.fi escreveu: Own I2C locking is needed due to two special reasons: 1) Chips uses multiple register pages/banks on single I2C slave. Page is changed via I2C register access. 2) Chip offers muxed/gated I2C adapter for tuner. Gate/mux

Re: [PATCH 21/66] rtl2830: implement own I2C locking

2015-02-02 Thread Antti Palosaari
On 02/02/2015 10:56 PM, Jean Delvare wrote: Hi Mauro, Antti, On Mon, 2 Feb 2015 18:07:26 -0200, Mauro Carvalho Chehab wrote: Em Tue, 23 Dec 2014 22:49:14 +0200 Antti Palosaari cr...@iki.fi escreveu: Own I2C locking is needed due to two special reasons: 1) Chips uses multiple register

Re: [PATCH 21/66] rtl2830: implement own I2C locking

2015-02-02 Thread Antti Palosaari
On 02/02/2015 10:07 PM, Mauro Carvalho Chehab wrote: Em Tue, 23 Dec 2014 22:49:14 +0200 Antti Palosaari cr...@iki.fi escreveu: Own I2C locking is needed due to two special reasons: 1) Chips uses multiple register pages/banks on single I2C slave. Page is changed via I2C register access. 2) Chip

Re: [PATCH 21/66] rtl2830: implement own I2C locking

2015-02-02 Thread Wolfram Sang
Ok, this may eventually work ok for now, but a further change at the I2C core could easily break it. So, we need to double check about such patch with the I2C maintainer. Jean, Are you ok with such patch? If so, please ack. Jean handed over I2C to me in late 2012 :) Basic problem here

Re: [PATCH 21/66] rtl2830: implement own I2C locking

2015-02-02 Thread Jean Delvare
Hi Mauro, Antti, On Mon, 2 Feb 2015 18:07:26 -0200, Mauro Carvalho Chehab wrote: Em Tue, 23 Dec 2014 22:49:14 +0200 Antti Palosaari cr...@iki.fi escreveu: Own I2C locking is needed due to two special reasons: 1) Chips uses multiple register pages/banks on single I2C slave. Page is

[PATCH 21/66] rtl2830: implement own I2C locking

2014-12-23 Thread Antti Palosaari
Own I2C locking is needed due to two special reasons: 1) Chips uses multiple register pages/banks on single I2C slave. Page is changed via I2C register access. 2) Chip offers muxed/gated I2C adapter for tuner. Gate/mux is controlled by I2C register access. Due to these reasons, I2C locking did