Re: [PATCH 3/3 v7] uvcvideo: add a metadata device node

2017-12-11 Thread Laurent Pinchart
Hi Guennadi, On Wednesday, 6 December 2017 17:08:14 EET Guennadi Liakhovetski wrote: > Hi Laurent, > > While testing the new patch version, we did introduce a couple of > differences: > > 1. We cannot (easily) reuse .vidioc_querycap() - the metadata node uses > v4l2_fh_open() directly, so, it

Re: [PATCH 3/3 v7] uvcvideo: add a metadata device node

2017-12-06 Thread Guennadi Liakhovetski
Hi Laurent, While testing the new patch version, we did introduce a couple of differences: 1. We cannot (easily) reuse .vidioc_querycap() - the metadata node uses v4l2_fh_open() directly, so, it has a different struct file::private_data pointer. 2. After your video device unification, the

Re: [PATCH 3/3 v7] uvcvideo: add a metadata device node

2017-12-05 Thread Guennadi Liakhovetski
On Tue, 5 Dec 2017, Laurent Pinchart wrote: > Hi Guennadi, > > On Tuesday, 5 December 2017 15:44:34 EET Guennadi Liakhovetski wrote: > > On Tue, 5 Dec 2017, Laurent Pinchart wrote: > > > On Tuesday, 5 December 2017 12:56:53 EET Guennadi Liakhovetski wrote: > > >> On Tue, 5 Dec 2017, Laurent

Re: [PATCH 3/3 v7] uvcvideo: add a metadata device node

2017-12-05 Thread Laurent Pinchart
Hi Guennadi, On Tuesday, 5 December 2017 15:44:34 EET Guennadi Liakhovetski wrote: > On Tue, 5 Dec 2017, Laurent Pinchart wrote: > > On Tuesday, 5 December 2017 12:56:53 EET Guennadi Liakhovetski wrote: > >> On Tue, 5 Dec 2017, Laurent Pinchart wrote: > >>> On Wednesday, 8 November 2017 18:00:14

Re: [PATCH 3/3 v7] uvcvideo: add a metadata device node

2017-12-05 Thread Guennadi Liakhovetski
On Tue, 5 Dec 2017, Laurent Pinchart wrote: > Hi Guennadi, > > On Tuesday, 5 December 2017 12:56:53 EET Guennadi Liakhovetski wrote: > > On Tue, 5 Dec 2017, Laurent Pinchart wrote: > > > On Wednesday, 8 November 2017 18:00:14 EET Guennadi Liakhovetski wrote: > > >> Some UVC video cameras contain

Re: [PATCH 3/3 v7] uvcvideo: add a metadata device node

2017-12-05 Thread Laurent Pinchart
Hi Guennadi, On Tuesday, 5 December 2017 12:56:53 EET Guennadi Liakhovetski wrote: > On Tue, 5 Dec 2017, Laurent Pinchart wrote: > > On Wednesday, 8 November 2017 18:00:14 EET Guennadi Liakhovetski wrote: > >> Some UVC video cameras contain metadata in their payload headers. This > >> patch

Re: [PATCH 3/3 v7] uvcvideo: add a metadata device node

2017-12-05 Thread Guennadi Liakhovetski
Hi Laurent, Thanks for a review. On Tue, 5 Dec 2017, Laurent Pinchart wrote: > Hi Guennadi, > > Thank you for the patch. We're getting very close, I only have small > comments, > please see below. > > On Wednesday, 8 November 2017 18:00:14 EET Guennadi Liakhovetski wrote: > > Some UVC video

Re: [PATCH 3/3 v7] uvcvideo: add a metadata device node

2017-12-05 Thread Laurent Pinchart
Hi Guennadi, On Tuesday, 5 December 2017 10:06:02 EET Guennadi Liakhovetski wrote: > On Tue, 5 Dec 2017, Laurent Pinchart wrote: > > On Tuesday, 5 December 2017 02:24:30 EET Laurent Pinchart wrote: > >> On Wednesday, 8 November 2017 18:00:14 EET Guennadi Liakhovetski wrote: > > [snip] > > > >>>

Re: [PATCH 3/3 v7] uvcvideo: add a metadata device node

2017-12-05 Thread Guennadi Liakhovetski
Hi Laurent, On Tue, 5 Dec 2017, Laurent Pinchart wrote: > Hi Guennadi, > > On Tuesday, 5 December 2017 02:24:30 EET Laurent Pinchart wrote: > > On Wednesday, 8 November 2017 18:00:14 EET Guennadi Liakhovetski wrote: > > [snip] > > > > +static void uvc_video_decode_meta(struct uvc_streaming

Re: [PATCH 3/3 v7] uvcvideo: add a metadata device node

2017-12-04 Thread Laurent Pinchart
Hi Guennadi, On Tuesday, 5 December 2017 02:24:30 EET Laurent Pinchart wrote: > On Wednesday, 8 November 2017 18:00:14 EET Guennadi Liakhovetski wrote: [snip] > > +static void uvc_video_decode_meta(struct uvc_streaming *stream, > > + struct uvc_buffer *buf, struct uvc_buffer

Re: [PATCH 3/3 v7] uvcvideo: add a metadata device node

2017-12-04 Thread Laurent Pinchart
Hi Guennadi, Thank you for the patch. We're getting very close, I only have small comments, please see below. On Wednesday, 8 November 2017 18:00:14 EET Guennadi Liakhovetski wrote: > Some UVC video cameras contain metadata in their payload headers. This > patch extracts that data, adding more

[PATCH 3/3 v7] uvcvideo: add a metadata device node

2017-11-08 Thread Guennadi Liakhovetski
Some UVC video cameras contain metadata in their payload headers. This patch extracts that data, adding more clock synchronisation information, on both bulk and isochronous endpoints and makes it available to the user space on a separate video node, using the V4L2_CAP_META_CAPTURE capability and