Re: [PATCH 5/8] nuvoton-cir: Code cleanup: remove unused variable and function

2012-06-15 Thread Jarod Wilson
On Thu, Jun 14, 2012 at 02:58:13PM -0300, Peter Senna Tschudin wrote: Tested by compilation only. Making use of this code is on the TODO list, possibly even happens by way of David's pending patches for lirc interface parity, so I'm against removing it. -- Jarod Wilson ja...@redhat.com -- To

[PATCH 5/8] nuvoton-cir: Code cleanup: remove unused variable and function

2012-06-14 Thread Peter Senna Tschudin
Tested by compilation only. Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com --- drivers/media/rc/nuvoton-cir.c | 37 - 1 file changed, 37 deletions(-) diff --git a/drivers/media/rc/nuvoton-cir.c b/drivers/media/rc/nuvoton-cir.c index

Re: [PATCH 5/8] nuvoton-cir: Code cleanup: remove unused variable and function

2012-06-14 Thread Ben Hutchings
On Thu, Jun 14, 2012 at 02:58:13PM -0300, Peter Senna Tschudin wrote: Tested by compilation only. [...] I can't say whether this is correct since I never used the driver either, but the function you remove is reading registers so it may have important side-effects. Ben. -- Ben Hutchings We