Re: [PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_characteristics' set but not used

2010-06-15 Thread Jean Delvare
On Mon, 14 Jun 2010 13:26:47 -0700, Justin P. Mattock wrote: Temporary fix until something is resolved This is wrong by design, sorry. Warnings aren't blocking, and thus need no temporary fix. Such temporary fixes would be only hiding the warning, cancelling the good work of gcc developers. Nack

Re: [PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_characteristics' set but not used

2010-06-15 Thread Justin P. Mattock
On 06/15/2010 04:38 AM, Jean Delvare wrote: On Mon, 14 Jun 2010 13:26:47 -0700, Justin P. Mattock wrote: Temporary fix until something is resolved This is wrong by design, sorry. Warnings aren't blocking, and thus need no temporary fix. Such temporary fixes would be only hiding the warning,

[PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_characteristics' set but not used

2010-06-14 Thread Justin P. Mattock
Temporary fix until something is resolved to fix the below warning: CC [M] drivers/ieee1394/sbp2.o drivers/ieee1394/sbp2.c: In function 'sbp2_parse_unit_directory': drivers/ieee1394/sbp2.c:1353:6: warning: variable 'unit_characteristics' set but not used Signed-off-by: Justin P. Mattock