Re: [PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

2017-07-13 Thread Jasmin J.
Hello Antti! > actually it reports, when run --strict mode I checked this once, but I thought this would be too aggressive changes. >> * many cases where if (ret != 0), which generally should be written as if >> (ret). If you expect it is just error ret value, then prefer if (ret), but >> if>

Re: [PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

2017-07-12 Thread Antti Palosaari
On 07/13/2017 03:04 AM, Antti Palosaari wrote: On 07/13/2017 02:45 AM, Jasmin J. wrote: Hello Antti! Have you ever looked that coding style doc? Yes I read it several times already and used it in my daily work in my previous company. Beside the Multi-line comment style, which I will fix

Re: [PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

2017-07-12 Thread Antti Palosaari
On 07/13/2017 02:45 AM, Jasmin J. wrote: Hello Antti! Have you ever looked that coding style doc? Yes I read it several times already and used it in my daily work in my previous company. Beside the Multi-line comment style, which I will fix in a follow up, you mentioned other issues. Please

Re: [PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

2017-07-12 Thread Jasmin J.
Hello Antti! > Have you ever looked that coding style doc? Yes I read it several times already and used it in my daily work in my previous company. Beside the Multi-line comment style, which I will fix in a follow up, you mentioned other issues. Please can you tell me which one you mean, so that

Re: [PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

2017-07-12 Thread Antti Palosaari
On 07/13/2017 02:23 AM, Jasmin J. wrote: Hello Antti! Quickly looking this patch serie I noticed few other coding style mistakes. You should read kernel coding style documentation first, and then make changes according to doc. In fact I used checkpatch.pl to find the issues and fixed them.

Re: [PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

2017-07-12 Thread Jasmin J.
Hello Antti! > Quickly looking this patch serie I noticed few other coding style mistakes. > You should read kernel coding style documentation first, and then make > changes according to doc. In fact I used checkpatch.pl to find the issues and fixed them. All the patches are 100% checkpatch.pl

Re: [PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

2017-07-12 Thread Antti Palosaari
On 07/13/2017 02:00 AM, Jasmin J. wrote: From: Jasmin Jessich Fixed all: WARNING: Block comments use * on subsequent lines Also multiline comments should be written like this: /* * Comment. */ Quickly looking this patch serie I noticed few other coding style mistakes.

[PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

2017-07-12 Thread Jasmin J.
From: Jasmin Jessich Fixed all: WARNING: Block comments use * on subsequent lines Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git