Re: [PATCH v1 07/11] media: Add registration helpers for V4L2 flash sub-devices

Hi Sakari, On 03/25/2015 02:00 AM, Sakari Ailus wrote: Hi Jacek, On Tue, Mar 24, 2015 at 09:35:05AM +0100, Jacek Anaszewski wrote: ... diff --git a/drivers/media/v4l2-core/v4l2-flash.c b/drivers/media/v4l2-core/v4l2-flash.c new file mode 100644 index 000..804c2e4 --- /dev/null +++

Re: [PATCH v1 07/11] media: Add registration helpers for V4L2 flash sub-devices

Hi Jacek, One more comment on this one: On Fri, Mar 20, 2015 at 04:03:27PM +0100, Jacek Anaszewski wrote: ... +struct v4l2_flash *v4l2_flash_init(struct led_classdev_flash *fled_cdev, +const struct v4l2_flash_ops *ops, +struct

Re: [PATCH v1 07/11] media: Add registration helpers for V4L2 flash sub-devices

Hi Jacek, On Tue, Mar 24, 2015 at 09:35:05AM +0100, Jacek Anaszewski wrote: ... diff --git a/drivers/media/v4l2-core/v4l2-flash.c b/drivers/media/v4l2-core/v4l2-flash.c new file mode 100644 index 000..804c2e4 --- /dev/null +++ b/drivers/media/v4l2-core/v4l2-flash.c @@ -0,0 +1,607 @@

Re: [PATCH v1 07/11] media: Add registration helpers for V4L2 flash sub-devices

Hi Sakari, On 03/23/2015 11:35 PM, Sakari Ailus wrote: Hi Jacek, On Mon, Mar 23, 2015 at 04:08:10PM +0100, Jacek Anaszewski wrote: Hi Sakari, Thanks for the review. On 03/22/2015 01:22 AM, Sakari Ailus wrote: Hi Jacek, Thanks for the updated set. Some comments below. On Fri, Mar 20, 2015

Re: [PATCH v1 07/11] media: Add registration helpers for V4L2 flash sub-devices

Hi Sakari, Thanks for the review. On 03/22/2015 01:22 AM, Sakari Ailus wrote: Hi Jacek, Thanks for the updated set. Some comments below. On Fri, Mar 20, 2015 at 04:03:27PM +0100, Jacek Anaszewski wrote: This patch adds helper functions for registering/unregistering LED Flash class devices

Re: [PATCH v1 07/11] media: Add registration helpers for V4L2 flash sub-devices

Hi Jacek, On Mon, Mar 23, 2015 at 04:08:10PM +0100, Jacek Anaszewski wrote: Hi Sakari, Thanks for the review. On 03/22/2015 01:22 AM, Sakari Ailus wrote: Hi Jacek, Thanks for the updated set. Some comments below. On Fri, Mar 20, 2015 at 04:03:27PM +0100, Jacek Anaszewski wrote:

Re: [PATCH v1 07/11] media: Add registration helpers for V4L2 flash sub-devices

Hi Jacek, Thanks for the updated set. Some comments below. On Fri, Mar 20, 2015 at 04:03:27PM +0100, Jacek Anaszewski wrote: This patch adds helper functions for registering/unregistering LED Flash class devices as V4L2 sub-devices. The functions should be called from the LED subsystem device

[PATCH v1 07/11] media: Add registration helpers for V4L2 flash sub-devices

This patch adds helper functions for registering/unregistering LED Flash class devices as V4L2 sub-devices. The functions should be called from the LED subsystem device driver. In case the support for V4L2 Flash sub-devices is disabled in the kernel config the functions' empty versions will be