Re: [PATCH v12 3/6] fbmon: add videomode helpers

2012-11-22 Thread Laurent Pinchart
Hi Steffen, Sorry, I've just found another small bug below. On Tuesday 20 November 2012 16:54:53 Steffen Trumtrar wrote: Add a function to convert from the generic videomode to a fb_videomode. Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de Reviewed-by: Thierry Reding

Re: [PATCH v12 3/6] fbmon: add videomode helpers

2012-11-22 Thread Sascha Hauer
On Thu, Nov 22, 2012 at 09:50:10AM +0100, Laurent Pinchart wrote: Hi Sascha, On Thursday 22 November 2012 07:20:00 Sascha Hauer wrote: On Wed, Nov 21, 2012 at 11:02:44PM +0100, Laurent Pinchart wrote: Hi Steffen, + + htotal = vm-hactive + vm-hfront_porch + vm-hback_porch

Re: [PATCH v12 3/6] fbmon: add videomode helpers

2012-11-22 Thread Sascha Hauer
Hi Laurent, On Wed, Nov 21, 2012 at 11:02:44PM +0100, Laurent Pinchart wrote: Hi Steffen, + + htotal = vm-hactive + vm-hfront_porch + vm-hback_porch + +vm-hsync_len; + vtotal = vm-vactive + vm-vfront_porch + vm-vback_porch + +vm-vsync_len; +

Re: [PATCH v12 3/6] fbmon: add videomode helpers

2012-11-22 Thread Laurent Pinchart
Hi Sascha, On Thursday 22 November 2012 07:20:00 Sascha Hauer wrote: On Wed, Nov 21, 2012 at 11:02:44PM +0100, Laurent Pinchart wrote: Hi Steffen, + + htotal = vm-hactive + vm-hfront_porch + vm-hback_porch + + vm-hsync_len; + vtotal = vm-vactive + vm-vfront_porch +

Re: [PATCH v12 3/6] fbmon: add videomode helpers

2012-11-22 Thread Laurent Pinchart
On Thursday 22 November 2012 09:53:42 Sascha Hauer wrote: On Thu, Nov 22, 2012 at 09:50:10AM +0100, Laurent Pinchart wrote: On Thursday 22 November 2012 07:20:00 Sascha Hauer wrote: On Wed, Nov 21, 2012 at 11:02:44PM +0100, Laurent Pinchart wrote: Hi Steffen, + +

Re: [PATCH v12 3/6] fbmon: add videomode helpers

2012-11-22 Thread Steffen Trumtrar
On Thu, Nov 22, 2012 at 10:07:07AM +0100, Laurent Pinchart wrote: On Thursday 22 November 2012 09:53:42 Sascha Hauer wrote: On Thu, Nov 22, 2012 at 09:50:10AM +0100, Laurent Pinchart wrote: On Thursday 22 November 2012 07:20:00 Sascha Hauer wrote: On Wed, Nov 21, 2012 at 11:02:44PM

RE: [PATCH v12 3/6] fbmon: add videomode helpers

2012-11-21 Thread Manjunathappa, Prakash
Hi Steffen, I am trying to add DT support for da8xx-fb driver on top of your patches. Encountered below build error. Sorry for reporting it late. On Tue, Nov 20, 2012 at 21:24:53, Steffen Trumtrar wrote: Add a function to convert from the generic videomode to a fb_videomode. Signed-off-by:

Re: [PATCH v12 3/6] fbmon: add videomode helpers

2012-11-21 Thread Leela Krishna Amudala
Yes, Even I got the same build error. later I fixed it by including #include linux/mxsfb.h Best Wishes, Leela Krishna. On Wed, Nov 21, 2012 at 3:39 PM, Manjunathappa, Prakash prakash...@ti.com wrote: Hi Steffen, I am trying to add DT support for da8xx-fb driver on top of your patches.

Re: [PATCH v12 3/6] fbmon: add videomode helpers

2012-11-21 Thread Steffen Trumtrar
Hi! On Wed, Nov 21, 2012 at 04:39:01PM +0530, Leela Krishna Amudala wrote: Yes, Even I got the same build error. later I fixed it by including #include linux/mxsfb.h Best Wishes, Leela Krishna. On Wed, Nov 21, 2012 at 3:39 PM, Manjunathappa, Prakash prakash...@ti.com wrote: Hi

Re: [PATCH v12 3/6] fbmon: add videomode helpers

2012-11-21 Thread Tomi Valkeinen
On 2012-11-20 17:54, Steffen Trumtrar wrote: diff --git a/include/linux/fb.h b/include/linux/fb.h index c7a9571..920cbe3 100644 --- a/include/linux/fb.h +++ b/include/linux/fb.h @@ -14,6 +14,7 @@ #include linux/backlight.h #include linux/slab.h #include asm/io.h +#include

[PATCH v12 3/6] fbmon: add videomode helpers

2012-11-20 Thread Steffen Trumtrar
Add a function to convert from the generic videomode to a fb_videomode. Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de Reviewed-by: Thierry Reding thierry.red...@avionic-design.de Acked-by: Thierry Reding thierry.red...@avionic-design.de Tested-by: Thierry Reding