Re: [PATCH v2] [media] mtk-mdp: Fix g_/s_selection capture/compose logic

2017-06-20 Thread Minghsiu Tsai
On Mon, 2017-06-19 at 12:10 +0200, Hans Verkuil wrote: > On 06/19/2017 12:03 PM, Minghsiu Tsai wrote: > > Hi, Hans, > > > > On Fri, 2017-06-16 at 12:42 +0200, Hans Verkuil wrote: > >> On 05/12/17 04:42, Minghsiu Tsai wrote: > >>> From: Daniel Kurtz > >>> > >>> Experiments

Re: [PATCH v2] [media] mtk-mdp: Fix g_/s_selection capture/compose logic

2017-06-19 Thread Hans Verkuil
On 06/19/2017 12:03 PM, Minghsiu Tsai wrote: Hi, Hans, On Fri, 2017-06-16 at 12:42 +0200, Hans Verkuil wrote: On 05/12/17 04:42, Minghsiu Tsai wrote: From: Daniel Kurtz Experiments show that the: (1) mtk-mdp uses the _MPLANE form of CAPTURE/OUTPUT Please drop this,

Re: [PATCH v2] [media] mtk-mdp: Fix g_/s_selection capture/compose logic

2017-06-19 Thread Minghsiu Tsai
Hi, Hans, On Fri, 2017-06-16 at 12:42 +0200, Hans Verkuil wrote: > On 05/12/17 04:42, Minghsiu Tsai wrote: > > From: Daniel Kurtz > > > > Experiments show that the: > > (1) mtk-mdp uses the _MPLANE form of CAPTURE/OUTPUT > > Please drop this, since this no longer applies

Re: [PATCH v2] [media] mtk-mdp: Fix g_/s_selection capture/compose logic

2017-06-16 Thread Hans Verkuil
On 05/12/17 04:42, Minghsiu Tsai wrote: > From: Daniel Kurtz > > Experiments show that the: > (1) mtk-mdp uses the _MPLANE form of CAPTURE/OUTPUT Please drop this, since this no longer applies to this patch. > (2) CAPTURE types use CROP targets, and OUTPUT types use

Re: [PATCH v2] [media] mtk-mdp: Fix g_/s_selection capture/compose logic

2017-06-15 Thread Hans Verkuil
On 06/15/17 08:29, Minghsiu Tsai wrote: > Hi, Hans, > > Would you have time to review this patch v2? > The patch v1 violates v4l2 spec. I have fixed it in v2. I plan to review it Friday or Monday. Regards, Hans > > > Sincerely, > Ming Hsiu > > On Fri, 2017-05-12 at 10:42 +0800,

Re: [PATCH v2] [media] mtk-mdp: Fix g_/s_selection capture/compose logic

2017-06-15 Thread Minghsiu Tsai
Hi, Hans, Would you have time to review this patch v2? The patch v1 violates v4l2 spec. I have fixed it in v2. Sincerely, Ming Hsiu On Fri, 2017-05-12 at 10:42 +0800, Minghsiu Tsai wrote: > From: Daniel Kurtz > > Experiments show that the: > (1) mtk-mdp uses the

[PATCH v2] [media] mtk-mdp: Fix g_/s_selection capture/compose logic

2017-05-11 Thread Minghsiu Tsai
From: Daniel Kurtz Experiments show that the: (1) mtk-mdp uses the _MPLANE form of CAPTURE/OUTPUT (2) CAPTURE types use CROP targets, and OUTPUT types use COMPOSE targets Signed-off-by: Daniel Kurtz Signed-off-by: Minghsiu Tsai