Re: [PATCH v2 04/19] media: camss: Add CSIPHY files

2017-06-30 Thread Sakari Ailus
Hi Todor, On Fri, Jun 30, 2017 at 10:00:25AM +0300, Todor Tomov wrote: > Hi Sakari, > > On 06/30/2017 02:53 AM, Sakari Ailus wrote: > > Hi Todor, > > > > On Thu, Jun 29, 2017 at 07:36:47PM +0300, Todor Tomov wrote: > +/* > + * csiphy_link_setup - Setup CSIPHY connections > + *

Re: [PATCH v2 04/19] media: camss: Add CSIPHY files

2017-06-30 Thread Todor Tomov
Hi Sakari, On 06/30/2017 02:53 AM, Sakari Ailus wrote: > Hi Todor, > > On Thu, Jun 29, 2017 at 07:36:47PM +0300, Todor Tomov wrote: +/* + * csiphy_link_setup - Setup CSIPHY connections + * @entity: Pointer to media entity structure + * @local: Pointer to local pad + *

Re: [PATCH v2 04/19] media: camss: Add CSIPHY files

2017-06-29 Thread Sakari Ailus
Hi Todor, On Thu, Jun 29, 2017 at 07:36:47PM +0300, Todor Tomov wrote: > >> +/* > >> + * csiphy_link_setup - Setup CSIPHY connections > >> + * @entity: Pointer to media entity structure > >> + * @local: Pointer to local pad > >> + * @remote: Pointer to remote pad > >> + * @flags: Link flags > >>

Re: [PATCH v2 04/19] media: camss: Add CSIPHY files

2017-06-29 Thread Todor Tomov
Hi Sakari, On 06/29/2017 12:34 AM, Sakari Ailus wrote: > Hi Todor, > > It's been a while --- how do you do? > > Thanks for the patchset! Thank you for the review. I'll focus more on this now, so let's see :) > > On Mon, Jun 19, 2017 at 05:48:24PM +0300, Todor Tomov wrote: >> These files

Re: [PATCH v2 04/19] media: camss: Add CSIPHY files

2017-06-28 Thread Sakari Ailus
Hi Todor, It's been a while --- how do you do? Thanks for the patchset! On Mon, Jun 19, 2017 at 05:48:24PM +0300, Todor Tomov wrote: > These files control the CSIPHY modules which are responsible for the physical > layer of the CSI2 receivers. > > Signed-off-by: Todor Tomov

[PATCH v2 04/19] media: camss: Add CSIPHY files

2017-06-19 Thread Todor Tomov
These files control the CSIPHY modules which are responsible for the physical layer of the CSI2 receivers. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/csiphy.c | 686 drivers/media/platform/qcom/camss-8x16/csiphy.h | 77