Re: [RESEND PATCH V2 2/2] media: ak7375: Add ak7375 lens voice coil driver

2018-06-04 Thread Bing Bu Cao
On 2018年06月01日 17:42, Sakari Ailus wrote: On Fri, May 25, 2018 at 05:55:35PM +0800, bingbu@intel.com wrote: +static int ak7375_i2c_write(struct ak7375_device *ak7375, + u8 addr, u16 data, int size) +{ + struct i2c_client *client = v4l2_get_subdevdata(>sd); + int ret; +

Re: [RESEND PATCH V2 2/2] media: ak7375: Add ak7375 lens voice coil driver

2018-06-01 Thread Sakari Ailus
On Fri, Jun 01, 2018 at 05:54:30PM +0800, Bing Bu Cao wrote: > > > +AKM AK7375 LENS VOICE COIL DRIVER > > > +M: Tianshu Qiu > > > +L: linux-media@vger.kernel.org > > > +T: git git://linuxtv.org/media_tree.git > > > +S: Maintained > > > +F: drivers/media/i2c/ak7375.c

Re: [RESEND PATCH V2 2/2] media: ak7375: Add ak7375 lens voice coil driver

2018-06-01 Thread Bing Bu Cao
On 2018年06月01日 17:34, Sakari Ailus wrote: Hi Bingbu, A few comments below. On Fri, May 25, 2018 at 05:55:35PM +0800, bingbu@intel.com wrote: From: Bingbu Cao Add a V4L2 sub-device driver for the ak7375 lens voice coil. This is a voice coil module using the I2C bus to control the

Re: [RESEND PATCH V2 2/2] media: ak7375: Add ak7375 lens voice coil driver

2018-06-01 Thread Sakari Ailus
On Fri, May 25, 2018 at 05:55:35PM +0800, bingbu@intel.com wrote: > +static int ak7375_i2c_write(struct ak7375_device *ak7375, > + u8 addr, u16 data, int size) > +{ > + struct i2c_client *client = v4l2_get_subdevdata(>sd); > + int ret; > + u8 buf[3]; > + > + if (size != 1

Re: [RESEND PATCH V2 2/2] media: ak7375: Add ak7375 lens voice coil driver

2018-06-01 Thread Sakari Ailus
Hi Bingbu, A few comments below. On Fri, May 25, 2018 at 05:55:35PM +0800, bingbu@intel.com wrote: > From: Bingbu Cao > > Add a V4L2 sub-device driver for the ak7375 lens voice coil. > This is a voice coil module using the I2C bus to control the > focus position. > > Signed-off-by:

[RESEND PATCH V2 2/2] media: ak7375: Add ak7375 lens voice coil driver

2018-05-25 Thread bingbu . cao
From: Bingbu Cao Add a V4L2 sub-device driver for the ak7375 lens voice coil. This is a voice coil module using the I2C bus to control the focus position. Signed-off-by: Tianshu Qiu Signed-off-by: Bingbu Cao --- MAINTAINERS

[PATCH v2 2/2] media: ak7375: Add ak7375 lens voice coil driver

2018-05-25 Thread bingbu . cao
From: Bingbu Cao Add a V4L2 sub-device driver for the ak7375 lens voice coil. This is a voice coil module using the I2C bus to control the focus position. Signed-off-by: Tianshu Qiu Signed-off-by: Bingbu Cao --- MAINTAINERS