lt;rajmohan.m...@intel.com>; Toivonen, Tuukka
> <tuukka.toivo...@intel.com>; Hans Verkuil <hverk...@xs4all.nl>; Yang,
> Hyungwoo <hyungwoo.y...@intel.com>
> Subject: Re: [PATCH v2 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2
> driver
>
> Hi Yong,
>
> Please
Hi Sylwester,
On Wed, Jun 28, 2017 at 05:44:32PM +0200, Sylwester Nawrocki wrote:
> Hi,
>
> On 06/28/2017 03:31 PM, Sakari Ailus wrote:
> > IMO VB2/V4L2 could better support conversion between single and
> > multi-planar buffer types so that the applications could just use any and
> > drivers
Hi,
On 06/28/2017 03:31 PM, Sakari Ailus wrote:
IMO VB2/V4L2 could better support conversion between single and
multi-planar buffer types so that the applications could just use any and
drivers could manage with one.
I don't have a strong opinion either way, but IMO this could be well
On Wed, Jun 28, 2017 at 10:36:54PM +0900, Tomasz Figa wrote:
> On Wed, Jun 28, 2017 at 10:31 PM, Sakari Ailus wrote:
> > On Tue, Jun 27, 2017 at 06:33:13PM +0900, Tomasz Figa wrote:
> >> On Mon, Jun 26, 2017 at 11:51 PM, Sakari Ailus wrote:
> >> > On
On Wed, Jun 28, 2017 at 10:31 PM, Sakari Ailus wrote:
> On Tue, Jun 27, 2017 at 06:33:13PM +0900, Tomasz Figa wrote:
>> On Mon, Jun 26, 2017 at 11:51 PM, Sakari Ailus wrote:
>> > On Mon, Jun 12, 2017 at 06:59:18PM +0900, Tomasz Figa wrote:
>> >
>> >>
>>
On Tue, Jun 27, 2017 at 06:33:13PM +0900, Tomasz Figa wrote:
> On Mon, Jun 26, 2017 at 11:51 PM, Sakari Ailus wrote:
> > On Mon, Jun 12, 2017 at 06:59:18PM +0900, Tomasz Figa wrote:
> >
> >>
> >> > + if (WARN_ON(freq <= 0))
> >> > + return -EINVAL;
> >>
>
On Mon, Jun 26, 2017 at 11:51 PM, Sakari Ailus wrote:
> On Mon, Jun 12, 2017 at 06:59:18PM +0900, Tomasz Figa wrote:
>
>>
>> > + if (WARN_ON(freq <= 0))
>> > + return -EINVAL;
>>
>> It generally doesn't make sense for the frequency to be negative, so
>>
Hi Tomasz,
A few more comments, better late than never I guess.
On Mon, Jun 12, 2017 at 06:59:18PM +0900, Tomasz Figa wrote:
...
> > +/*
> > + * The CSI2 receiver has several parameters affecting
> > + * the receiver timings. These depend on the MIPI bus frequency
> > + * F in Hz (sensor
Hi Tomasz,
On Mon, Jun 12, 2017 at 06:59:18PM +0900, Tomasz Figa wrote:
> Hi Yong,
>
> Please see my comments inline.
>
> On Wed, Jun 7, 2017 at 10:34 AM, Yong Zhi wrote:
> > This patch adds CIO2 CSI-2 device driver for
> > Intel's IPU3 camera sub-system support.
> >
> >
Hi Tuukka,
Thanks for your replies. Please see mine inline.
On Tue, Jun 13, 2017 at 5:58 PM, Tuukka Toivonen
wrote:
> Hi Tomasz,
>
> On Monday, June 12, 2017 18:59:18 Tomasz Figa wrote:
>> By any chance, doesn't the hardware provide some simple mode for
>> contiguous
Hi Tomasz,
On Monday, June 12, 2017 18:59:18 Tomasz Figa wrote:
> By any chance, doesn't the hardware provide some simple mode for
> contiguous buffers? Since we have an MMU anyway, we could use
> vb2_dma_contig and simplify the code significantly.
In IPU3 the CIO2 (CSI-2 receiver) and the IMGU
Hi Yong,
Please see my comments inline.
On Wed, Jun 7, 2017 at 10:34 AM, Yong Zhi wrote:
> This patch adds CIO2 CSI-2 device driver for
> Intel's IPU3 camera sub-system support.
>
> Signed-off-by: Yong Zhi
> ---
> drivers/media/pci/Kconfig
This patch adds CIO2 CSI-2 device driver for
Intel's IPU3 camera sub-system support.
Signed-off-by: Yong Zhi
---
drivers/media/pci/Kconfig|2 +
drivers/media/pci/Makefile |3 +-
drivers/media/pci/intel/Makefile |5 +
13 matches
Mail list logo