Re: [PATCH v2 4/5] media: ov5640: fix auto controls values when switching to manual mode

2018-09-10 Thread Laurent Pinchart
Hi Hugues, (Hans, there's a question for you below) On Monday, 10 September 2018 17:43:27 EEST Hugues FRUCHET wrote: > On 09/10/2018 12:46 PM, Laurent Pinchart wrote: > > On Monday, 10 September 2018 13:23:41 EEST Hugues FRUCHET wrote: > >> On 09/06/2018 03:31 PM, Laurent Pinchart wrote: > >>>

Re: [PATCH v2 4/5] media: ov5640: fix auto controls values when switching to manual mode

2018-09-10 Thread Hugues FRUCHET
Hi Laurent, On 09/10/2018 12:46 PM, Laurent Pinchart wrote: > Hi Hugues, > > On Monday, 10 September 2018 13:23:41 EEST Hugues FRUCHET wrote: >> On 09/06/2018 03:31 PM, Laurent Pinchart wrote: >>> On Monday, 13 August 2018 13:19:45 EEST Hugues Fruchet wrote: >>> When switching from auto to

Re: [PATCH v2 4/5] media: ov5640: fix auto controls values when switching to manual mode

2018-09-10 Thread Laurent Pinchart
Hi Hugues, On Monday, 10 September 2018 13:23:41 EEST Hugues FRUCHET wrote: > On 09/06/2018 03:31 PM, Laurent Pinchart wrote: > > On Monday, 13 August 2018 13:19:45 EEST Hugues Fruchet wrote: > > > >> When switching from auto to manual mode, V4L2 core is calling > >> g_volatile_ctrl() in manual

Re: [PATCH v2 4/5] media: ov5640: fix auto controls values when switching to manual mode

2018-09-10 Thread Hugues FRUCHET
Hi Laurent, On 09/06/2018 03:31 PM, Laurent Pinchart wrote: > Hi Hugues, > > Thank you for the patch. > > On Monday, 13 August 2018 13:19:45 EEST Hugues Fruchet wrote: >> When switching from auto to manual mode, V4L2 core is calling >> g_volatile_ctrl() in manual mode in order to get the manual

Re: [PATCH v2 4/5] media: ov5640: fix auto controls values when switching to manual mode

2018-09-06 Thread Laurent Pinchart
Hi Hugues, Thank you for the patch. On Monday, 13 August 2018 13:19:45 EEST Hugues Fruchet wrote: > When switching from auto to manual mode, V4L2 core is calling > g_volatile_ctrl() in manual mode in order to get the manual initial value. > Remove the manual mode check/return to not break this

[PATCH v2 4/5] media: ov5640: fix auto controls values when switching to manual mode

2018-08-13 Thread Hugues Fruchet
When switching from auto to manual mode, V4L2 core is calling g_volatile_ctrl() in manual mode in order to get the manual initial value. Remove the manual mode check/return to not break this behaviour. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/ov5640.c | 4 1 file changed, 4