Re: [PATCH v3 10/11] media: vsp1: Support Interlaced display pipelines

2018-05-24 Thread Laurent Pinchart
Hi Kieran, On Thursday, 3 May 2018 16:45:30 EEST Kieran Bingham wrote: > On 03/05/18 12:13, Laurent Pinchart wrote: [snip] > >>> diff --git a/drivers/media/platform/vsp1/vsp1_rwpf.h > >>> b/drivers/media/platform/vsp1/vsp1_rwpf.h index > >>> 70742ecf766f..8d6e42f27908 100644 > >>> ---

Re: [PATCH v3 10/11] media: vsp1: Support Interlaced display pipelines

2018-05-03 Thread Kieran Bingham
Hi Laurent, On 03/05/18 12:13, Laurent Pinchart wrote: > Hi Kieran, >>> + } else { >>> + vsp1_rpf_write(rpf, dlb, VI6_RPF_SRCM_ADDR_Y, mem.addr[0]); >>> + vsp1_rpf_write(rpf, dlb, VI6_RPF_SRCM_ADDR_C0, mem.addr[1]); >>> + vsp1_rpf_write(rpf, dlb,

Re: [PATCH v3 10/11] media: vsp1: Support Interlaced display pipelines

2018-05-03 Thread Laurent Pinchart
Hi Kieran, On Thursday, 3 May 2018 12:04:30 EEST Kieran Bingham wrote: > Hi Reviewers ... > > Comments inline ... > > On 03/05/18 09:44, Kieran Bingham wrote: > > Calculate the top and bottom fields for the interlaced frames and > > utilise the extended display list command feature to implement

Re: [PATCH v3 10/11] media: vsp1: Support Interlaced display pipelines

2018-05-03 Thread Kieran Bingham
Hi Reviewers ... Comments inline ... On 03/05/18 09:44, Kieran Bingham wrote: > Calculate the top and bottom fields for the interlaced frames and > utilise the extended display list command feature to implement the > auto-field operations. This allows the DU to update the VSP2 registers >

[PATCH v3 10/11] media: vsp1: Support Interlaced display pipelines

2018-05-03 Thread Kieran Bingham
Calculate the top and bottom fields for the interlaced frames and utilise the extended display list command feature to implement the auto-field operations. This allows the DU to update the VSP2 registers dynamically based upon the currently processing field. Signed-off-by: Kieran Bingham