Re: [PATCH v4 02/11] media: vsp1: Remove packed attributes from aligned structures

2018-05-24 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Thursday, 3 May 2018 16:36:13 EEST Kieran Bingham wrote: > The use of the packed attribute can cause a performance penalty for > all accesses to the struct members, as the compiler will assume that the > structure has the potential to have an unaligned

[PATCH v4 02/11] media: vsp1: Remove packed attributes from aligned structures

2018-05-03 Thread Kieran Bingham
The use of the packed attribute can cause a performance penalty for all accesses to the struct members, as the compiler will assume that the structure has the potential to have an unaligned base. These structures are all correctly aligned and contain no holes, thus the attribute is redundant and