Re: [PATCH v6 4/9] media: venus: adding core part and helper functions

2017-02-08 Thread Stanimir Varbanov
Bjorn, thanks for the comments! On 02/08/2017 01:32 AM, Bjorn Andersson wrote: > On Tue 07 Feb 05:10 PST 2017, Stanimir Varbanov wrote: > >> * firmware loader >> > > I like the way this turns out, just some style comments below. > > [..] >> diff --git

Re: [PATCH v6 4/9] media: venus: adding core part and helper functions

2017-02-07 Thread Bjorn Andersson
On Tue 07 Feb 05:10 PST 2017, Stanimir Varbanov wrote: > * firmware loader > I like the way this turns out, just some style comments below. [..] > diff --git a/drivers/media/platform/qcom/venus/firmware.c > b/drivers/media/platform/qcom/venus/firmware.c > new file mode 100644 > index

[PATCH v6 4/9] media: venus: adding core part and helper functions

2017-02-07 Thread Stanimir Varbanov
* core.c has implemented the platform dirver methods, file operations and v4l2 registration. * helpers.c has implemented common helper functions for: - buffer management - vb2_ops and functions for format propagation, - functions for allocating and freeing buffers for internal