Re: [PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-29 Thread Sakari Ailus
Hi Hans, On Wed, Mar 29, 2017 at 09:49:05AM +0200, Hans Verkuil wrote: > On 28/03/17 22:37, Sakari Ailus wrote: > > Hi Mauro, > > > > On Tue, Mar 28, 2017 at 08:38:26AM -0300, Mauro Carvalho Chehab wrote: > >> Em Tue, 28 Mar 2017 12:00:36 +0200 > >> Hans Verkuil escreveu: >

Re: [PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-29 Thread Hans Verkuil
On 29/03/17 00:35, Nicolas Dufresne wrote: > > > Le 28 mars 2017 4:38 PM, "Sakari Ailus" > a écrit : > > Hi Mauro, > > On Tue, Mar 28, 2017 at 08:38:26AM -0300, Mauro Carvalho Chehab wrote: > > Em Tue, 28 Mar 2017 12:00:36 +0200 >

Re: [PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-29 Thread Hans Verkuil
On 28/03/17 22:37, Sakari Ailus wrote: > Hi Mauro, > > On Tue, Mar 28, 2017 at 08:38:26AM -0300, Mauro Carvalho Chehab wrote: >> Em Tue, 28 Mar 2017 12:00:36 +0200 >> Hans Verkuil escreveu: >> >>> On 27/03/17 20:09, Mauro Carvalho Chehab wrote: Em Mon, 27 Mar 2017

Re: [PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-29 Thread Hans Verkuil
On 28/03/17 16:23, Sakari Ailus wrote: > Hi Hans, > > On Tue, Mar 28, 2017 at 12:00:36PM +0200, Hans Verkuil wrote: >> On 27/03/17 20:09, Mauro Carvalho Chehab wrote: >>> Em Mon, 27 Mar 2017 12:19:51 -0300 >>> Helen Koike escreveu: >>> Hi Sakari, On

Re: [PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-28 Thread Sakari Ailus
Hi Mauro, On Tue, Mar 28, 2017 at 12:25:50PM -0300, Mauro Carvalho Chehab wrote: ... > The (very few) of non-MC app that doesn't fail if without those ioctl > will keep running. > > The only difference on implementing it is that other non-MC > applications will start to run if the driver passes

Re: [PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-28 Thread Sakari Ailus
Hi Mauro, On Tue, Mar 28, 2017 at 08:38:26AM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 28 Mar 2017 12:00:36 +0200 > Hans Verkuil escreveu: > > > On 27/03/17 20:09, Mauro Carvalho Chehab wrote: > > > Em Mon, 27 Mar 2017 12:19:51 -0300 > > > Helen Koike

Re: [PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-28 Thread Mauro Carvalho Chehab
Em Tue, 28 Mar 2017 17:23:40 +0300 Sakari Ailus escreveu: > Hi Hans, > > On Tue, Mar 28, 2017 at 12:00:36PM +0200, Hans Verkuil wrote: > > On 27/03/17 20:09, Mauro Carvalho Chehab wrote: > > > Em Mon, 27 Mar 2017 12:19:51 -0300 > > > Helen Koike

Re: [PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-28 Thread Sakari Ailus
Hi Hans, On Tue, Mar 28, 2017 at 12:00:36PM +0200, Hans Verkuil wrote: > On 27/03/17 20:09, Mauro Carvalho Chehab wrote: > > Em Mon, 27 Mar 2017 12:19:51 -0300 > > Helen Koike escreveu: > > > >> Hi Sakari, > >> > >> On 2017-03-26 10:31 AM, Sakari Ailus wrote: > >>>

Re: [PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-28 Thread Mauro Carvalho Chehab
Em Tue, 28 Mar 2017 12:00:36 +0200 Hans Verkuil escreveu: > On 27/03/17 20:09, Mauro Carvalho Chehab wrote: > > Em Mon, 27 Mar 2017 12:19:51 -0300 > > Helen Koike escreveu: > > > >> Hi Sakari, > >> > >> On 2017-03-26 10:31 AM, Sakari Ailus

Re: [PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-28 Thread Hans Verkuil
On 27/03/17 20:09, Mauro Carvalho Chehab wrote: > Em Mon, 27 Mar 2017 12:19:51 -0300 > Helen Koike escreveu: > >> Hi Sakari, >> >> On 2017-03-26 10:31 AM, Sakari Ailus wrote: >>> Hi Helen, >>> >>> ... +static int vimc_cap_enum_input(struct file *file, void

Re: [PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-27 Thread Mauro Carvalho Chehab
Em Mon, 27 Mar 2017 12:19:51 -0300 Helen Koike escreveu: > Hi Sakari, > > On 2017-03-26 10:31 AM, Sakari Ailus wrote: > > Hi Helen, > > > > ... > >> +static int vimc_cap_enum_input(struct file *file, void *priv, > >> + struct v4l2_input *i)

Re: [PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-27 Thread Helen Koike
Hi Sakari, On 2017-03-26 10:31 AM, Sakari Ailus wrote: Hi Helen, ... +static int vimc_cap_enum_input(struct file *file, void *priv, + struct v4l2_input *i) +{ + /* We only have one input */ + if (i->index > 0) + return -EINVAL; + +

Re: [PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-27 Thread Sakari Ailus
Hi Helen, ... > +static int vimc_cap_enum_input(struct file *file, void *priv, > +struct v4l2_input *i) > +{ > + /* We only have one input */ > + if (i->index > 0) > + return -EINVAL; > + > + i->type = V4L2_INPUT_TYPE_CAMERA; > +

Re: [PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-27 Thread Hans Verkuil
Two small comments: On 25/03/17 18:11, Helen Koike wrote: > First version of the Virtual Media Controller. > Add a simple version of the core of the driver, the capture and > sensor nodes in the topology, generating a grey image in a hardcoded > format. > > Signed-off-by: Helen Koike

Re: [PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-25 Thread Helen Koike
On 2017-03-25 02:11 PM, Helen Koike wrote: First version of the Virtual Media Controller. Add a simple version of the core of the driver, the capture and sensor nodes in the topology, generating a grey image in a hardcoded format. Signed-off-by: Helen Koike ---

[PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-25 Thread Helen Koike
First version of the Virtual Media Controller. Add a simple version of the core of the driver, the capture and sensor nodes in the topology, generating a grey image in a hardcoded format. Signed-off-by: Helen Koike --- Patch based in media/master tree, and available