Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

2017-03-27 Thread Nicolas Dufresne
Le lundi 27 mars 2017 à 10:45 +0200, Hans Verkuil a écrit : > > > timestamp and sequence are only set for CAPTURE, not OUTPUT. Is > > > that correct? > > > > Correct. I can add sequence for the OUTPUT queue too, but I have no > > idea how that sequence is used by userspace. > > You set

Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

2017-03-27 Thread Stanimir Varbanov
Hi Hans, On 03/27/2017 11:45 AM, Hans Verkuil wrote: > On 25/03/17 23:30, Stanimir Varbanov wrote: >> Thanks for the comments! +static void vdec_buf_done(struct venus_inst *inst, unsigned int buf_type, + u32 tag, u32 bytesused, u32 data_offset, u32 flags, +

Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

2017-03-27 Thread Hans Verkuil
On 27/03/17 04:18, Nicolas Dufresne wrote: > Le dimanche 26 mars 2017 à 00:30 +0200, Stanimir Varbanov a écrit : +vb->planes[0].data_offset = data_offset; +vb->timestamp = timestamp_us * NSEC_PER_USEC; +vbuf->sequence = inst->sequence++; >>> >>>

Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

2017-03-27 Thread Hans Verkuil
On 25/03/17 23:30, Stanimir Varbanov wrote: > Thanks for the comments! > > On 03/24/2017 04:41 PM, Hans Verkuil wrote: >> Some comments and questions below: >> >> On 03/13/17 17:37, Stanimir Varbanov wrote: >>> This consists of video decoder implementation plus decoder >>> controls. >>> >>>

Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

2017-03-27 Thread Hans Verkuil
On 25/03/17 23:30, Stanimir Varbanov wrote: > Thanks for the comments! > > On 03/24/2017 04:41 PM, Hans Verkuil wrote: >> Some comments and questions below: >> >> On 03/13/17 17:37, Stanimir Varbanov wrote: >>> This consists of video decoder implementation plus decoder >>> controls. >>> >>>

Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

2017-03-26 Thread Nicolas Dufresne
Le dimanche 26 mars 2017 à 00:30 +0200, Stanimir Varbanov a écrit : > > > +vb->planes[0].data_offset = data_offset; > > > +vb->timestamp = timestamp_us * NSEC_PER_USEC; > > > +vbuf->sequence = inst->sequence++; > > > > timestamp and sequence are only set for

Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

2017-03-25 Thread Stanimir Varbanov
Hi, On 24.03.2017 20:21, Nicolas Dufresne wrote: Le vendredi 24 mars 2017 à 15:41 +0100, Hans Verkuil a écrit : +static const struct venus_format vdec_formats[] = { + { + .pixfmt = V4L2_PIX_FMT_NV12, + .num_planes = 1, + .type =

Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

2017-03-25 Thread Stanimir Varbanov
Thanks for the comments! On 03/24/2017 04:41 PM, Hans Verkuil wrote: Some comments and questions below: On 03/13/17 17:37, Stanimir Varbanov wrote: This consists of video decoder implementation plus decoder controls. Signed-off-by: Stanimir Varbanov ---

Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

2017-03-24 Thread Nicolas Dufresne
Le vendredi 24 mars 2017 à 15:41 +0100, Hans Verkuil a écrit : > > +static const struct venus_format vdec_formats[] = { > > + { > > + .pixfmt = V4L2_PIX_FMT_NV12, > > + .num_planes = 1, > > + .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, > > Just curious: is

Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

2017-03-24 Thread Hans Verkuil
Some comments and questions below: On 03/13/17 17:37, Stanimir Varbanov wrote: > This consists of video decoder implementation plus decoder > controls. > > Signed-off-by: Stanimir Varbanov > --- > drivers/media/platform/qcom/venus/vdec.c | 1091 >

[PATCH v7 5/9] media: venus: vdec: add video decoder files

2017-03-13 Thread Stanimir Varbanov
This consists of video decoder implementation plus decoder controls. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/vdec.c | 1091 drivers/media/platform/qcom/venus/vdec.h | 23 +