Re: [REVIEW PATCH 03/11] vb2: if bytesused is 0, then fill with output buffer length

2014-04-07 Thread Pawel Osciak
I'm thinking, that if we are doing this, perhaps we should just update the API to allow this case, i.e. say that if the bytesused is not set for any planes, length will be used by default? This would be backwards-compatible. On Tue, Mar 11, 2014 at 6:20 AM, Hans Verkuil hverk...@xs4all.nl wrote:

Re: [REVIEW PATCH 03/11] vb2: if bytesused is 0, then fill with output buffer length

2014-04-07 Thread Hans Verkuil
On 04/07/2014 09:20 AM, Pawel Osciak wrote: I'm thinking, that if we are doing this, perhaps we should just update the API to allow this case, i.e. say that if the bytesused is not set With 'not set' you mean 'is 0', right? for any planes, length will be used by default? This would be

Re: [REVIEW PATCH 03/11] vb2: if bytesused is 0, then fill with output buffer length

2014-04-07 Thread Pawel Osciak
On Mon, Apr 7, 2014 at 4:39 PM, Hans Verkuil hverk...@xs4all.nl wrote: On 04/07/2014 09:20 AM, Pawel Osciak wrote: I'm thinking, that if we are doing this, perhaps we should just update the API to allow this case, i.e. say that if the bytesused is not set With 'not set' you mean 'is 0',

[REVIEW PATCH 03/11] vb2: if bytesused is 0, then fill with output buffer length

2014-03-10 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com The application should really always fill in bytesused for output buffers, unfortunately the vb2 framework never checked for that. So for single planar formats replace a bytesused of 0 by the length of the buffer, and for multiplanar format do the same