Re: [RFC 3/5] video: panel: Add MIPI DBI bus support

2012-08-17 Thread Laurent Pinchart
Hi Tomi, Thank you for the review. On Friday 17 August 2012 12:03:02 Tomi Valkeinen wrote: On Fri, 2012-08-17 at 02:49 +0200, Laurent Pinchart wrote: +/* - + * Bus operations + */ + +void

Re: [RFC 3/5] video: panel: Add MIPI DBI bus support

2012-08-17 Thread Tomi Valkeinen
On Fri, 2012-08-17 at 12:02 +0200, Laurent Pinchart wrote: Hi Tomi, Thank you for the review. On Friday 17 August 2012 12:03:02 Tomi Valkeinen wrote: On Fri, 2012-08-17 at 02:49 +0200, Laurent Pinchart wrote: +/*

Re: [RFC 3/5] video: panel: Add MIPI DBI bus support

2012-08-17 Thread Laurent Pinchart
Hi Tomi, On Friday 17 August 2012 13:51:49 Tomi Valkeinen wrote: On Fri, 2012-08-17 at 12:02 +0200, Laurent Pinchart wrote: On Friday 17 August 2012 12:03:02 Tomi Valkeinen wrote: On Fri, 2012-08-17 at 02:49 +0200, Laurent Pinchart wrote: +/*

Re: [RFC 3/5] video: panel: Add MIPI DBI bus support

2012-08-17 Thread Tomi Valkeinen
On Fri, 2012-08-17 at 14:33 +0200, Laurent Pinchart wrote: But first, the data type should be byte, not unsigned long. How would you write 8 bits or 16 bits with your API? u8 and u16 both fit in an unsigned long :-) Please see below. Ah, I see, so the driver would just discard 24 bits or

Re: [RFC 3/5] video: panel: Add MIPI DBI bus support

2012-08-17 Thread Laurent Pinchart
Hi Tomi, On Friday 17 August 2012 16:06:30 Tomi Valkeinen wrote: On Fri, 2012-08-17 at 14:33 +0200, Laurent Pinchart wrote: But first, the data type should be byte, not unsigned long. How would you write 8 bits or 16 bits with your API? u8 and u16 both fit in an unsigned long :-)

[RFC 3/5] video: panel: Add MIPI DBI bus support

2012-08-16 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/video/panel/Kconfig |4 + drivers/video/panel/Makefile|1 + drivers/video/panel/panel-dbi.c | 217 +++ include/video/panel-dbi.h | 92 + 4