Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

Hi Sakari, >> >> Finding and matching the parent of the SD would allow a driver to register a >> notifier ASD with a dev node, and expect to match a subdevice that has >> registered it's subdev with an EP node. This would erroneously allow drivers >> to >> register a notifier that would match

Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

Hi Kieran, On Thu, May 18, 2017 at 01:04:55PM +0100, Kieran Bingham wrote: > Hi Sakari, > > >>> In omap3isp/isp.c: isp_fwnodes_parse() the async notifier is registered > >>> looking > >>> at the endpoints parent fwnode: > >>> > >>> isd->asd.match.fwnode.fwnode = > >>>

Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

Hi Sakari, >>> In omap3isp/isp.c: isp_fwnodes_parse() the async notifier is registered >>> looking >>> at the endpoints parent fwnode: >>> >>> isd->asd.match.fwnode.fwnode = >>> fwnode_graph_get_remote_port_parent(fwnode); >>> >>> This would therefore not support

Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

Hi Sakari, Ok - V3 is now closer :) I'm just trying to do a first spin of adding fwnode_graph_get_port_parent(), then I can post a v3 series. On 16/05/17 23:26, Sakari Ailus wrote: > Hi Kieran, > > On Tue, May 16, 2017 at 01:56:05PM +0100, Kieran Bingham wrote: > ... >> +static int

Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

Hi Kieran, On Tue, May 16, 2017 at 01:56:05PM +0100, Kieran Bingham wrote: ... > +static int adv748x_afe_g_input_status(struct v4l2_subdev *sd, u32 > *status) > +{ > +struct adv748x_state *state = adv748x_afe_to_state(sd); > +int ret; > + > +

Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

Hi Sakari, (Gianluca, I've pulled you in on CC in respect to discussing changes you implemented for supporting GCC < 4.4.6) On 16/05/17 12:54, Sakari Ailus wrote: > Hi Kieran, > > On Mon, May 15, 2017 at 01:32:41PM +0100, Kieran Bingham wrote: >> Hi Sakari >> >> On 12/05/17 17:46, Sakari Ailus

Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

Hi Kieran, On Mon, May 15, 2017 at 01:32:41PM +0100, Kieran Bingham wrote: > Hi Sakari > > On 12/05/17 17:46, Sakari Ailus wrote: > > Hi Kieran, > > > > Thanks for the patches! > > Thankyou for the review! You're welcome! :-) > > > Would you have a media-ctl -p && media-ctl --print-dot (or

Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

Hi Sakari On 12/05/17 17:46, Sakari Ailus wrote: > Hi Kieran, > > Thanks for the patches! Thankyou for the review! > Would you have a media-ctl -p && media-ctl --print-dot (or the PS file) to > see how this looks like in practice? The file I linked to on Friday showed the immutable links

Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

Hi Sakari, On 12/05/17 17:46, Sakari Ailus wrote: > Hi Kieran, > > Thanks for the patches! > > Would you have a media-ctl -p && media-ctl --print-dot (or the PS file) to > see how this looks like in practice? Replying quickly to only this question for the moment :) Please see:

Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

Hi Kieran, Thanks for the patches! Would you have a media-ctl -p && media-ctl --print-dot (or the PS file) to see how this looks like in practice? Please see my comments below. On Thu, May 11, 2017 at 06:21:20PM +0100, Kieran Bingham wrote: > From: Kieran Bingham

[RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

From: Kieran Bingham Provide basic support for the ADV7481 and ADV7482. The driver is modelled with 2 subdevices to allow simultaneous streaming from the AFE (Analog front end) and HDMI inputs. Presently the HDMI is hardcoded to link to the TXA CSI bus,