Re: [RFCv2 PATCH 01/10] vb2: add debugging code to check for unbalanced ops.

2014-02-13 Thread Pawel Osciak
Hi Hans, Thanks for the patch. I'm really happy to see this, it's a great idea and it will be very useful. Two comments: - What do you think about moving the debug stuff to something like videobuf2-debug.{c,h} instead? - At this point vb2_buffer_done() shouldn't be required to be balanced with

[RFCv2 PATCH 01/10] vb2: add debugging code to check for unbalanced ops.

2014-02-06 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com When a vb2_queue is freed check if all the mem_ops and queue ops were balanced. So the number of calls to e.g. buf_finish has to match the number of calls to buf_prepare, etc. This code is only enabled if CONFIG_VIDEO_ADV_DEBUG is set. Signed-off-by: