Re: [RFCv2 PATCH 03/14] vb2-dma-sg: add prepare/finish memops

2014-09-13 Thread Pawel Osciak
Hi Hans, Thank you for working on this. On Fri, Sep 12, 2014 at 8:59 PM, Hans Verkuil hverk...@xs4all.nl wrote: From: Hans Verkuil hans.verk...@cisco.com This moves dma_(un)map_sg to the prepare/finish memops of videobuf2-dma-sg.c. I agree with Laurent. dma_map and unmap should be done when

[RFCv2 PATCH 03/14] vb2-dma-sg: add prepare/finish memops

2014-09-12 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com This moves dma_(un)map_sg to the prepare/finish memops of videobuf2-dma-sg.c. Now that vb2-dma-sg will sync the buffers for you in the prepare/finish memops we can drop that from the drivers that use dma-sg. For the solo6x10 driver that was a bit more

Re: [RFCv2 PATCH 03/14] vb2-dma-sg: add prepare/finish memops

2014-09-12 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Friday 12 September 2014 14:59:52 Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com This moves dma_(un)map_sg to the prepare/finish memops of videobuf2-dma-sg.c. Now that vb2-dma-sg will sync the buffers for you in the prepare/finish