Re: [RFCv3 PATCH 05/10] vb2: fix buf_init/buf_cleanup call sequences

2014-02-14 Thread Hans Verkuil
Hi Pawel, Thanks for the review! On 02/14/2014 05:40 AM, Pawel Osciak wrote: On Thu, Feb 13, 2014 at 6:40 PM, Hans Verkuil hverk...@xs4all.nl wrote: From: Hans Verkuil hans.verk...@cisco.com Ensure that these ops are properly balanced. There two scenarios: s/There two/There are two/

[RFCv3 PATCH 05/10] vb2: fix buf_init/buf_cleanup call sequences

2014-02-13 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Ensure that these ops are properly balanced. There two scenarios: 1) for MMAP buf_init is called when the buffers are created and buf_cleanup must be called when the queue is finally freed. This scenario was always working. 2) for USERPTR and

Re: [RFCv3 PATCH 05/10] vb2: fix buf_init/buf_cleanup call sequences

2014-02-13 Thread Pawel Osciak
On Thu, Feb 13, 2014 at 6:40 PM, Hans Verkuil hverk...@xs4all.nl wrote: From: Hans Verkuil hans.verk...@cisco.com Ensure that these ops are properly balanced. There two scenarios: s/There two/There are two/ 1) for MMAP buf_init is called when the buffers are created and buf_cleanup