Re: Any reason why media_entity_pads_init() isn't void?

Em Mon, 14 Mar 2016 10:05:01 -0300 Mauro Carvalho Chehab escreveu: > Em Mon, 14 Mar 2016 08:52:51 -0300 > Mauro Carvalho Chehab escreveu: > > > Em Mon, 14 Mar 2016 13:43:33 +0200 > > Sakari Ailus escreveu: > > > > > Hi

Re: Any reason why media_entity_pads_init() isn't void?

Em Mon, 14 Mar 2016 08:52:51 -0300 Mauro Carvalho Chehab escreveu: > Em Mon, 14 Mar 2016 13:43:33 +0200 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > On Mon, Mar 14, 2016 at 08:27:38AM -0300, Mauro Carvalho Chehab wrote: > > > Em Mon, 14 Mar

Re: Any reason why media_entity_pads_init() isn't void?

Em Mon, 14 Mar 2016 13:43:33 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Mon, Mar 14, 2016 at 08:27:38AM -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 14 Mar 2016 12:36:44 +0200 > > Sakari Ailus escreveu: > > > > > Hi Hans, > > > > > > On

Re: Any reason why media_entity_pads_init() isn't void?

Hi Mauro, On Mon, Mar 14, 2016 at 08:27:38AM -0300, Mauro Carvalho Chehab wrote: > Em Mon, 14 Mar 2016 12:36:44 +0200 > Sakari Ailus escreveu: > > > Hi Hans, > > > > On Mon, Mar 14, 2016 at 09:25:51AM +0100, Hans Verkuil wrote: > > > I was fixing a sparse warning in

Re: Any reason why media_entity_pads_init() isn't void?

Em Mon, 14 Mar 2016 12:36:44 +0200 Sakari Ailus escreveu: > Hi Hans, > > On Mon, Mar 14, 2016 at 09:25:51AM +0100, Hans Verkuil wrote: > > I was fixing a sparse warning in media_entity_pads_init() and I noticed > > that that function always returns 0. Any reason why this

Re: Any reason why media_entity_pads_init() isn't void?

Hi Hans, On Mon, Mar 14, 2016 at 09:25:51AM +0100, Hans Verkuil wrote: > I was fixing a sparse warning in media_entity_pads_init() and I noticed > that that function always returns 0. Any reason why this can't be changed > to a void function? I was thinking of the same function but I had a

Re: Any reason why media_entity_pads_init() isn't void?

Em Mon, 14 Mar 2016 09:25:51 +0100 Hans Verkuil escreveu: > I was fixing a sparse warning in media_entity_pads_init() and I noticed that > that > function always returns 0. Any reason why this can't be changed to a void > function? > > That return value is checked a

Any reason why media_entity_pads_init() isn't void?

I was fixing a sparse warning in media_entity_pads_init() and I noticed that that function always returns 0. Any reason why this can't be changed to a void function? That return value is checked a zillion times in the media code. By making it void it should simplify code all over. See e.g.