RE: [PATCH - v2 4/6] V4L - vpfe_capture - bug fixes and enhancements

2009-12-29 Thread Karicheri, Muralidharan
...@linux.davincidsp.com Subject: RE: [PATCH - v2 4/6] V4L - vpfe_capture - bug fixes and enhancements Hans, The change is because of the void * type that we use. Since ccdc parameter structures are different for different IPs, a constant type for this arg is not possible. The ccdc driver needs

Re: [PATCH - v2 4/6] V4L - vpfe_capture - bug fixes and enhancements

2009-12-23 Thread Hans Verkuil
Hi Murali, Sorry for the long delay in reviewing this patch series. I've been very busy, first at work, and now for Christmas preparations (and occasionally I'd like to relax as well :-) ). I'm OK with the other patches in this series, but I do have a few comments on this one: I noticed that you

RE: [PATCH - v2 4/6] V4L - vpfe_capture - bug fixes and enhancements

2009-12-23 Thread Karicheri, Muralidharan
, 2009 9:24 AM To: Karicheri, Muralidharan Cc: linux-media@vger.kernel.org; khil...@deeprootsystems.com; Hiremath, Vaibhav; Nori, Sekhar; davinci-linux-open-sou...@linux.davincidsp.com Subject: Re: [PATCH - v2 4/6] V4L - vpfe_capture - bug fixes and enhancements Hi Murali, Sorry for the long delay