Re: [PATCH 10/15] [media] marvell-ccic: split mcam core into 2 parts for soc_camera support

2012-11-27 Thread Guennadi Liakhovetski
On Fri, 23 Nov 2012, Albert Wang wrote: This patch splits mcam core into 2 parts to prepare for soc_camera support. The first part remains in mcam-core. This part includes the HW operations and vb2 callback functions. The second part is moved to mcam-core-standard.c. This part is relevant

RE: [PATCH 10/15] [media] marvell-ccic: split mcam core into 2 parts for soc_camera support

2012-11-27 Thread Albert Wang
Hi, Guennadi -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Tuesday, 27 November, 2012 22:13 To: Albert Wang Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang Subject: Re: [PATCH 10/15] [media] marvell-ccic: split mcam core into 2 parts

RE: [PATCH 10/15] [media] marvell-ccic: split mcam core into 2 parts for soc_camera support

2012-11-27 Thread Guennadi Liakhovetski
On Tue, 27 Nov 2012, Albert Wang wrote: [snip] you did change a couple of things - like replaced printk() with cam_err(), and actually here: + cam_err(cam, marvell-cam: Cafe can't do S/G I/O, \ + attempting vmalloc mode instead\n); and here +

RE: [PATCH 10/15] [media] marvell-ccic: split mcam core into 2 parts for soc_camera support

2012-11-27 Thread Albert Wang
Hi, Guennadi -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Wednesday, 28 November, 2012 00:39 To: Albert Wang Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang Subject: RE: [PATCH 10/15] [media] marvell-ccic: split mcam core into 2 parts