Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-09 Thread Laurent Pinchart
Hi Mauro, On Thursday 08 July 2010 15:51:33 Mauro Carvalho Chehab wrote: Em 08-07-2010 09:08, Laurent Pinchart escreveu: On Wednesday 07 July 2010 22:53:40 Mauro Carvalho Chehab wrote: Em 07-07-2010 16:44, Laurent Pinchart escreveu: On Wednesday 07 July 2010 16:58:01 Mauro Carvalho Chehab

RE: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-08 Thread Pawel Osciak
Hi, v4l2_device *v4l2_dev, if (err err != -ENOIOCTLCMD) { v4l2_device_unregister_subdev(sd); sd = NULL; + } else { + sd-initialized = 1; } Wouldn't checkpatch.pl script complain about { } on

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-08 Thread Laurent Pinchart
Hi Hans, On Wednesday 07 July 2010 15:04:17 Hans Verkuil wrote: On Wednesday 07 July 2010 14:30:45 Hans Verkuil wrote: [snip] Some (most ?) I2C sensors need to be accessed during probe. This involves powering the sensor up, which is handled by a board code function called through a

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-08 Thread Laurent Pinchart
Hi Mauro, On Wednesday 07 July 2010 22:53:40 Mauro Carvalho Chehab wrote: Em 07-07-2010 16:44, Laurent Pinchart escreveu: On Wednesday 07 July 2010 16:58:01 Mauro Carvalho Chehab wrote: Em 07-07-2010 08:53, Laurent Pinchart escreveu: Create a device node named subdevX for every registered

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-08 Thread Hans Verkuil
Hi Hans, On Wednesday 07 July 2010 15:04:17 Hans Verkuil wrote: On Wednesday 07 July 2010 14:30:45 Hans Verkuil wrote: [snip] Some (most ?) I2C sensors need to be accessed during probe. This involves powering the sensor up, which is handled by a board code function called through

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-08 Thread Mauro Carvalho Chehab
Em 08-07-2010 09:08, Laurent Pinchart escreveu: Hi Mauro, On Wednesday 07 July 2010 22:53:40 Mauro Carvalho Chehab wrote: Em 07-07-2010 16:44, Laurent Pinchart escreveu: On Wednesday 07 July 2010 16:58:01 Mauro Carvalho Chehab wrote: Em 07-07-2010 08:53, Laurent Pinchart escreveu: Create a

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Hans Verkuil
Create a device node named subdevX for every registered subdev. As the device node is registered before the subdev core::s_config function is called, return -EGAIN on open until initialization completes. The only reason we have s_config is for old i2c drivers that need to be supported in

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Hans Verkuil
Create a device node named subdevX for every registered subdev. As the device node is registered before the subdev core::s_config function is called, return -EGAIN on open until initialization completes. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by:

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Laurent Pinchart
Hi Hans, Thanks for the quick review. On Wednesday 07 July 2010 14:30:45 Hans Verkuil wrote: Create a device node named subdevX for every registered subdev. As the device node is registered before the subdev core::s_config function is called, return -EGAIN on open until initialization

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Hans Verkuil
Hi Hans, Thanks for the quick review. On Wednesday 07 July 2010 14:30:45 Hans Verkuil wrote: Create a device node named subdevX for every registered subdev. As the device node is registered before the subdev core::s_config function is called, return -EGAIN on open until

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Laurent Pinchart
Hi Hans, On Wednesday 07 July 2010 14:43:08 Hans Verkuil wrote: Create a device node named subdevX for every registered subdev. As the device node is registered before the subdev core::s_config function is called, return -EGAIN on open until initialization completes. [snip] I'm

RE: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Karicheri, Muralidharan
v4l2_device *v4l2_dev, if (err err != -ENOIOCTLCMD) { v4l2_device_unregister_subdev(sd); sd = NULL; + } else { + sd-initialized = 1; } Wouldn't checkpatch.pl script complain about { }

RE: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Sylwester Nawrocki
: Wednesday, July 07, 2010 4:15 PM To: Laurent Pinchart; linux-media@vger.kernel.org Cc: sakari.ai...@maxwell.research.nokia.com Subject: RE: [RFC/PATCH 2/6] v4l: subdev: Add device node support v4l2_device *v4l2_dev, if (err err != -ENOIOCTLCMD

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Mauro Carvalho Chehab
Em 07-07-2010 08:53, Laurent Pinchart escreveu: Create a device node named subdevX for every registered subdev. As the device node is registered before the subdev core::s_config function is called, return -EGAIN on open until initialization completes. Signed-off-by: Laurent Pinchart

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Mauro Carvalho Chehab
Em 07-07-2010 11:14, Karicheri, Muralidharan escreveu: v4l2_device *v4l2_dev, if (err err != -ENOIOCTLCMD) { v4l2_device_unregister_subdev(sd); sd = NULL; +} else { +sd-initialized = 1;

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Laurent Pinchart
Hi Mauro, Thanks for the review. On Wednesday 07 July 2010 16:58:01 Mauro Carvalho Chehab wrote: Em 07-07-2010 08:53, Laurent Pinchart escreveu: Create a device node named subdevX for every registered subdev. As the device node is registered before the subdev core::s_config function is

Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support

2010-07-07 Thread Mauro Carvalho Chehab
Em 07-07-2010 16:44, Laurent Pinchart escreveu: Hi Mauro, Thanks for the review. On Wednesday 07 July 2010 16:58:01 Mauro Carvalho Chehab wrote: Em 07-07-2010 08:53, Laurent Pinchart escreveu: Create a device node named subdevX for every registered subdev. As the device node is registered