Re: VIVID/VIMC and media fuzzing

2018-12-08 Thread Dmitry Vyukov
On Fri, Dec 7, 2018 at 8:22 PM Helen Koike wrote: > >>> You also mentioned that one of the devices requires some complex setup > >>> via configfs. Is this interface described somewhere? Do you think it's > >>> more profitable to pre-setup some fixed configuration for each test > >>> process? Or

Re: [PATCH 2/3] media: ov2640: make VIDIOC_SUBDEV_G_FMT ioctl work with V4L2_SUBDEV_FORMAT_TRY

2018-12-08 Thread kbuild test robot
Hi Akinobu, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.20-rc5 next-20181207] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCHv3 1/1] Add ir-rcmm-driver

2018-12-07 Thread kbuild test robot
Hi Patrick, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.20-rc5 next-20181207] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 1/2] media: pxa_camera: don't deferenciate a NULL pointer

2018-12-07 Thread Sakari Ailus
Hi Mauro, On Fri, Dec 07, 2018 at 08:07:54AM -0500, Mauro Carvalho Chehab wrote: > As warned by smatch: > drivers/media/platform/pxa_camera.c:2400 pxa_camera_probe() error: we > previously assumed 'pcdev->pdata' could be null (see line 2397) > > It would be possible that neither DT nor

Re: [PATCH v5 00/12] imx-media: Fixes for interlaced capture

2018-12-07 Thread Steve Longerbeam
Hi Hans, On 12/7/18 5:35 AM, Hans Verkuil wrote: Hi Steve, How to proceed with this w.r.t. the two gpu ipu patches? Are those going in first through the gpu tree? Or do they have to go in through our tree? There is only one remaining gpu ipu patch in this series that is awaiting an ack from

Re: VIVID/VIMC and media fuzzing

2018-12-07 Thread Helen Koike
Hi Dmitry, On 10/31/18 9:49 AM, Helen Koike wrote: > Hi Dmitry, > > On 10/31/18 7:46 AM, Hans Verkuil wrote: >> On 10/30/2018 03:02 PM, Dmitry Vyukov wrote: >>> Hello Helen and linux-media, >>> >>> I've attended your talk "Shifting Media App Development into High >>> Gear" on OSS Summit last

Re: [PATCH 2/2] media: drxk_hard: check if parameter is not NULL

2018-12-07 Thread Nick Desaulniers
On Fri, Dec 7, 2018 at 5:08 AM Mauro Carvalho Chehab wrote: > > There is a smatch warning: > drivers/media/dvb-frontends/drxk_hard.c: > drivers/media/dvb-frontends/drxk_hard.c:1478 scu_command() error: we > previously assumed 'parameter' could be null (see line 1467) > > Telling that

Re: [PATCH v2] [RFC v2] v4l2: add support for colorspace conversion for video capture

2018-12-07 Thread Hans Verkuil
On 12/07/2018 03:30 PM, Mauro Carvalho Chehab wrote: > Em Thu, 6 Sep 2018 11:02:28 +0200 > Hans Verkuil escreveu: > >> Hi Philipp, >> >> It is much appreciated that this old RFC of mine is picked up again. >> I always wanted to get this in, but I never had a driver where it would >> make sense

Re: [PATCH v2] [RFC v2] v4l2: add support for colorspace conversion for video capture

2018-12-07 Thread Mauro Carvalho Chehab
Em Thu, 6 Sep 2018 11:02:28 +0200 Hans Verkuil escreveu: > Hi Philipp, > > It is much appreciated that this old RFC of mine is picked up again. > I always wanted to get this in, but I never had a driver where it would > make sense to do so. What's the status of this? Hans, As this is an old

Re: [PATCH v9 00/13] media: staging/imx7: add i.MX7 media driver

2018-12-07 Thread Rui Miguel Silva
Hi Hans and Dan, On Fri 07 Dec 2018 at 13:38, Dan Carpenter wrote: On Fri, Dec 07, 2018 at 01:44:00PM +0100, Hans Verkuil wrote: CHECK: Alignment should match open parenthesis #936: FILE: drivers/staging/media/imx/imx7-mipi-csis.c:921: + ret = v4l2_async_register_fwnode_subdev(mipi_sd, +

Re: [RFC PATCH] media/Kconfig: always enable MEDIA_CONTROLLER and VIDEO_V4L2_SUBDEV_API

2018-12-07 Thread Mauro Carvalho Chehab
Em Fri, 7 Dec 2018 11:53:17 -0200 Mauro Carvalho Chehab escreveu: > Em Fri, 7 Dec 2018 14:27:48 +0100 > Hans Verkuil escreveu: > > > On 12/07/2018 01:42 PM, Mauro Carvalho Chehab wrote: > > > Em Fri, 7 Dec 2018 12:47:24 +0100 > > > Hans Verkuil escreveu: > > > > > >> On 12/07/2018 12:26

Re: [PATCH v9 05/13] media: dt-bindings: add bindings for i.MX7 media driver

2018-12-07 Thread Rui Miguel Silva
Hi Hans, On Fri 07 Dec 2018 at 12:39, Hans Verkuil wrote: On 11/22/2018 04:18 PM, Rui Miguel Silva wrote: Add bindings documentation for i.MX7 media drivers. The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva Reviewed-by: Rob Herring Acked-by: Sakari Ailus

Re: [RFC PATCH] media/Kconfig: always enable MEDIA_CONTROLLER and VIDEO_V4L2_SUBDEV_API

2018-12-07 Thread Mauro Carvalho Chehab
Em Fri, 7 Dec 2018 14:27:48 +0100 Hans Verkuil escreveu: > On 12/07/2018 01:42 PM, Mauro Carvalho Chehab wrote: > > Em Fri, 7 Dec 2018 12:47:24 +0100 > > Hans Verkuil escreveu: > > > >> On 12/07/2018 12:26 PM, Mauro Carvalho Chehab wrote: > >>> Em Fri, 7 Dec 2018 10:09:04 +0100 > >>> Hans

Re: [PATCH v9 01/13] media: staging/imx: refactor imx media device probe

2018-12-07 Thread Rui Miguel Silva
Hi Hans, Thanks for the review. On Fri 07 Dec 2018 at 12:38, Hans Verkuil wrote: On 11/22/2018 04:18 PM, Rui Miguel Silva wrote: Refactor and move media device initialization code to a new common module, so it can be used by other devices, this will allow for example a near to introduce imx7

Re: [PATCH v2] media: cedrus: don't initialize pointers with zero

2018-12-07 Thread Mauro Carvalho Chehab
Em Fri, 07 Dec 2018 14:21:44 +0100 Paul Kocialkowski escreveu: > Hi, > > On Fri, 2018-12-07 at 08:03 -0500, Mauro Carvalho Chehab wrote: > > A common mistake is to assume that initializing a var with: > > struct foo f = { 0 }; > > > > Would initialize a zeroed struct. Actually, what this

Re: [PATCH v9 00/13] media: staging/imx7: add i.MX7 media driver

2018-12-07 Thread Dan Carpenter
On Fri, Dec 07, 2018 at 01:44:00PM +0100, Hans Verkuil wrote: > CHECK: Alignment should match open parenthesis > #936: FILE: drivers/staging/media/imx/imx7-mipi-csis.c:921: > + ret = v4l2_async_register_fwnode_subdev(mipi_sd, > + sizeof(struct

Re: [PATCH v5 00/12] imx-media: Fixes for interlaced capture

2018-12-07 Thread Hans Verkuil
Hi Steve, How to proceed with this w.r.t. the two gpu ipu patches? Are those going in first through the gpu tree? Or do they have to go in through our tree? In that case I need Acks from whoever maintains that code. Regards, Hans On 10/17/2018 02:00 AM, Steve Longerbeam wrote: > A set

Re: [RFC PATCH] media/Kconfig: always enable MEDIA_CONTROLLER and VIDEO_V4L2_SUBDEV_API

2018-12-07 Thread Hans Verkuil
On 12/07/2018 01:42 PM, Mauro Carvalho Chehab wrote: > Em Fri, 7 Dec 2018 12:47:24 +0100 > Hans Verkuil escreveu: > >> On 12/07/2018 12:26 PM, Mauro Carvalho Chehab wrote: >>> Em Fri, 7 Dec 2018 10:09:04 +0100 >>> Hans Verkuil escreveu: >>> This patch selects MEDIA_CONTROLLER for all

Re: [PATCH] media: cedrus: don't initialize pointers with zero

2018-12-07 Thread Dan Carpenter
On Fri, Dec 07, 2018 at 09:31:06AM -0200, Mauro Carvalho Chehab wrote: > Em Fri, 7 Dec 2018 12:14:50 +0100 > Hans Verkuil escreveu: > > > On 12/07/2018 11:56 AM, Mauro Carvalho Chehab wrote: > > > A common mistake is to assume that initializing a var with: > > > struct foo f = { 0 }; > > > >

Re: [PATCH v2] media: cedrus: don't initialize pointers with zero

2018-12-07 Thread Paul Kocialkowski
Hi, On Fri, 2018-12-07 at 08:03 -0500, Mauro Carvalho Chehab wrote: > A common mistake is to assume that initializing a var with: > struct foo f = { 0 }; > > Would initialize a zeroed struct. Actually, what this does is > to initialize the first element of the struct to zero. > >

Re: [PATCH] media: cetrus: return an error if alloc fails

2018-12-07 Thread Paul Kocialkowski
Hi, On Fri, 2018-12-07 at 06:13 -0500, Mauro Carvalho Chehab wrote: > As warned by smatch: > > drivers/staging/media/sunxi/cedrus/cedrus.c: > drivers/staging/media/sunxi/cedrus/cedrus.c:93 cedrus_init_ctrls() error: > potential null dereference 'ctx->ctrls'. (kzalloc returns null) > >

Re: [PATCHv3 1/1] Add ir-rcmm-driver

2018-12-07 Thread patrick9876
Hi Sean, Sorry, I just checked the first paragraph. I will send you a new release. Thanks, Patrick. On 07/12/2018 11:12, Sean Young wrote: Hi Patrick, On Fri, Dec 07, 2018 at 10:57:21AM +0100, Patrick LERDA wrote: Add support for RCMM infrared remote controls. Signed-off-by:

Re: [PATCH] media: cedrus: don't initialize pointers with zero

2018-12-07 Thread Mauro Carvalho Chehab
Em Fri, 7 Dec 2018 12:27:09 + Ian Arkver escreveu: > On 07/12/2018 11:37, Hans Verkuil wrote: > > On 12/07/2018 12:31 PM, Mauro Carvalho Chehab wrote: > >> Em Fri, 7 Dec 2018 12:14:50 +0100 > >> Hans Verkuil escreveu: > >> > >>> On 12/07/2018 11:56 AM, Mauro Carvalho Chehab wrote: >

Re: [PATCH v9 00/13] media: staging/imx7: add i.MX7 media driver

2018-12-07 Thread Hans Verkuil
On 11/22/2018 04:18 PM, Rui Miguel Silva wrote: > Hi, > This series introduces the Media driver to work with the i.MX7 SoC. it uses > the > already existing imx media core drivers but since the i.MX7, contrary to > i.MX5/6, do not have an IPU and because of that some changes in the imx media >

Re: [RFC PATCH] media/Kconfig: always enable MEDIA_CONTROLLER and VIDEO_V4L2_SUBDEV_API

2018-12-07 Thread Mauro Carvalho Chehab
Em Fri, 7 Dec 2018 12:47:24 +0100 Hans Verkuil escreveu: > On 12/07/2018 12:26 PM, Mauro Carvalho Chehab wrote: > > Em Fri, 7 Dec 2018 10:09:04 +0100 > > Hans Verkuil escreveu: > > > >> This patch selects MEDIA_CONTROLLER for all camera, analog TV and > >> digital TV drivers and selects

Re: [PATCH v9 05/13] media: dt-bindings: add bindings for i.MX7 media driver

2018-12-07 Thread Hans Verkuil
On 11/22/2018 04:18 PM, Rui Miguel Silva wrote: > Add bindings documentation for i.MX7 media drivers. > The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. > > Signed-off-by: Rui Miguel Silva > Reviewed-by: Rob Herring > Acked-by: Sakari Ailus Please move this patch to the beginning of the

Re: [PATCH v9 01/13] media: staging/imx: refactor imx media device probe

2018-12-07 Thread Hans Verkuil
On 11/22/2018 04:18 PM, Rui Miguel Silva wrote: > Refactor and move media device initialization code to a new common > module, so it can be used by other devices, this will allow for example > a near to introduce imx7 CSI driver, to use this media device. > > Signed-off-by: Rui Miguel Silva >

Re: [PATCH] media: cedrus: don't initialize pointers with zero

2018-12-07 Thread Ian Arkver
On 07/12/2018 11:37, Hans Verkuil wrote: On 12/07/2018 12:31 PM, Mauro Carvalho Chehab wrote: Em Fri, 7 Dec 2018 12:14:50 +0100 Hans Verkuil escreveu: On 12/07/2018 11:56 AM, Mauro Carvalho Chehab wrote: A common mistake is to assume that initializing a var with: struct foo f = { 0

Re: [RFC PATCH] media/Kconfig: always enable MEDIA_CONTROLLER and VIDEO_V4L2_SUBDEV_API

2018-12-07 Thread Hans Verkuil
On 12/07/2018 12:26 PM, Mauro Carvalho Chehab wrote: > Em Fri, 7 Dec 2018 10:09:04 +0100 > Hans Verkuil escreveu: > >> This patch selects MEDIA_CONTROLLER for all camera, analog TV and >> digital TV drivers and selects VIDEO_V4L2_SUBDEV_API automatically. >> >> This will allow us to simplify

Re: [PATCH] media: cedrus: don't initialize pointers with zero

2018-12-07 Thread Hans Verkuil
On 12/07/2018 12:31 PM, Mauro Carvalho Chehab wrote: > Em Fri, 7 Dec 2018 12:14:50 +0100 > Hans Verkuil escreveu: > >> On 12/07/2018 11:56 AM, Mauro Carvalho Chehab wrote: >>> A common mistake is to assume that initializing a var with: >>> struct foo f = { 0 }; >>> >>> Would initialize a

Re: [PATCH] media: cedrus: don't initialize pointers with zero

2018-12-07 Thread Mauro Carvalho Chehab
Em Fri, 7 Dec 2018 12:14:50 +0100 Hans Verkuil escreveu: > On 12/07/2018 11:56 AM, Mauro Carvalho Chehab wrote: > > A common mistake is to assume that initializing a var with: > > struct foo f = { 0 }; > > > > Would initialize a zeroed struct. Actually, what this does is > > to initialize

Re: [PATCH 4/5 RESEND] si470x-i2c: Add optional reset-gpio support

2018-12-07 Thread Hans Verkuil
Adding the actual author :-) Regards, Hans On 12/07/2018 12:25 PM, Michael Nazzareno Trimarchi wrote: > Hi > > On Fri, Dec 7, 2018 at 12:12 PM Hans Verkuil wrote: >> >> Subject: [PATCH 4/5] si470x-i2c: Add optional reset-gpio support >> Date: Wed, 5 Dec 2018 16:47:49 +0100 >> From:

Re: [PATCH v2 2/2] media: video-i2c: add Melexis MLX90640 thermal camera support

2018-12-07 Thread Hans Verkuil
On 11/22/2018 04:52 AM, Matt Ranostay wrote: > Add initial support for MLX90640 thermal cameras which output an 32x24 > greyscale pixel image along with 2 rows of coefficent data. > > Because of this the data outputed is really 32x26 and needs the two rows > removed after using the coefficent

Re: [RFC PATCH] media/Kconfig: always enable MEDIA_CONTROLLER and VIDEO_V4L2_SUBDEV_API

2018-12-07 Thread Mauro Carvalho Chehab
Em Fri, 7 Dec 2018 10:09:04 +0100 Hans Verkuil escreveu: > This patch selects MEDIA_CONTROLLER for all camera, analog TV and > digital TV drivers and selects VIDEO_V4L2_SUBDEV_API automatically. > > This will allow us to simplify drivers that currently have to add > #ifdef

Re: [PATCH 4/5 RESEND] si470x-i2c: Add optional reset-gpio support

2018-12-07 Thread Michael Nazzareno Trimarchi
Hi On Fri, Dec 7, 2018 at 12:12 PM Hans Verkuil wrote: > > Subject: [PATCH 4/5] si470x-i2c: Add optional reset-gpio support > Date: Wed, 5 Dec 2018 16:47:49 +0100 > From: Paweł Chmiel > To: mche...@kernel.org, robh...@kernel.org, mark.rutl...@arm.com > CC: hverk...@xs4all.nl,

Re: [PATCH] media: cedrus: don't initialize pointers with zero

2018-12-07 Thread Hans Verkuil
On 12/07/2018 11:56 AM, Mauro Carvalho Chehab wrote: > A common mistake is to assume that initializing a var with: > struct foo f = { 0 }; > > Would initialize a zeroed struct. Actually, what this does is > to initialize the first element of the struct to zero. > > According to C99

Re: [PATCHv3 1/1] Add ir-rcmm-driver

2018-12-07 Thread Sean Young
Hi Patrick, On Fri, Dec 07, 2018 at 10:57:21AM +0100, Patrick LERDA wrote: > Add support for RCMM infrared remote controls. > > Signed-off-by: Patrick Lerda Other than the Signed-off-by this looks exactly like the v2 version; did you see my other comments on the v2 patch? Thanks Sean > ---

Re: [PATCH] media: venus: Add support for H265 controls required by gstreamer V4L2 H265 module

2018-12-07 Thread Stanimir Varbanov
Hi Kelvin, Thanks for the patch! On 11/30/18 7:31 PM, Kelvin Lawson wrote: > Add support for V4L2_CID_MPEG_VIDEO_HEVC_PROFILE and > V4L2_CID_MPEG_VIDEO_HEVC_LEVEL controls required by gstreamer V4L2 H265 > encoder module. > > Signed-off-by: Kelvin Lawson > --- >

Re: [PATCH v2] media: venus: Support V4L2 QP parameters in Venus encoder

2018-12-07 Thread Stanimir Varbanov
Hi Kelvin, Thanks for the patch! On 11/30/18 2:07 AM, Kelvin Lawson wrote: > Support V4L2 QP parameters in Venus encoder: > * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_QP > * V4L2_CID_MPEG_VIDEO_H264_B_FRAME_QP > * V4L2_CID_MPEG_VIDEO_H264_MIN_QP > * V4L2_CID_MPEG_VIDEO_H264_MAX_QP > >

Re: Invite for IRC meeting: Re: [PATCHv4 01/10] videodev2.h: add tag support

2018-12-07 Thread Alexandre Courbot
Hi Hans, On Fri, Dec 7, 2018 at 12:08 AM Hans Verkuil wrote: > > Mauro raised a number of objections on irc regarding tags: > > https://linuxtv.org/irc/irclogger_log/media-maint?date=2018-12-06,Thu > > I would like to setup an irc meeting to discuss this and come to a > conclusion, since we need

RE,

2018-12-06 Thread Sharifah Ahmad Mustahfa
-- Hello First of all i will like to apologies for my manner of communication because you do not know me personally, its due to the fact that i have a very important proposal for you.

Re: [PATCH v5] media: imx: add mem2mem device

2018-12-06 Thread Steve Longerbeam
Hi Hans, On 12/6/18 4:32 AM, Hans Verkuil wrote: On 12/06/18 00:13, Steve Longerbeam wrote: On 12/5/18 10:50 AM, Hans Verkuil wrote: On 12/05/2018 02:20 AM, Steve Longerbeam wrote: Hi Hans, Philipp, One comment on my side... On 12/3/18 7:21 AM, Hans Verkuil wrote: +void

Re: [PATCH v2] media: rockchip vpu: remove some unused vars

2018-12-06 Thread Ezequiel Garcia
On Wed, 2018-12-05 at 19:01 -0500, Mauro Carvalho Chehab wrote: > As complained by gcc: > > drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c: In > function 'rk3288_vpu_jpeg_enc_set_qtable': > drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c:70:10: > warning:

Re: [PATCH] Revert 95f408bb Ryzen DMA related RiSC engine stall fixes

2018-12-06 Thread Mauro Carvalho Chehab
Em Thu, 6 Dec 2018 17:07:52 -0200 Mauro Carvalho Chehab escreveu: > Em Thu, 6 Dec 2018 13:36:24 -0500 > Alex Deucher escreveu: > > > On Thu, Dec 6, 2018 at 1:05 PM Mauro Carvalho Chehab > > wrote: > > > > > > Em Thu, 06 Dec 2018 18:18:23 +0100 > > > Markus Dobel escreveu: > > > > > >

Re: [PATCH] Revert 95f408bb Ryzen DMA related RiSC engine stall fixes

2018-12-06 Thread Mauro Carvalho Chehab
Em Thu, 6 Dec 2018 13:36:24 -0500 Alex Deucher escreveu: > On Thu, Dec 6, 2018 at 1:05 PM Mauro Carvalho Chehab > wrote: > > > > Em Thu, 06 Dec 2018 18:18:23 +0100 > > Markus Dobel escreveu: > > > > > Hi everyone, > > > > > > I will try if the hack mentioned fixes the issue for me on the

Re: [PATCH] Revert 95f408bb Ryzen DMA related RiSC engine stall fixes

2018-12-06 Thread Alex Deucher
On Thu, Dec 6, 2018 at 1:05 PM Mauro Carvalho Chehab wrote: > > Em Thu, 06 Dec 2018 18:18:23 +0100 > Markus Dobel escreveu: > > > Hi everyone, > > > > I will try if the hack mentioned fixes the issue for me on the weekend (but > > I assume, as if effectively removes the function). > > It

Re: [PATCH] Revert 95f408bb Ryzen DMA related RiSC engine stall fixes

2018-12-06 Thread Mauro Carvalho Chehab
Em Thu, 06 Dec 2018 18:18:23 +0100 Markus Dobel escreveu: > Hi everyone, > > I will try if the hack mentioned fixes the issue for me on the weekend (but I > assume, as if effectively removes the function). It should, but it keeps a few changes. Just want to be sure that what would be left

Re: [PATCH] Revert 95f408bb Ryzen DMA related RiSC engine stall fixes

2018-12-06 Thread Markus Dobel
Hi everyone, I will try if the hack mentioned fixes the issue for me on the weekend (but I assume, as if effectively removes the function). Just in case this is of interest, I neither have Ryzen nor Intel, but an HP Microserver G7 with an AMD Turion II Neo N54L, so the machine is more on the

Re: [PATCH] Revert 95f408bb Ryzen DMA related RiSC engine stall fixes

2018-12-06 Thread Brad Love
Hi Mauro & Markus, On 05/12/2018 05.07, Mauro Carvalho Chehab wrote: > Em Sun, 21 Oct 2018 15:45:39 +0200 > Markus Dobel escreveu: > >> The original commit (the one reverted in this patch) introduced a >> regression, >> making a previously flawless adapter unresponsive after running a few >>

Re: [PATCH v6 00/12] media: ov5640: Misc cleanup and improvements

2018-12-06 Thread Jagan Teki
On Mon, Dec 3, 2018 at 2:14 PM Maxime Ripard wrote: > > Hi, > > Here is a "small" series that mostly cleans up the ov5640 driver code, > slowly getting rid of the big data array for more understandable code > (hopefully). > > The biggest addition would be the clock rate computation at runtime, >

Invite for IRC meeting: Re: [PATCHv4 01/10] videodev2.h: add tag support

2018-12-06 Thread Hans Verkuil
Mauro raised a number of objections on irc regarding tags: https://linuxtv.org/irc/irclogger_log/media-maint?date=2018-12-06,Thu I would like to setup an irc meeting to discuss this and come to a conclusion, since we need to decide this soon since this is critical for stateless codec support.

Re: [PATCH] [PATCHv2] Add ir-rcmm-driver

2018-12-06 Thread Sean Young
On Wed, Dec 05, 2018 at 01:29:33AM +0100, patrick9...@free.fr wrote: > From: Patrick LERDA > We need a Signed-off-by: here. https://www.kernel.org/doc/html/v4.12/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin > --- > drivers/media/rc/Kconfig |

Re: [PATCH v11 2/4] ARM: dts: rockchip: add VPU device node for RK3288

2018-12-06 Thread Heiko Stuebner
Am Freitag, 30. November 2018, 18:34:31 CET schrieb Ezequiel Garcia: > Add the Video Processing Unit node for RK3288 SoC. > > Fix the VPU IOMMU node, which was disabled and lacking > its power domain property. > > Reviewed-by: Tomasz Figa > Signed-off-by: Ezequiel Garcia applied for 4.21

Re: [PATCH v11 3/4] arm64: dts: rockchip: add VPU device node for RK3399

2018-12-06 Thread Heiko Stuebner
Am Freitag, 30. November 2018, 18:34:32 CET schrieb Ezequiel Garcia: > Add the Video Processing Unit node for the RK3399 SoC. > > Also, fix the VPU IOMMU node, which was disabled and lacking > its power domain property. > > Reviewed-by: Tomasz Figa > Signed-off-by: Ezequiel Garcia applied for

Re: [PATCH v5] media: imx: add mem2mem device

2018-12-06 Thread Hans Verkuil
On 12/06/18 00:13, Steve Longerbeam wrote: > > > On 12/5/18 10:50 AM, Hans Verkuil wrote: >> On 12/05/2018 02:20 AM, Steve Longerbeam wrote: >>> Hi Hans, Philipp, >>> >>> One comment on my side... >>> >>> On 12/3/18 7:21 AM, Hans Verkuil wrote: > +void

Re: [PATCHv4 00/10] vb2/cedrus: add tag support

2018-12-06 Thread Hans Verkuil
(fix copy and paste error in the cover letter) As was discussed here (among other places): https://lkml.org/lkml/2018/10/19/440 using capture queue buffer indices to refer to reference frames is not a good idea. A better idea is to use a 'tag' where the application can assign a u32 tag to an

Re: [PATCH v5] media: imx: add mem2mem device

2018-12-05 Thread Steve Longerbeam
On 12/5/18 10:50 AM, Hans Verkuil wrote: On 12/05/2018 02:20 AM, Steve Longerbeam wrote: Hi Hans, Philipp, One comment on my side... On 12/3/18 7:21 AM, Hans Verkuil wrote: +void imx_media_mem2mem_device_unregister(struct imx_media_video_dev *vdev) +{ + struct mem2mem_priv *priv =

Re: [GIT PULL FOR v4.21] Rockchip VPU JPEG encoder driver

2018-12-05 Thread Mauro Carvalho Chehab
Em Wed, 05 Dec 2018 17:02:46 -0300 Ezequiel Garcia escreveu: > On Wed, 2018-12-05 at 16:37 -0200, Mauro Carvalho Chehab wrote: > > Em Wed, 5 Dec 2018 16:34:04 -0200 > > Mauro Carvalho Chehab escreveu: > > > > > Em Wed, 5 Dec 2018 17:29:38 +0100 > > > Hans Verkuil escreveu: > > > > > > >

Re: [GIT PULL FOR v4.21] Rockchip VPU JPEG encoder driver

2018-12-05 Thread Ezequiel Garcia
On Wed, 2018-12-05 at 16:37 -0200, Mauro Carvalho Chehab wrote: > Em Wed, 5 Dec 2018 16:34:04 -0200 > Mauro Carvalho Chehab escreveu: > > > Em Wed, 5 Dec 2018 17:29:38 +0100 > > Hans Verkuil escreveu: > > > > > Note regarding the first 'Revert' patch: that is this patch: > > > > > >

Re: [PATCH] media: rockchip/vpu: fix a few alignments

2018-12-05 Thread Mauro Carvalho Chehab
Em Wed, 5 Dec 2018 19:48:25 +0100 Hans Verkuil escreveu: > On 12/05/2018 07:43 PM, Mauro Carvalho Chehab wrote: > > As reported by checkpatch.pl, some function calls have a wrong > > alignment. > > > > Signed-off-by: Mauro Carvalho Chehab > > --- > >

Re: [PATCH 2/3] media: stkwebcam: Bugfix for not correctly initialized camera

2018-12-05 Thread Mauro Carvalho Chehab
Em Wed, 5 Dec 2018 16:56:39 -0200 Mauro Carvalho Chehab escreveu: > Em Fri, 30 Nov 2018 15:58:07 +0100 > Andreas Pape escreveu: > > > Hi Kieran, > > > > thanks for the review. > > > > On Mon, 26 Nov 2018 12:48:08 + > > Kieran Bingham wrote: > > > > > This one worries me a little...

Re: [PATCH 2/3] media: stkwebcam: Bugfix for not correctly initialized camera

2018-12-05 Thread Mauro Carvalho Chehab
Em Fri, 30 Nov 2018 15:58:07 +0100 Andreas Pape escreveu: > Hi Kieran, > > thanks for the review. > > On Mon, 26 Nov 2018 12:48:08 + > Kieran Bingham wrote: > > > This one worries me a little... (but hopefully not too much) > > > > As mentioned, I don't have any experience concerning

Re: [PATCH v5] media: imx: add mem2mem device

2018-12-05 Thread Hans Verkuil
On 12/05/2018 02:20 AM, Steve Longerbeam wrote: > Hi Hans, Philipp, > > One comment on my side... > > On 12/3/18 7:21 AM, Hans Verkuil wrote: >> >>> +void imx_media_mem2mem_device_unregister(struct imx_media_video_dev *vdev) >>> +{ >>> + struct mem2mem_priv *priv = to_mem2mem_priv(vdev); >>>

Re: [PATCH] media: rockchip/vpu: fix a few alignments

2018-12-05 Thread Hans Verkuil
On 12/05/2018 07:43 PM, Mauro Carvalho Chehab wrote: > As reported by checkpatch.pl, some function calls have a wrong > alignment. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c | 4 ++-- >

Re: [GIT PULL FOR v4.21] Rockchip VPU JPEG encoder driver

2018-12-05 Thread Mauro Carvalho Chehab
Em Wed, 5 Dec 2018 16:34:04 -0200 Mauro Carvalho Chehab escreveu: > Em Wed, 5 Dec 2018 17:29:38 +0100 > Hans Verkuil escreveu: > > > Note regarding the first 'Revert' patch: that is this patch: > > > > https://patchwork.linuxtv.org/patch/52869/ > > > > It is currently pending for 4.20 as a

Re: [GIT PULL FOR v4.21] Rockchip VPU JPEG encoder driver

2018-12-05 Thread Mauro Carvalho Chehab
Em Wed, 5 Dec 2018 17:29:38 +0100 Hans Verkuil escreveu: > Note regarding the first 'Revert' patch: that is this patch: > > https://patchwork.linuxtv.org/patch/52869/ > > It is currently pending for 4.20 as a fix, but since it is not merged upstream > yet, our master branch still has those old

Re: [PATCH v2 1/1] media: Add a Kconfig option for the Request API

2018-12-05 Thread Mauro Carvalho Chehab
Em Wed, 5 Dec 2018 19:23:54 +0200 Sakari Ailus escreveu: > The Request API is now merged to the kernel but the confidence on the > stability of that API is not great, especially regarding the interaction > with V4L2. > > Add a Kconfig option for the API, with a scary-looking warning. > > The

Re: [PATCH v11 4/4] media: add Rockchip VPU JPEG encoder driver

2018-12-05 Thread Ezequiel Garcia
Hi Hans, On Wed, 2018-12-05 at 16:01 +0100, Hans Verkuil wrote: > On 11/30/18 18:34, Ezequiel Garcia wrote: > > Add a mem2mem driver for the VPU available on Rockchip SoCs. > > Currently only JPEG encoding is supported, for RK3399 and RK3288 > > platforms. > > > > Signed-off-by: Ezequiel Garcia

Re: [PATCH v11 4/4] media: add Rockchip VPU JPEG encoder driver

2018-12-05 Thread Ezequiel Garcia
On Wed, 2018-12-05 at 16:01 +0100, Hans Verkuil wrote: > Unless something unexpected happens, then v12 should be the final > version and I'll make a pull request for it. Note that it will > probably won't make 4.20, unless you manage to do it within the next > hour :-) Challenge accepted!

Re: [PATCH v11 4/4] media: add Rockchip VPU JPEG encoder driver

2018-12-05 Thread Hans Verkuil
On 11/30/18 18:34, Ezequiel Garcia wrote: > Add a mem2mem driver for the VPU available on Rockchip SoCs. > Currently only JPEG encoding is supported, for RK3399 and RK3288 > platforms. > > Signed-off-by: Ezequiel Garcia > --- > diff --git

Re: [PATCH 1/1] ipu3-cio2: Allow probe to succeed if there are no sensors connected

2018-12-05 Thread Rajneesh Bhardwaj
On Wed, Dec 05, 2018 at 04:15:17PM +0200, Sakari Ailus wrote: > The device won't be powered off on systems that have no sensors connected > unless it has a driver bound to it. Allow that to happen even if there are > no sensors connected to cio2. Thanks for sending this. It helps to put the pci

Re: [PATCH for v4.20 0/2] cedrus: move MPEG controls out of the uAPI

2018-12-05 Thread Paul Kocialkowski
Hi, On Wed, 2018-12-05 at 13:09 +0100, hverkuil-ci...@xs4all.nl wrote: > From: Hans Verkuil > > The expectation was that the MPEG-2 state controls used by the staging > cedrus driver were stable, or would only require one final change. However, > it turns out that more changes are required, and

Re: [PATCH 1/1] media: Add a Kconfig option for the Request API

2018-12-05 Thread Hans Verkuil
On 12/05/18 13:24, Sakari Ailus wrote: > The Request API is now merged to the kernel but the confidence on the > stability of that API is not great, especially regarding the interaction > with V4L2. > > Add a Kconfig option for the API, with a scary-looking warning. > > The patch itself disables

Re: [PATCH] Revert 95f408bb Ryzen DMA related RiSC engine stall fixes

2018-12-05 Thread Mauro Carvalho Chehab
Em Sun, 21 Oct 2018 15:45:39 +0200 Markus Dobel escreveu: > The original commit (the one reverted in this patch) introduced a > regression, > making a previously flawless adapter unresponsive after running a few > hours > to days. Since I never experienced the problems that the original commit

Re: [PATCH v3 0/9] TVP5150 fixes and new features

2018-12-05 Thread Mauro Carvalho Chehab
Hi Marco, Em Fri, 9 Nov 2018 14:46:24 +0100 Marco Felsch escreveu: > Hi Mauro, > > I don't want to spam you. Can you give me some feedback? I know the > merge window is a busy time, so maybe you have some time now. Sorry for taking so long on looking into it... has been really busy those days

Re: [PATCH v9 04/13] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

2018-12-05 Thread Rui Miguel Silva
Hi Sakari, Thanks for the review. On Mon 03 Dec 2018 at 12:10, Sakari Ailus wrote: Hi Rui, On Thu, Nov 22, 2018 at 03:18:25PM +, Rui Miguel Silva wrote: Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva ---

Re: [PATCH 1/4] libdvbv5: do not adjust DVB time daylight saving

2018-12-05 Thread Mauro Carvalho Chehab
Em Sat, 7 Jul 2018 13:20:54 +0200 André Roth escreveu: > This makes dvb_time available outside of EIT parsing, and > struct tm to reflect the actual values received from DVB. > > Signed-off-by: André Roth > --- > lib/include/libdvbv5/descriptors.h | 11 +++ >

Re: [PATCH v5] media: imx: add mem2mem device

2018-12-04 Thread Steve Longerbeam
Hi Hans, Philipp, One comment on my side... On 12/3/18 7:21 AM, Hans Verkuil wrote: +void imx_media_mem2mem_device_unregister(struct imx_media_video_dev *vdev) +{ + struct mem2mem_priv *priv = to_mem2mem_priv(vdev); + struct video_device *vfd = priv->vdev.vfd; + +

RE: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-12-04 Thread Mani, Rajmohan
Hi Laurent, > > Hi Rajmohan, > > > > On Tuesday, 4 December 2018 18:07:16 EET Mani, Rajmohan wrote: > > > >> On Thursday, 29 November 2018 21:51:32 EET Tomasz Figa wrote: > > > >>> On Thu, Nov 29, 2018 at 6:43 AM Laurent Pinchart wrote: > > > On Tuesday, 30 October 2018 00:22:54 EET Yong Zhi

Re: [PATCH] Add ir-rcmm-driver

2018-12-04 Thread patrick9876
The toggle flag is well handled with this code and at the kernel level; This adds reliability. Patrick. On 04/12/2018 22:06, patrick9...@free.fr wrote: We have so many decoders at the linux kernel level now. I'm not sure of the best option. Patrick. On 04/12/2018 21:57, Sean Young wrote:

Re: [PATCH] Add ir-rcmm-driver

2018-12-04 Thread patrick9876
We have so many decoders at the linux kernel level now. I'm not sure of the best option. Patrick. On 04/12/2018 21:57, Sean Young wrote: On Tue, Dec 04, 2018 at 09:20:25PM +0100, patrick9...@free.fr wrote: From: Patrick LERDA --- drivers/media/rc/Kconfig | 10 ++

Re: [PATCH] Add ir-rcmm-driver

2018-12-04 Thread Sean Young
On Tue, Dec 04, 2018 at 09:20:25PM +0100, patrick9...@free.fr wrote: > From: Patrick LERDA > > --- > drivers/media/rc/Kconfig | 10 ++ > drivers/media/rc/Makefile | 1 + > drivers/media/rc/ir-rcmm-decoder.c | 185 + >

Re: [PATCH 3/4] media: lmedm04: Move interrupt buffer to priv buffer.

2018-12-04 Thread Sean Young
On Thu, Nov 29, 2018 at 10:30:15PM +, Malcolm Priestley wrote: > Interrupt is always present throught life time of > there is no dma element move this buffer to private > area of driver. > > Signed-off-by: Malcolm Priestley > --- > drivers/media/usb/dvb-usb-v2/lmedm04.c | 26

Re: [PATCH 1/4] media: lmedm04: Add missing usb_free_urb to free, interrupt urb

2018-12-04 Thread Sean Young
On Thu, Nov 29, 2018 at 10:29:31PM +, Malcolm Priestley wrote: > The interrupt urb is killed but never freed add the function > > Cc: sta...@vger.kernel.org > Signed-off-by: Malcolm Priestley > --- > drivers/media/usb/dvb-usb-v2/lmedm04.c | 1 + > 1 file changed, 1 insertion(+) > > diff

RE: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-12-04 Thread Mani, Rajmohan
ehab > ; Hans Verkuil ; Zheng, Jian > Xu ; Hu, Jerry W ; > Toivonen, Tuukka ; Qiu, Tian Shu > ; Cao, Bingbu > Subject: Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset > > Hi Rajmohan, > > On Tuesday, 4 December 2018 18:07:16 EET Mani, Rajmohan wrote: > > >>

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-12-04 Thread Laurent Pinchart
Hi Rajmohan, On Tuesday, 4 December 2018 18:07:16 EET Mani, Rajmohan wrote: > >> On Thursday, 29 November 2018 21:51:32 EET Tomasz Figa wrote: > >>> On Thu, Nov 29, 2018 at 6:43 AM Laurent Pinchart wrote: > On Tuesday, 30 October 2018 00:22:54 EET Yong Zhi wrote: > >> > >> [snip] > >> >

RE: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-12-04 Thread Mani, Rajmohan
Hi Laurent, Tomasz, > > Thanks for the reviews. > > > Subject: Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset > > > > Hi Tomasz, > > > > On Thursday, 29 November 2018 21:51:32 EET Tomasz Figa wrote: > > > On Thu, Nov 29, 2018 at 6:43 AM Laurent Pin

Re: [PATCH v2 1/1] media: Use common test pattern menu entries

2018-12-04 Thread Mauro Carvalho Chehab
Em Tue, 4 Dec 2018 15:40:42 +0200 Sakari Ailus escreveu: > While the test pattern menu itself is not standardised, many devices > support the same test patterns. Aligning the menu entries helps the user > space to use the interface, and adding macros for the menu entry strings > helps to keep

Re: [PATCH 1/1] v4l uapi: Make "Vertical Colour Bars" menu item a little more generic

2018-12-04 Thread Mauro Carvalho Chehab
Em Tue, 4 Dec 2018 12:32:32 -0200 Mauro Carvalho Chehab escreveu: > Em Tue, 4 Dec 2018 15:45:06 +0200 > Sakari Ailus escreveu: > > > The test pattern could contain a different number of colour bars than > > eight, make the entry more useful by removing "Eight " from the name. > > > >

Re: [PATCH 1/1] v4l uapi: Make "Vertical Colour Bars" menu item a little more generic

2018-12-04 Thread Mauro Carvalho Chehab
Em Tue, 4 Dec 2018 15:45:06 +0200 Sakari Ailus escreveu: > The test pattern could contain a different number of colour bars than > eight, make the entry more useful by removing "Eight " from the name. > > Signed-off-by: Sakari Ailus > --- > include/uapi/linux/v4l2-controls.h | 2 +- > 1 file

Re: [PATCH 1/1] media: Use common test pattern menu entries

2018-12-04 Thread sakari . ailus
On Tue, Nov 27, 2018 at 07:19:52PM +0800, Bingbu Cao wrote: > > On 11/27/2018 05:33 PM, Sakari Ailus wrote: > > diff --git a/include/uapi/linux/v4l2-controls.h > > b/include/uapi/linux/v4l2-controls.h > > index 998983a6e6b7..a74ff6f1ac88 100644 > > --- a/include/uapi/linux/v4l2-controls.h > >

Re: [PATCH v2] v4l2-ioctl: Zero v4l2_plane_pix_format reserved fields

2018-12-04 Thread sakari . ailus
On Tue, Nov 27, 2018 at 07:07:56PM -0300, Ezequiel Garcia wrote: > Make the core set the reserved fields to zero in > vv4l2_pix_format_mplane.4l2_plane_pix_format, > for _MPLANE queue types. > > Moving this to the core avoids having to do so in each > and every driver. > > Suggested-by: Tomasz

Re: [PATCH v6 09/10] media: uvcvideo: Rename uvc_{un,}init_video()

2018-12-04 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday, 9 November 2018 19:15:42 EET Kieran Bingham wrote: > Hi Laurent, > > I'm sorry - I didn't update the commit message on this one. > > On 09/11/2018 17:05, Kieran Bingham wrote: > > We have both uvc_init_video() and uvc_video_init() calls which can

Re: [PATCH v6 08/10] media: uvcvideo: Split uvc_video_enable into two

2018-12-04 Thread Laurent Pinchart
Hi Kieran, On Sunday, 11 November 2018 00:02:39 EET Kieran Bingham wrote: > Hi Laurent, > > I see that you made changes to this patch before accepting it last time. > > I'm afraid I haven't made those changes here, so please just cherry-pick > your previous incarnation. There are no changes

Re: [PATCH v6 07/10] media: uvcvideo: Move decode processing to process context

2018-12-04 Thread Laurent Pinchart
than the maximum size (or >* a payload size equal to the maximum) and process the header again. > @@ -1472,7 +1507,7 @@ static void uvc_video_complete(struct urb *urb) > uvc_printk(KERN_WARNING, "Non-zero status (%d) in video " > &q

Re: [PATCH v6 06/10] media: uvcvideo: Abstract streaming object lifetime

2018-12-04 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday, 9 November 2018 19:05:29 EET Kieran Bingham wrote: > The streaming object is a key part of handling the UVC device. Although > not critical, we are currently missing a call to destroy the mutex on > clean up paths, and we are due to extend the

Re: [PATCH dvb v1 3/4] media: dvb-usb-v2: remove __func__ from dev_dbg()

2018-12-04 Thread Victor Toso
Hi Sean, Thanks for taking time to review those patches. On Tue, Nov 27, 2018 at 10:32:44AM +, Sean Young wrote: > On Tue, Oct 30, 2018 at 05:14:50PM +0100, Victor Toso wrote: > > From: Victor Toso > > > > As dynamic debug can be instructed to add the function name to the > > debug output

Re: [PATCH v6 01/12] media: ov5640: Fix set format regression

2018-12-03 Thread Adam Ford
On Mon, Dec 3, 2018 at 2:45 AM Maxime Ripard wrote: > > From: Jacopo Mondi > > The set_fmt operations updates the sensor format only when the image format > is changed. When only the image sizes gets changed, the format do not get > updated causing the sensor to always report the one that was

Re: [GIT PULL FOR v4.21] dvb fixes

2018-12-03 Thread Mauro Carvalho Chehab
following changes since commit 708d75fe1c7c6e9abc5381b6fcc32b49830383d0: > > media: dvb-pll: don't re-validate tuner frequencies (2018-11-23 12:27:18 > -0500) > > are available in the Git repository at: > > git://linuxtv.org/syoung/media_t

Re: [PATCH 2/2] media: ov5640: make MIPI clock depend on mode

2018-12-03 Thread jacopo mondi
CLK > > + *+++ > > + * + +---+ > > + * +->| P_DIV | - reg 0x3035, bits 0-3 > > + *+-----+-+ > > + *

  1   2   3   4   5   6   7   8   9   10   >