Re: [PATCH] media: saa7134 fix media_dev alloc error path to not free when alloc fails

2016-04-15 Thread Mauro Carvalho Chehab
Em Thu, 14 Apr 2016 16:18:17 -0600 Shuah Khan escreveu: > On 04/14/2016 03:08 PM, Mauro Carvalho Chehab wrote: > > Em Thu, 14 Apr 2016 10:31:20 -0600 > > Shuah Khan escreveu: > > > >> media_dev alloc error path does kfree when alloc fails. Fix

Re: [PATCH] media: saa7134 fix media_dev alloc error path to not free when alloc fails

2016-04-14 Thread Shuah Khan
On 04/14/2016 03:08 PM, Mauro Carvalho Chehab wrote: > Em Thu, 14 Apr 2016 10:31:20 -0600 > Shuah Khan escreveu: > >> media_dev alloc error path does kfree when alloc fails. Fix it to not call >> kfree when media_dev alloc fails. > > No need. kfree(NULL) is OK. Agreed.

Re: [PATCH] media: saa7134 fix media_dev alloc error path to not free when alloc fails

2016-04-14 Thread Mauro Carvalho Chehab
Em Thu, 14 Apr 2016 10:31:20 -0600 Shuah Khan escreveu: > media_dev alloc error path does kfree when alloc fails. Fix it to not call > kfree when media_dev alloc fails. No need. kfree(NULL) is OK. Adding a label inside a conditional block is ugly. > > Signed-off-by: