Re: [PATCH] xc5000: fix memory corruption when unplugging device

2015-02-25 Thread Shuah Khan
On 02/24/2015 10:29 AM, Devin Heitmueller wrote: This patch addresses a regression introduced in the following patch: commit 5264a522a597032c009f9143686ebf0fa4e244fb Author: Shuah Khan shua...@osg.samsung.com Date: Mon Sep 22 21:30:46 2014 -0300 [media] media: tuner xc5000 - release

Re: [PATCH] xc5000: fix memory corruption when unplugging device

2015-02-25 Thread Devin Heitmueller
I would request you to add a comment here indicating the hybrid case scenario to avoid any future cleanup type work deciding there is no need to set priv-firmware to null since priv gets released in hybrid_tuner_release_state(priv); No, I'm not going to rebase my tree and regenerate the patch

Re: [PATCH] xc5000: fix memory corruption when unplugging device

2015-02-25 Thread Antti Palosaari
On 02/25/2015 07:56 PM, Devin Heitmueller wrote: I would request you to add a comment here indicating the hybrid case scenario to avoid any future cleanup type work deciding there is no need to set priv-firmware to null since priv gets released in hybrid_tuner_release_state(priv); No, I'm not

Re: [PATCH] xc5000: fix memory corruption when unplugging device

2015-02-25 Thread Devin Heitmueller
These are just the issues I would like to implement drivers as standard I2C driver model =) Attaching driver for one chip twice is ugly hack! While I'm not arguing the merits of using the standard I2C driver model, it won't actually help in this case since we would still need a structure

Re: [PATCH] xc5000: fix memory corruption when unplugging device

2015-02-25 Thread Mauro Carvalho Chehab
Em Wed, 25 Feb 2015 13:37:07 -0500 Devin Heitmueller dheitmuel...@kernellabs.com escreveu: These are just the issues I would like to implement drivers as standard I2C driver model =) Attaching driver for one chip twice is ugly hack! While I'm not arguing the merits of using the standard