Re: [PATCH v3 04/26] media: lirc_zilog: remove receiver

2017-10-12 Thread Sean Young
Hi Devin, Andy, On Wed, Oct 11, 2017 at 10:25:34PM -0400, Devin Heitmueller wrote: > Hi Andy, > > > 5. Rx and IR Learn both use the same external hardware. Not > > coordinating Rx with Learn mode in the same driver, will prevent Learn > > operation from working. That is, if Learn mode is ever

Re: [PATCH v3 04/26] media: lirc_zilog: remove receiver

2017-10-12 Thread Sean Young
On Wed, Oct 11, 2017 at 08:25:12PM -0400, Devin Heitmueller wrote: > > There's an ir_lock mutex in the driver to prevent simultaneous access to > > the Rx and Tx functions of the z8. Accessing Rx and Tx functions of the > > chip together can cause it to do the wrong thing (sometimes hang?),

Re: [PATCH v3 04/26] media: lirc_zilog: remove receiver

2017-10-11 Thread Devin Heitmueller
Hi Andy, > 5. Rx and IR Learn both use the same external hardware. Not > coordinating Rx with Learn mode in the same driver, will prevent Learn > operation from working. That is, if Learn mode is ever implemented. > (Once upon a time, I was planning on doing that. But I have no time > for that

Re: [PATCH v3 04/26] media: lirc_zilog: remove receiver

2017-10-11 Thread Andy Walls
Hi Sean and Devin: On Wed, 2017-10-11 at 20:25 -0400, Devin Heitmueller wrote: > > There's an ir_lock mutex in the driver to prevent simultaneous > > access to the Rx and Tx functions of the z8. Accessing Rx and Tx > > functions of the chip together can cause it to do the wrong thing > >

Re: [PATCH v3 04/26] media: lirc_zilog: remove receiver

2017-10-11 Thread Devin Heitmueller
> There's an ir_lock mutex in the driver to prevent simultaneous access to the > Rx and Tx functions of the z8. Accessing Rx and Tx functions of the chip > together can cause it to do the wrong thing (sometimes hang?), IIRC. > > I'll see if I can dig up my old disassembly of the z8's firmware

Re: [PATCH v3 04/26] media: lirc_zilog: remove receiver

2017-10-11 Thread Andy Walls
On October 11, 2017 5:02:37 PM EDT, Sean Young wrote: >On Wed, Oct 11, 2017 at 03:43:16PM -0400, Andy Walls wrote: >> On Tue, 2017-10-10 at 08:17 +0100, Sean Young wrote: >> > The ir-kbd-i2c module already handles this very well. >> >> Hi Sean: >> >> It's been years, but my

Re: [PATCH v3 04/26] media: lirc_zilog: remove receiver

2017-10-11 Thread Sean Young
On Wed, Oct 11, 2017 at 03:43:16PM -0400, Andy Walls wrote: > On Tue, 2017-10-10 at 08:17 +0100, Sean Young wrote: > > The ir-kbd-i2c module already handles this very well. > > Hi Sean: > > It's been years, but my recollection is that although ir-kdb-i2c might > handle receive well, but since

Re: [PATCH v3 04/26] media: lirc_zilog: remove receiver

2017-10-11 Thread Andy Walls
On Tue, 2017-10-10 at 08:17 +0100, Sean Young wrote: > The ir-kbd-i2c module already handles this very well. Hi Sean: It's been years, but my recollection is that although ir-kdb-i2c might handle receive well, but since the 4 i2c addresses (1 Rx, 1 Tx, 1 IR Tx code learning, 1 custom Tx code)